From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB2A2C04AAF for ; Sat, 18 May 2019 07:51:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A11D72166E for ; Sat, 18 May 2019 07:51:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o6hkyDTQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A11D72166E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gp6OZONG9NVNGej3dzFd6XKXuNGcWzPSG3o4IIkLliI=; b=o6hkyDTQNeskyQ mIzxtXRJxz79Fi0zJpb8ORaW1Uk2JJIiDrGekl8TxnFE1RInZ6XNdAJnHQsVolxaX5ndZe3XE/B7l hzILjkEZFGZSey/xzBeDxZ4sdtJDcaeJdhUX2a66yQm3Ar1MnEDhS7TwREvZi4yE3HZGxB7PnzUJt 1/PVfVaNjKKxI5LR4qxW4P4ewm/xI0ruecatV8JGzoIvsE4y5B3QJjIVEaoP6gdJby/mT4ElxU/as 6qpPymvDA4lVTkpxvDGzL9XO1zSpEoLv6josBcKmKA9RV8FkRCIDGP3H+tE/+sGj8x6H4hQq6jAx5 mTZQsus7YappwB10Lplg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRu7l-0008Gc-Br; Sat, 18 May 2019 07:51:21 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRu7h-0008Fp-Lu; Sat, 18 May 2019 07:51:19 +0000 Received: from p508fcf3a.dip0.t-ipconnect.de ([80.143.207.58] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hRu7X-0005Nr-HM; Sat, 18 May 2019 09:51:07 +0200 From: Heiko Stuebner To: Doug Anderson , Guenter Roeck , LKML , Linux ARM , Kishon Vijay Abraham I Subject: Re: [PATCH] phy: rockchip-dp: Avoid power leak by leaving the PHY power on Date: Sat, 18 May 2019 09:51:06 +0200 Message-ID: <1862323.vETM5zrFmV@phil> In-Reply-To: References: <20190507234857.81414-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190518_005117_868989_1678635F X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elaine Zhang , Lin Huang , Derek Basehore , "open list:ARM/Rockchip SoC..." , Matthias Kaehlcke , Ryan Case , Caesar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Samstag, 18. Mai 2019, 01:57:47 CEST schrieb Doug Anderson: > Elaine and Caesar, > > On Tue, May 7, 2019 at 4:50 PM Douglas Anderson wrote: > > > > While testing a newer kernel on rk3288-based Chromebooks I found that > > the power draw in suspend was higher on newer kernels compared to the > > downstream Chrome OS 3.14 kernel. Specifically the power of an > > rk3288-veyron-jerry board that I tested (as measured by the smart > > battery) was ~16 mA on Chrome OS 3.14 and ~21 mA on a newer kernel. > > > > I tracked the regression down to the fact that the "DP PHY" driver > > didn't exist in our downstream 3.14. We relied on the eDP driver to > > turn on the clock and relied on the fact that the power for the PHY > > was default turned on. > > > > Specifically the thing that caused the power regression was turning > > the eDP PHY _off_. Presumably there is some sort of power leak in the > > system and when we turn the PHY off something is leaching power from > > something else and causing excessive power draw. > > > > Doing a search through device trees shows that this PHY is only ever > > used on rk3288. Presumably this power leak is present on all > > rk3288-SoCs running upstream Linux so let's just whack the driver to > > make sure we never turn off power. We'll still leave the parts that > > turn _on_ the power and grab the clock, though. > > > > NOTES: > > A) If someone can identify what this power leak is and fix it in some > > other way we can revert this patch. > > B) If someone can show that their particular board doesn't have this > > power leak (maybe they have rails hooked up differently?) we can > > perhaps add a device tree property indicating that for some boards > > it's OK to turn this rail off. I don't want to add this property > > until I know of a board that needs it. > > > > Fixes: fd968973de95 ("phy: Add driver for rockchip Display Port PHY") > > Signed-off-by: Douglas Anderson > > --- > > As far as I know Yakir (the original author) is no longer at Rockchip. > > I've added a few other Rockchip people and hopefully one of them can > > help direct even if they're not directly responsible. > > > > drivers/phy/rockchip/phy-rockchip-dp.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > Can you help direct this to the right person? ...or should we just > land it and assume it's fine? I tink Kishon as phy-maintainer is the correct person to take on this patch, but maybe he's waiting for the merge-window to be over. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel