From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-kernel@vger.kernel.org, "Ben Dooks" <ben-linux@fluff.org>,
"Simtec Linux Team" <linux@simtec.co.uk>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Mark Brown" <broonie@kernel.org>,
"Juerg Haefliger" <juerg.haefliger@canonical.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>,
linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 05/21] ARM: s3c: simplify platform code
Date: Mon, 24 Oct 2022 10:13:26 -0400 [thread overview]
Message-ID: <186642c0-0417-9947-341c-a4c96257a84f@linaro.org> (raw)
In-Reply-To: <9912a1eb-ad12-4608-bf48-d74ac5f5805a@app.fastmail.com>
On 24/10/2022 09:32, Arnd Bergmann wrote:
> On Mon, Oct 24, 2022, at 14:29, Krzysztof Kozlowski wrote:
>
>>> diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx
>>> index c403d7642f0a..c52c7ce1d8fa 100644
>>> --- a/arch/arm/mach-s3c/Kconfig.s3c64xx
>>> +++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
>>> @@ -15,12 +15,9 @@ menuconfig ARCH_S3C64XX
>>> select HAVE_TCM
>>> select PLAT_SAMSUNG
>>> select PM_GENERIC_DOMAINS if PM
>>> - select S3C_DEV_NAND if ATAGS
>>> select S3C_GPIO_TRACK if ATAGS
>>> - select S3C2410_WATCHDOG
>>
>> This does not seem right. S3C2410_WATCHDOG is a driver used by all
>> (including Exynos) platforms.
>
> I don't remember why I removed this line, probably because I
> removed S3C_DEV_WDT after there are no references to that
> symbol left in board files. The watchdog driver is now DT-only
> with cragg6410 being the last remaining board file.
>
> Ideally we should not 'select' it from here but instead have
> it enabled in the defconfig file, but I agree that would
> be something to do in a separate patch, while the patch here
> should not change the behavior. I'll revert this part.
>
>>> @@ -121,10 +118,8 @@ config MACH_WLF_CRAGG_6410
>>> select S3C_DEV_HSMMC1
>>> select S3C_DEV_HSMMC2
>>> select S3C_DEV_I2C1
>>> - select S3C_DEV_RTC
>>
>> This as well.
>
> I'm fairly sure this can be removed along with S3C_DEV_WDT,
> S3C_DEV_I2C[2-7], S3C_DEV_NAND, and S3C_DEV_ONENAND
> as I remove the symbols due to the lack of references
> from cragg6410.
Yes, you are right. This can be dropped.
>
> I folded in this fixup now:
>
> --- a/arch/arm/mach-s3c/Kconfig.s3c64xx
> +++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
> @@ -16,8 +16,10 @@ menuconfig ARCH_S3C64XX
> select PLAT_SAMSUNG
> select PM_GENERIC_DOMAINS if PM
> select S3C_GPIO_TRACK if ATAGS
> + select S3C2410_WATCHDOG
> select SAMSUNG_ATAGS if ATAGS
> select SAMSUNG_WAKEMASK if PM
> + select WATCHDOG
Looks ok.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-24 14:14 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 20:22 [PATCH 00/21] ARM: s3c: clean out obsolete platforms Arnd Bergmann
2022-10-21 20:27 ` [PATCH 01/21] ARM: s3c: remove all s3c24xx support Arnd Bergmann
2022-10-22 20:56 ` Heiko Stübner
2022-10-24 14:27 ` Arnd Bergmann
2022-10-24 15:45 ` Heiko Stübner
2022-10-24 12:25 ` Krzysztof Kozlowski
2022-10-27 23:10 ` Stephen Boyd
2022-10-21 20:27 ` [PATCH 02/21] ARM: s3c: remove s3c24xx specific hacks Arnd Bergmann
2022-10-21 22:33 ` Wolfram Sang
2022-10-22 11:24 ` Greg Kroah-Hartman
2022-10-22 14:02 ` Linus Walleij
2022-10-23 11:00 ` Jonathan Cameron
2022-10-23 18:08 ` Daniel Lezcano
2022-10-24 7:55 ` Miquel Raynal
2022-10-24 12:26 ` Krzysztof Kozlowski
2022-10-24 16:53 ` Ulf Hansson
2022-10-27 23:10 ` Stephen Boyd
2022-10-21 20:27 ` [PATCH 03/21] ARM: s3c: remove most s3c64xx board support Arnd Bergmann
2022-10-24 12:26 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 04/21] ARM: s3c: remove adc.c Arnd Bergmann
2022-10-24 11:37 ` Mark Brown
2022-10-24 12:27 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 05/21] ARM: s3c: simplify platform code Arnd Bergmann
2022-10-24 11:41 ` Mark Brown
2022-10-24 12:29 ` Krzysztof Kozlowski
2022-10-24 13:32 ` Arnd Bergmann
2022-10-24 14:13 ` Krzysztof Kozlowski [this message]
2022-10-21 20:27 ` [PATCH 06/21] ARM: s3c: remove s3c6400 support Arnd Bergmann
2022-10-24 12:30 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 07/21] power: remove s3c adc battery driver Arnd Bergmann
2022-10-24 7:28 ` Lee Jones
2022-10-24 7:42 ` Arnd Bergmann
2022-10-24 7:57 ` Lee Jones
2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-28 14:18 ` Sebastian Reichel
2022-10-21 20:27 ` [PATCH 08/21] hwmon: remove s3c driver Arnd Bergmann
2022-10-22 4:02 ` Guenter Roeck
2022-10-22 8:36 ` Arnd Bergmann
2022-10-24 12:31 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 09/21] pata: remove samsung_cf driver Arnd Bergmann
2022-10-23 14:35 ` Sergey Shtylyov
2022-10-23 22:41 ` Damien Le Moal
2022-10-23 22:43 ` Damien Le Moal
2022-10-24 14:24 ` Arnd Bergmann
2022-10-24 12:34 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 10/21] mmc: remove s3cmci driver Arnd Bergmann
2022-10-24 12:35 ` Krzysztof Kozlowski
2022-10-24 16:52 ` Ulf Hansson
2022-10-21 20:27 ` [PATCH 11/21] clk: remove s3c24xx driver Arnd Bergmann
2022-10-22 11:50 ` Chanwoo Choi
2022-10-24 12:37 ` Krzysztof Kozlowski
2022-10-27 23:11 ` Stephen Boyd
2022-10-21 20:27 ` [PATCH 12/21] leds: " Arnd Bergmann
2022-10-22 10:04 ` Pavel Machek
2022-10-24 12:37 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 13/21] usb: gadget: remove s3c24xx drivers Arnd Bergmann
2022-10-24 12:39 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 14/21] dmaengine: remove s3c24xx driver Arnd Bergmann
2022-10-24 12:40 ` Krzysztof Kozlowski
2022-11-04 14:14 ` Vinod Koul
2022-10-21 20:27 ` [PATCH 15/21] cpufreq: remove s3c24xx drivers Arnd Bergmann
2022-10-24 12:40 ` Krzysztof Kozlowski
2022-10-25 5:19 ` Viresh Kumar
2022-10-21 20:27 ` [PATCH 16/21] fbdev: remove s3c2410 framebuffer Arnd Bergmann
2022-10-24 12:49 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 17/21] input: remove s3c24xx touchscreen driver Arnd Bergmann
2022-10-24 11:57 ` Dmitry Torokhov
2022-10-24 12:50 ` Krzysztof Kozlowski
2022-10-24 13:02 ` Arnd Bergmann
2022-10-21 20:27 ` [PATCH 18/21] pinctrl: remove s3c24xx driver Arnd Bergmann
2022-10-21 21:25 ` Linus Walleij
2022-10-24 12:51 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 19/21] spi: " Arnd Bergmann
2022-10-24 12:52 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 20/21] soc: s3c: remove pm-debug hack Arnd Bergmann
2022-10-24 12:52 ` Krzysztof Kozlowski
2022-10-21 20:27 ` [PATCH 21/21] ASoC: samsung: remove unused drivers Arnd Bergmann
2022-10-24 12:53 ` Krzysztof Kozlowski
2022-10-22 15:18 ` [PATCH 00/21] ARM: s3c: clean out obsolete platforms Krzysztof Kozlowski
2022-10-22 19:48 ` Arnd Bergmann
2022-10-24 13:00 ` Rob Herring
2022-10-24 13:18 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=186642c0-0417-9947-341c-a4c96257a84f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=juerg.haefliger@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@simtec.co.uk \
--cc=mchehab@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).