From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34110C6FA82 for ; Thu, 22 Sep 2022 09:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hv3qCPkC1kum44YVcJuzm2MYl6WWiNLIqJZSGvJhYBU=; b=M8TtBsqTAKR/GI FCPmVn6/iw4ujknQeUXfw1BfPQgECj9OW3I50Er7sOMne2mc+5xU1LtrTC1yxjXf6ho7eQ27SYezR UbFwWeKGwmgZxWD9/WYTBHsjR1nrckunVA3vM+Kj8XDFTTYys2gz67OCaThrAgi4L4y0EsuZ0606z Jf3ppced75Ux0eW1bvL9MLpLrrdqmojM4m9IlPKNqNXybVzR7g7J3qugYq9mIaEJrbTL8OwE8/Gnh fcwm32R406K9KJ/kPPIUq4cX5xXsO9AIWkZxyEEOt9rQ40/ErfbZBZfmRTBq9QN9I0ZXyEdz6VChL Yr+8vNBQ/P3tXHS0uNbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obIoc-00EYi2-6g; Thu, 22 Sep 2022 09:48:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obITZ-00EReQ-5J for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 09:26:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D683D1595; Thu, 22 Sep 2022 02:26:32 -0700 (PDT) Received: from [10.57.33.96] (unknown [10.57.33.96]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C321C3F73D; Thu, 22 Sep 2022 02:26:24 -0700 (PDT) Message-ID: <1867fb58-cb96-5d82-2518-e7212b6849a0@arm.com> Date: Thu, 22 Sep 2022 10:26:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/1] arm64: defconfig: Add Coresight as module To: James Clark , Mathieu Poirier , Mark Brown Cc: coresight@lists.linaro.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org, leo.yan@linaro.org, linux-kernel@vger.kernel.org, Will Deacon References: <20220921140535.152627-1-james.clark@arm.com> <20220921140535.152627-2-james.clark@arm.com> <20220921164622.GA1124503@p14s> <07d37df2-246e-70ea-4a9f-e33354d8864d@arm.com> From: Suzuki K Poulose In-Reply-To: <07d37df2-246e-70ea-4a9f-e33354d8864d@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_022633_328706_60704C00 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/09/2022 10:04, James Clark wrote: > > > On 21/09/2022 17:46, Mathieu Poirier wrote: >> On Wed, Sep 21, 2022 at 04:26:59PM +0100, Mark Brown wrote: >>> On Wed, Sep 21, 2022 at 03:05:35PM +0100, James Clark wrote: >>> >>>> +CONFIG_CORESIGHT_CTI=m >>>> +CONFIG_CORESIGHT_CTI_INTEGRATION_REGS=y >>> >> >> I agree - integration registers should not be enabled by default. >> >>> Do we want this turned on by default? According to the >>> description it's a bit dangerous and it's exposed via sysfs >>> rather than debugfs. >> >> > > Should I disable just CONFIG_CORESIGHT_CTI_INTEGRATION_REGS or > CONFIG_CORESIGHT_CTI as well? There are other writable registers exposed > via sysfs outside of these two options, so I wanted to check if it's > just the integration registers that are the issue. It is good/fine to keep CORESIGHT_CTI. But you may remove the INTEGRATION_REGS. They are there for "verification" of the CTI integration on the SoC. We added them only for the platform bring up purposes. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel