arm64: dts: rockchip: Add dma-names to uart-bluetooth rk3566 devices

arm64: dts: rockchip: Add dma-names to uart-bluetooth rk3566 devices

[Diederik de Haas]

This is a single patch which adds the dma-names property to the uart
node with a bluetooth subnode on Pine64's rk356x devices.

But that property can potentially be added to several other devices, but
I have zero familiarity with them or their community, so I choose not to
add it to those devices, but inform people via this cover letter.

The dts/dtsi files I found as potential candidates are:
- rk3566-anbernic-rgxx3.dtsi
- rk3566-box-demo.dts
- rk3566-powkiddy-rk2023.dtsi
- rk3566-powkiddy-x55.dts
- rk3566-radxa-cm3.dtsi
- rk3566-rock-3c.dts
- rk3566-roc-pc.dts
- rk3568-rock-3a.dts

[PATCH] arm64: dts: rockchip: Add dma-names to uart1 on Pine64 rk3566 devices

[Diederik de Haas]

Similar to bf6f26deb0e8 ("arm64: dts: rockchip: Add dma-names to uart1
on quartz64-b") also add the dma-names property to the other rk3566
devices from Pine64 with bluetooth functionality.

Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi  | 1 +
 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 1 +
 arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi  | 1 +
 3 files changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
index d899087bf0b5..ae2536c65a83 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
@@ -674,6 +674,7 @@ &tsadc {
 };
 
 &uart1 {
+	dma-names = "tx", "rx";
 	pinctrl-0 = <&uart1m0_ctsn>, <&uart1m0_rtsn>, <&uart1m0_xfer>;
 	pinctrl-names = "default";
 	uart-has-rtscts;
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
index 0b191d8462ad..37a1303d9a34 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
@@ -738,6 +738,7 @@ &uart0 {
 };
 
 &uart1 {
+	dma-names = "tx", "rx";
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
index dd4e9c1893c6..e42c474ef4ad 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
@@ -614,6 +614,7 @@ &tsadc {
 };
 
 &uart1 {
+	dma-names = "tx", "rx";
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>;
 	uart-has-rtscts;
-- 
2.45.2

Re: [PATCH] arm64: dts: rockchip: Add dma-names to uart1 on Pine64 rk3566 devices

[Heiko Stuebner]

On Fri, 5 Jul 2024 18:22:14 +0200, Diederik de Haas wrote:
> Similar to bf6f26deb0e8 ("arm64: dts: rockchip: Add dma-names to uart1
> on quartz64-b") also add the dma-names property to the other rk3566
> devices from Pine64 with bluetooth functionality.
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: Add dma-names to uart1 on Pine64 rk3566 devices
      commit: 3087576e1c706bcd3623b48478ea8c9b23173107

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: arm64: dts: rockchip: Add dma-names to uart-bluetooth rk3566 devices

[Chris Morgan]

On Fri, Jul 05, 2024 at 06:22:12PM +0200, Diederik de Haas wrote:
> This is a single patch which adds the dma-names property to the uart
> node with a bluetooth subnode on Pine64's rk356x devices.
> 
> But that property can potentially be added to several other devices, but
> I have zero familiarity with them or their community, so I choose not to
> add it to those devices, but inform people via this cover letter.

Thank you, but based on past experience the bluetooth failed to work
when I had the DMA names present (which is why I removed them on my
devices). I will however test it again to confirm that is still the
case or not.

> 
> The dts/dtsi files I found as potential candidates are:
> - rk3566-anbernic-rgxx3.dtsi
> - rk3566-box-demo.dts
> - rk3566-powkiddy-rk2023.dtsi
> - rk3566-powkiddy-x55.dts
> - rk3566-radxa-cm3.dtsi
> - rk3566-rock-3c.dts
> - rk3566-roc-pc.dts
> - rk3568-rock-3a.dts

Re: arm64: dts: rockchip: Add dma-names to uart-bluetooth rk3566 devices

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

On Monday, 8 July 2024 18:05:05 CEST Chris Morgan wrote:
> > This is a single patch which adds the dma-names property to the uart
> > node with a bluetooth subnode on Pine64's rk356x devices.
> > 
> > But that property can potentially be added to several other devices, but
> > I have zero familiarity with them or their community, so I choose not to
> > add it to those devices, but inform people via this cover letter.
> 
> Thank you, but based on past experience the bluetooth failed to work
> when I had the DMA names present (which is why I removed them on my
> devices). I will however test it again to confirm that is still the
> case or not.

That is very well possible as I had specifically you in mind when I chose to 
only apply it to Pine64 devices (as I could directly contact those people).
I had a vague recollection that there was 'something' with bluetooth on 
devices you added.

Thus it seemed better to inform people of the possibility, but let the actual 
implementation up to them.

Cheers,
  Diederik

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]