From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FD47C4345F for ; Wed, 24 Apr 2024 20:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=txWs9qAFDCTvyeB2Ur4PsfbfE9vabn8UG1LFc6PxHo4=; b=fgfwlesS+sIXYx AtuO1GdUdnqTAkhHuDA9nNDcM0Ql4tmoKwtlCUUjj2DaYpE6HorcpS+qsMyu9QckTgJ0EJBHrZhBf M7m7qZ+t3eJUriBKFE8fL0VVI5hIZqNSLCv8VPEacezLDg8XY7cUevSHNUhvbb+o1UPip76nO9Ubx oMw8q3BAlgFw3ljQapwHfME+Xwa1S0k92ZeiL9aU8ekcxMtVDrsNrgpMb6w0WddA8mpix+Ru2KdLe nOVEESbbsTu6R3HN1EBxsfur1WObgXYgfI1AxD+PRc8yDTqturohR7EhSZ11azXF700zacmkAZyLJ EoKkljG+mzACXqoWX1DA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzj2N-00000005s9M-0UHV; Wed, 24 Apr 2024 20:16:15 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzhrs-00000005XDo-3yL3 for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 19:01:23 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a559b919303so24693266b.1 for ; Wed, 24 Apr 2024 12:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713985279; x=1714590079; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sYb6lahma9ESsvjNNop/lnhNH+5GGNP092pV3MTMbcg=; b=B0XYQAZU2OaGqjjcy6NBVgB3YqYmRAreMWYBdyk+hdUdWr44uLXqwRcAe9kKtifAQd uyo6nmX5b+HcwjpV2fnuwRGpD3cggwP/CKpK3ywdNLRoirJOpEd7j2BIFgFvF2e0srGy 9Ju4nxy1DHk8P0IStCgtRjEATfju5EfLw2jg176R3vghDWCpJRi+eJD72BA41NgQ820N QT8hxFdvQNer14o+05SD+FizVdnrZr/MiiX1u6J70QluTmzoryIG+/w4OJJG0VAV5Tes evNT3QiM/G6cHtkuRi2G07vmRNRYJnxcNesyqVxIZKPdp3lni79NIKvHIZbRNsbsShcd D9WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713985279; x=1714590079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sYb6lahma9ESsvjNNop/lnhNH+5GGNP092pV3MTMbcg=; b=n3z9ZpzWp9R2fojluwgXUCa9rsueLo0dko1uCEoXW6PKuimddC7zNGN0NnTqWFy01J ssakKJcj/DHnbEhnH3R+Dg3FDpaCxFyaTGBkQlNLygkS+N5rn66wFccp3vuess9HFG2m 9ywjWwMSVj9qG/FAja1ZddHYKsPLjFHA5DVXH3oLy/lOdxpRlyt6NVba+7ONpdFieBHB orvJVOJKxMBrkyGev/gI6QO80BhNJTs2UdWCzo+VX+4SCQ9GWcoBcP8KlPqzltMALtBL sNh1mmsXeTsIBVRylkVscNaAHUAGWlBpGq4rRTuYAXaU5R6vhL2gkavRGnJ3wHtNYf0k jK6w== X-Forwarded-Encrypted: i=1; AJvYcCW4Xn/qxCVA4gI94ZLFWbyCECcPhnO8A4gni1f0MM85NnWfmVrBBC6haoeHqtPRvcKIVzavm8bF4pW3y0F0Hnla3zxuaZ+a1fB/oRtscW5tCxYW3NI= X-Gm-Message-State: AOJu0Yzf9m+1+c99+SSJnhhniqIzd/3zVhSB+Yy5j9ey10dByGUQWJHv XAvrgRntTC8Y12lhsIuJ5ZUsVfSjiYjQnjSGlZ+HhnSdWxTBoWJR X-Google-Smtp-Source: AGHT+IGU+Yholg1eeeqBHS1/XbClARTXKkmiXuj6aUAvmgHd37s0Jp93MObOLF9sK0NFXS2Ld+XqaA== X-Received: by 2002:a17:907:7241:b0:a58:a2f7:85e9 with SMTP id ds1-20020a170907724100b00a58a2f785e9mr1130309ejc.34.1713985278550; Wed, 24 Apr 2024 12:01:18 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id hg7-20020a170906f34700b00a4e5a6b57a2sm8624325ejb.163.2024.04.24.12.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 12:01:17 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Andre Przywara , Dan Carpenter Cc: Yangtao Li , "Rafael J. Wysocki" , Viresh Kumar , Chen-Yu Tsai , Samuel Holland , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] cpufreq: sun50i: fix error returns in dt_has_supported_hw() Date: Wed, 24 Apr 2024 21:01:16 +0200 Message-ID: <1882679.tdWV9SEqCh@jernej-laptop> In-Reply-To: <9bfe5703-b39b-4d98-9995-f6a7d0ea558d@moroto.mountain> References: <9bfe5703-b39b-4d98-9995-f6a7d0ea558d@moroto.mountain> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_120121_043668_8C7AB486 X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 24. april 2024 ob 13:40:11 GMT +2 je Dan Carpenter napisal(a): > The dt_has_supported_hw() function returns type bool. That means these > negative error codes are cast to true but the function should return > false instead. > > Fixes: fa5aec9561cf ("cpufreq: sun50i: Add support for opp_supported_hw") > Signed-off-by: Dan Carpenter Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c > index cd50cea16a87..0b882765cd66 100644 > --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c > +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c > @@ -136,11 +136,11 @@ static bool dt_has_supported_hw(void) > > cpu_dev = get_cpu_device(0); > if (!cpu_dev) > - return -ENODEV; > + return false; > > np = dev_pm_opp_of_get_opp_desc_node(cpu_dev); > if (!np) > - return -ENOENT; > + return false; > > for_each_child_of_node(np, opp) { > if (of_find_property(opp, "opp-supported-hw", NULL)) { > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel