From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DA15C43334 for ; Sun, 12 Jun 2022 15:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WO1UcdHV98ylawtpK03+Y7vXoqW/xL12fKelHJ7NnqY=; b=G+6Tn5vYUVveqB /I+w5TX+FCltAeIU2fcCJ0GX/bnPBL95m1MZxMyVzGcqrzZTPCrp7eSyI4eZk2Te1wVogy1WS88EO F/cNO1AuelHgPek2s2gbpKBHR/FnI3cTWeXzleyG4IuBcxBqFx+F1qC3ZL+ekQyc5rIzH0folOsb+ Xs06kSC2WdGOubfX7aF1sKcFi6bGBx0tFzHARIl6sVAtAz7jE/nNEwlRCGHYsgKZ0DP/F9tVJrMf2 qgKI45ssHyaOXbZBPcX1vVlblC/y0mt4PNn7Wu4Ajl5kjEJQLeQ8zZxn8gQad2c5WHioSkK6UcQ63 UFy2xfWCUj6ocineBl3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0P9i-00Graa-1R; Sun, 12 Jun 2022 15:05:34 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0P9d-00GrZS-FJ; Sun, 12 Jun 2022 15:05:31 +0000 Received: by mail-ej1-x630.google.com with SMTP id n10so6637062ejk.5; Sun, 12 Jun 2022 08:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=htFjsSXu7ZGxTjaP5i3din+9CWxv94Bctr84QoNiliY=; b=APsLw00dy2F55yoY3iXIMcnELsihcXP/p6SNiyRSf5oZEwPYW3D+p0hDD/fhfBGpLe 213n/Vi5KHjD4mMgEBXf2SHm9ZkNEaPVqBySbH1z3UhGpTHYFKFPNey4vj/pQ1X6HLEG CwJlDpgpTCvyl7Jilb5g9EBt7kK4A5jHct8fJEqfqx1dGEYyx4yqxwH5Hci+eZ5+6a1/ mwPrbmd2GM57MA2FANPMcQZRrQ+t0+ZzePfDQ0ZscrO4pnZjGmDSRDbNGdr3E+hjTEc+ vjADJaLYSq1uDbnUJWHDibDyKWaovFiZ9vlJy+aEvP/Vs+lyavPcbmcBUjdLyOjwTAEb xhFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=htFjsSXu7ZGxTjaP5i3din+9CWxv94Bctr84QoNiliY=; b=nF3a8KReHCdXR1i0Hph3rRigUxxfbfFZ7A8FMUW9Ajb7c7SjcXgqD/lYLE85JOc3JA RZyEuTDPNIOKQQR1bUgx4FBkdIX0VTlv8Kh0YRJ1jHd+THE1ek0m2uK+bRlWbVDzBEae Zjwy+ypbbQdYQST/mNatx3fKy2v0u28uJGrhgEXXIZQ27yOESMR6noSO+1Ra/21NPRcl 5lJgfLtSEU3JnG85eGFiBYb17/DSzCAVsolI2u6o7iiIWje7oRPyZFFoY4bIi9JGDvtK rhe1APs43Fxzv+iqbmnHqq6eAA9m3oQycvflPZJUvQhruXETPjq37Xshx60ihV+0Yc49 ltMQ== X-Gm-Message-State: AOAM533CHOY1ERhGhPEoUUEP73MG04tfb1xJx9sVKLJprekehZ9yfFkm YPkP/RH4sC55lnLTCru7vFQ= X-Google-Smtp-Source: ABdhPJyi9sxjMamNlGeaPrfv21rrYPCrriGAL73CCnuOlTCxSIfRQCJRmSiN3kIcksZEs7Yydc4tvg== X-Received: by 2002:a17:906:8301:b0:6e4:896d:59b1 with SMTP id j1-20020a170906830100b006e4896d59b1mr47420520ejx.396.1655046326879; Sun, 12 Jun 2022 08:05:26 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id gv17-20020a170906f11100b006febc1e9fc8sm2553325ejb.47.2022.06.12.08.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jun 2022 08:05:26 -0700 (PDT) From: Nicolas Frattaroli To: Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/3] media: dt-binding: media: Add rockchip-vepu binding Date: Sun, 12 Jun 2022 17:05:25 +0200 Message-ID: <1885873.U9Vi27CkfU@archbook> In-Reply-To: <440a7dc6-7ec4-d7a9-0c56-3b3dc15b79d0@linaro.org> References: <20220514133604.174905-1-frattaroli.nicolas@gmail.com> <20220514133604.174905-2-frattaroli.nicolas@gmail.com> <440a7dc6-7ec4-d7a9-0c56-3b3dc15b79d0@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220612_080529_582952_1522CE02 X-CRM114-Status: GOOD ( 29.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello On Samstag, 14. Mai 2022 22:41:29 CEST Krzysztof Kozlowski wrote: > On 14/05/2022 15:36, Nicolas Frattaroli wrote: > > The RK3568 and RK3566 have a Hantro VPU node solely dedicated to > > encoding. This patch adds a new binding to describe it, as it > > does not really fit the rockchip-vpu binding, since there is no > > decoder. > > > > Signed-off-by: Nicolas Frattaroli > > --- > > .../bindings/media/rockchip-vepu.yaml | 64 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/rockchip-vepu.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip-vepu.yaml > > new file mode 100644 > > index 000000000000..b7ba5bf3517a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/rockchip-vepu.yaml > > Filename: vendor,device (not hyphen) > It would be actually better if it followed the first compatible, so > "rockchip,rk3568-vepu.yaml" Thanks, will do. > > > @@ -0,0 +1,64 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > + > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/media/rockchip-vepu.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Hantro G1 VPU encoders implemented on Rockchip SoCs > > + > > +maintainers: > > + - Nicolas Frattaroli > > + > > +description: > > + Hantro G1 video encode-only accelerators present on Rockchip SoCs. > > + > > +properties: > > + compatible: > > + enum: > > + - rockchip,rk3568-vepu > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 2 > > + > > + clock-names: > > + items: > > + - const: aclk > > + - const: hclk > > Since these are new bindings, it would be good to follow DT convention > and not add common "clk" prefix to clocks. Just like DMA is "tx" not > "txdma". However clock names "a" and "h" are also not good and maybe > this is already shared implementation? This is indeed a shared implementation. Theoretically I could change the driver for this one case but that seems pointless, especially since "aclk" and "hclk" are the usual clk names for AXI and AHB on ARM as far as I understand. I think I've been told before that those two clocks should always be called aclk and hclk. > > > + > > + power-domains: > > + maxItems: 1 > > + > > + iommus: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > Indentation starts at "|" (so four spaces) > > > + #include > > + #include > > + > > + vepu: video-codec@fdee0000 { > > four spaces. > > > + compatible = "rockchip,rk3568-vepu"; > > + reg = <0x0 0xfdee0000 0x0 0x800>; > > + interrupts = ; > > + clocks = <&cru ACLK_JENC>, <&cru HCLK_JENC>; > > + clock-names = "aclk", "hclk"; > > + iommus = <&vepu_mmu>; > > + power-domains = <&power RK3568_PD_RGA>; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 9ce78f2275dc..f901a42e5d0f 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -8637,6 +8637,7 @@ L: linux-media@vger.kernel.org > > L: linux-rockchip@lists.infradead.org > > S: Maintained > > F: Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml > > +F: Documentation/devicetree/bindings/media/rockchip-vepu.yaml > > F: Documentation/devicetree/bindings/media/rockchip-vpu.yaml > > F: drivers/staging/media/hantro/ > > > > > Best regards, > Krzysztof > Thank you for your feedback, Nicolas Frattaroli _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel