From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: EXYNOS: cpuidle: Skip C1 cpuidle state for exynos5440
Date: Mon, 26 Aug 2013 16:23:03 +0200 [thread overview]
Message-ID: <18873465.YOJHgsXmcz@amdc1032> (raw)
In-Reply-To: <1377519363-23077-1-git-send-email-amit.daniel@samsung.com>
On Monday, August 26, 2013 05:46:03 PM Amit Daniel Kachhap wrote:
> This patch skips the deep C1(AFTR -Arm off top running) state for exynos5440
> soc as this soc does not support this state. The cpu's only allows the basic
> C0 state. The C1 state is filtered by re-initialising the driver state_count
> value to 1.
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Thanks for fixing this.
> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> ---
>
> Changes in V2:
> * Used driver state_count variable to filter the C1 state
> instead of device state count variable. Although this V2 patch is also
> not complete as there are suggestions to make this driver platform driver.
I'm going to look into making it a platform driver later this week.
> arch/arm/mach-exynos/cpuidle.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
> index 225ee84..ac13922 100644
> --- a/arch/arm/mach-exynos/cpuidle.c
> +++ b/arch/arm/mach-exynos/cpuidle.c
> @@ -200,6 +200,9 @@ static int __init exynos4_init_cpuidle(void)
> if (soc_is_exynos5250())
> exynos5_core_down_clk();
>
> + if (soc_is_exynos5440())
> + exynos4_idle_driver.state_count = 1;
> +
> ret = cpuidle_register_driver(&exynos4_idle_driver);
> if (ret) {
> printk(KERN_ERR "CPUidle failed to register driver\n");
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2013-08-26 14:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 0:14 [GIT PULL 3/3] 2nd Round Samsung mach-exynos for v3.12 Kukjin Kim
2013-08-26 10:06 ` Bartlomiej Zolnierkiewicz
2013-08-26 11:03 ` amit daniel kachhap
2013-08-26 11:19 ` Bartlomiej Zolnierkiewicz
2013-08-26 11:52 ` Kukjin Kim
2013-08-26 13:51 ` Bartlomiej Zolnierkiewicz
2013-08-26 12:16 ` [PATCH V2] ARM: EXYNOS: cpuidle: Skip C1 cpuidle state for exynos5440 Amit Daniel Kachhap
2013-08-26 14:23 ` Bartlomiej Zolnierkiewicz [this message]
2013-08-26 12:18 ` [GIT PULL 3/3] 2nd Round Samsung mach-exynos for v3.12 amit daniel kachhap
2013-08-27 4:08 ` Kevin Hilman
2013-08-27 15:57 ` Kukjin Kim
2013-08-27 18:57 ` Olof Johansson
2013-08-27 23:33 ` Kukjin Kim
2013-08-27 23:34 ` [GIT PULL V2 3/3] 2nd Round Samsung mach-exynos-v2 " Kukjin Kim
2013-08-29 20:29 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18873465.YOJHgsXmcz@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox