From: <Claudiu.Beznea@microchip.com>
To: <ye.xingchen@zte.com.cn>, <sre@kernel.org>
Cc: linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] power: reset: at91-poweroff: Use devm_platform_get_and_ioremap_resource()
Date: Thu, 16 Feb 2023 10:01:29 +0000 [thread overview]
Message-ID: <188f341c-cc4e-16ae-d551-184bb48f09da@microchip.com> (raw)
In-Reply-To: <202302151449285733136@zte.com.cn>
On 15.02.2023 08:49, ye.xingchen@zte.com.cn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/power/reset/at91-poweroff.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
> index 9e74e131c675..b7e17afe30e2 100644
> --- a/drivers/power/reset/at91-poweroff.c
> +++ b/drivers/power/reset/at91-poweroff.c
> @@ -151,13 +151,11 @@ static void at91_poweroff_dt_set_wakeup_mode(struct platform_device *pdev)
>
> static int __init at91_poweroff_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> struct device_node *np;
> u32 ddr_type;
> int ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - at91_shdwc.shdwc_base = devm_ioremap_resource(&pdev->dev, res);
> + at91_shdwc.shdwc_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(at91_shdwc.shdwc_base))
> return PTR_ERR(at91_shdwc.shdwc_base);
>
> --
> 2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-02-16 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 6:49 [PATCH] power: reset: at91-poweroff: Use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-02-16 10:01 ` Claudiu.Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=188f341c-cc4e-16ae-d551-184bb48f09da@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).