From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF7E5EE7FF4 for ; Mon, 11 Sep 2023 16:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SRC+DCGF7mvTPdcy4DrSC8U5q31+Ihy45DO8ZK8nV9A=; b=mDO0lbz0Im9ObI 4o+bFedbMZPAKq2i7kN/DE+V+SwBgB1GDnRA5cYBZxAI0oGgmjlVgzPT0V1gKGh0++jcBbV+wCgT2 eT63mlaH1axAghON/dPQdSmFWrxaMweouelH7qCRsXmOogKWi4E+HH6WOTlnx8M56F87MCiC4inyE /p3VoYfLv+2pI43xUjJs/En46xTsyBYEbgSDyP5v8vthSLcF4oXp8AptamUI7X/XliJ8w77Gkz+un 6Ca4i6l0tYeDDsgEBKyZpNM7bzJgoKUp5hMaI/Q4tNpcz8pwkc/0GLSFW+HKPzAyylD210UyWOM2b Idhl9tbnerSoJmzX0JYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qfjMO-000xva-2O; Mon, 11 Sep 2023 16:02:00 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qfjMM-000xuV-0d for linux-arm-kernel@lists.infradead.org; Mon, 11 Sep 2023 16:01:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1694448118; x=1725984118; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lKHyicF0p9BaS5ys6PVn7lp6R/aWgLwg26A6LMOSZlE=; b=Ce/PP8hiqnvgT58pZtPzBLv6x/xGbJv7BR9TMLIR33AjkMZlfA93D35y n39G11oDNyB9pJI9drGY8FztGbiJPHYdxSvMloegK27xpTHqW0kJQzyMT zb0tCfz0WQPYNkeaqCO9B66ePxBYPsGd/DvpI9CNShoW+1rAf1xiaoCJV yjWSf2YUIaNeldFZNTHwFn/iRWjJrcmPmrTv2EELWT2p7S+NfR8y7Dz8Z V69ka7g/i7tAlkgKKkWf6/mkoHicO9sueYmWVbbKBc19UaZlaTcjQYjpm ynNl0dA9gAAX6ksz3eBe82ctQtPsSIUUo0MwgStjHNmSaSaXJOxrGU3hZ A==; X-CSE-ConnectionGUID: +foy2RZLSUOIYXipKZdYxg== X-CSE-MsgGUID: ZKrN9PlRR+q/ZjuwzBu+Kw== X-ThreatScanner-Verdict: Negative X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="4164260" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Sep 2023 09:01:56 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 11 Sep 2023 09:01:55 -0700 Received: from [10.159.245.205] (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 11 Sep 2023 09:01:53 -0700 Message-ID: <18943157-a1fb-0fda-e3d4-e0478d18a849@microchip.com> Date: Mon, 11 Sep 2023 18:01:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/2] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board Content-Language: en-US, fr-FR To: claudiu beznea , , , , , , , , , , , CC: References: <20230801111151.6546-1-mihai.sain@microchip.com> <20230801111151.6546-2-mihai.sain@microchip.com> <14d628cf-a40c-11e6-7743-e3ba3bd8aa2d@tuxon.dev> <9ce18601-02d8-686e-ebe0-04c5dc29f6c9@tuxon.dev> From: Nicolas Ferre Organization: microchip In-Reply-To: <9ce18601-02d8-686e-ebe0-04c5dc29f6c9@tuxon.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230911_090158_235493_A4E39587 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mihai, Claudiu, First of all, thanks a lot for your help on this board DT, that's great! On 03/08/2023 at 11:09, claudiu beznea wrote: > Hi, Mihai, > > On 02.08.2023 15:19,Mihai.Sain@microchip.com wrote: >>> +&macb0 { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + phy-mode = "rmii"; >>> + status = "disabled"; >> Should any phy/mdio container be placed here? Also, any reason this node is disabled? >> The board has no phy. >> We will add external phy boards to macb interface and they will be present in dt-overlay. >> > Then remove the macb0 node from here and keep it in overlay. What about choosing a phy and making it enabled by default. Because I doubt people will use this board without a phy under Linux, honestly. Overlays would remove this "by default" node and add the replacing phy if hardware plugged-in is different. By doing this we avoid having difficult situations where the most used phy with this board is disabled or non existant and that we absolutely need an overlay for such a basic thing as having Ethernet working out-of-the-box... Just my $0.02, but it might simplify our life in the long run... Best regards, Nicolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel