From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F8E1C77B7A for ; Wed, 24 May 2023 14:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UcUhoq3RgdAqvK/ZnwO27D5BTG35v+cwTitoni8vWtg=; b=ktJKwSlR5s8vnY FmMvBlNglCP8pa4TvlNpCXl2oIcQkuXyyRbOPDq7uFi4nTzGX120rUwIY3d0zL4Zn2AB3rQe9XZ7i 0i24cBViQxD7Q/8jNr6WRPutvMZtfG+szY8/dAe5EQAx/qlEmS8TAtgG12TkX0LXrp497P+Otupj1 fV81n3YESzzMbaCaMxTnGGz8LV5GKVkm86n8zMShcJyU18avLjwy1nLx4Ui1zjhULruDkRhesHhb5 81hymLwZKgEHAfDyb591RkWnV2dPb9oZYakgD0mEMh04yH5iomLtbqgxULFL6Jo/ic+q6G5ZJZEPu XIpmvSLG/q2bwm3ZNRaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1p3V-00DdXr-2s; Wed, 24 May 2023 14:01:33 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1p3T-00DdXB-0m for linux-arm-kernel@lists.infradead.org; Wed, 24 May 2023 14:01:32 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34OCxk8w017501; Wed, 24 May 2023 16:01:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=RAAm+AX0qyb+kRbhxWkN1xkrpeGaJzZQEwR5kRwe2Nw=; b=kMTpYOYiRB6jJbKtryLg7tWY8/FSoXts15ruhQzQ0ufCRJeoEitDNiPAhTePtqwL5Ou+ 2zlvdcpRXH8UkEcUMXwnvNAsbYsLfPJGTn+WQCUdM6KND3lZOw04C+Bsqvbv4Ziu3nEk uFAVgopKzQi09gNs+Or3Jf4yC0Q9Ym/TwemN6scyjw1NbZsRyON2iRKVEyHf063O0ghs Qo8s3Tj+/hTnXE5OLREvjYEPXBrf+FQDAV9EPtVebl5b8io7yIkyj9MgW360zTH0JNyj j581Udh60uj3NOsIzQtn4JQIjhfxdS4iCDQgr29PWbmXtMyE+vvutrRnFfOXE5NMXPuW 7g== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3qrspnsf9s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 May 2023 16:01:19 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2416910002A; Wed, 24 May 2023 16:01:18 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id EC59822A6EF; Wed, 24 May 2023 16:01:18 +0200 (CEST) Received: from [10.201.21.9] (10.201.21.9) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 24 May 2023 16:01:15 +0200 Message-ID: <18a8528d-7d9d-6ed0-0045-5ee47dd39fb2@foss.st.com> Date: Wed, 24 May 2023 16:01:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH 1/4] tee: Re-enable vmalloc page support for shared memory Content-Language: en-US To: Christoph Hellwig CC: Bjorn Andersson , Mathieu Poirier , Jens Wiklander , , , , , References: <20230523091350.292221-1-arnaud.pouliquen@foss.st.com> <20230523091350.292221-2-arnaud.pouliquen@foss.st.com> From: Arnaud POULIQUEN Organization: STMicroelectronics In-Reply-To: X-Originating-IP: [10.201.21.9] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-24_09,2023-05-24_01,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230524_070131_569544_9B26F515 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Christoph, On 5/24/23 08:46, Christoph Hellwig wrote: > On Tue, May 23, 2023 at 11:13:47AM +0200, Arnaud Pouliquen wrote: >> This patch revert commit c83900393aa1 ("tee: Remove vmalloc page support") > > As per the discussion back then: don't just blindly do the same dumb > thing again and fix the interfae to actually pass in a page array, > or iov_iter or an actually useful container that fits. > I suppose your are speaking about this discussion: https://lore.kernel.org/all/20221002002326.946620-3-ira.weiny@intel.com/ If I'm not mistaken, I should modify at tee_shm_register_kernel_buf API and register_shm_helper inernal function, right? Seems that Jens has also pointed out the free part... What about having equivalent of shm_get_kernel_pages in an external helper (to defined where to put it), could it be an alternative of the upadate of the tee_shm API? Thanks, Arnaud _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel