From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4A05C77B7A for ; Wed, 17 May 2023 02:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aVnANcmHzZQQz5v8kBc1buenThQpEdsVX/0ZzwL+G34=; b=S7Vm7LKELSsGGL /sLc63cNay5JX+nQQM2EQCsFG0Xqg/K7wP0+yuYb4H3lvyNocHW71U42+wFj3B+1S9/0mMl0b4Vmx qFQtF3+2DqTQhUD7SMhqMbQ5/vCo/YeN/hwy7M25SUBuouIFrdz+jZprdAU/QOI1RBiItHW5HLXI9 vMsEe9lFP5L91/45a4N7xVgG1pn2Ct/xzSt0BjgyiXN5Zf6HdKthgW9sTcC+sS8+JcUNzbROljlh2 y/J7s0JYINePpMIiLlXUiOMDVcQoQ1sKHyJH7u+7bHC5nu2njMw9HIUXDCEO+MKrv/uayq4m7Bxyh FBG+Rf6AyJldbYILtWCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pz70s-007rqc-29; Wed, 17 May 2023 02:35:38 +0000 Received: from out30-100.freemail.mail.aliyun.com ([115.124.30.100]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pz70o-007rpe-2G for linux-arm-kernel@lists.infradead.org; Wed, 17 May 2023 02:35:36 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R471e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0Viqoj7k_1684290929; Received: from 30.240.113.228(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0Viqoj7k_1684290929) by smtp.aliyun-inc.com; Wed, 17 May 2023 10:35:30 +0800 Message-ID: <18b27158-a8fb-e1d9-f85e-f12620b69bfb@linux.alibaba.com> Date: Wed, 17 May 2023 10:35:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 3/4] drivers/perf: add DesignWare PCIe PMU driver Content-Language: en-US To: Bjorn Helgaas Cc: yangyicong@huawei.com, will@kernel.org, Jonathan.Cameron@huawei.com, baolin.wang@linux.alibaba.com, robin.murphy@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, rdunlap@infradead.org, mark.rutland@arm.com, zhuo.song@linux.alibaba.com References: From: Shuai Xue In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_193534_906025_C3AC309F X-CRM114-Status: UNSURE ( 8.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023/5/17 03:19, Bjorn Helgaas wrote: > On Tue, May 16, 2023 at 09:01:09PM +0800, Shuai Xue wrote: >> ... > >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > Typically in alpha order. Got it, I will reorder them. > >> +#define DWC_PCIE_VSEC_RAS_DES_ID 0x02 >> + >> +#define DWC_PCIE_EVENT_CNT_CTL 0x8 > > Add a blank line here. Sure, will add it. > >> +/* >> + * Event Counter Data Select includes two parts: > >> +#define DWC_PCIE_EVENT_CNT_DATA 0xC >> +#define DWC_PCIE_DURATION_4US 0xff > ... > Pick upper-case hex or lower-case hex and use consistently. Will pick upper-case hex for all macros. > >> +#define DWC_PCIE_LANE_EVENT_MAX_PERIOD (GENMASK_ULL(31, 0)) >> +#define DWC_PCIE_TIME_BASED_EVENT_MAX_PERIOD (GENMASK_ULL(63, 0)) > > Unnecessary outer "()". Ok, will remove it. > >> +struct dwc_pcie_pmu { >> + struct pci_dev *pdev; /* Root Port device */ >> + u32 ras_des; /* RAS DES capability offset */ > > u16 is enough to address all of config space. Go it. will fix in next version. Thank you :) Best Regards, Shuai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel