From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3917FC83F33 for ; Tue, 5 Sep 2023 09:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aH8QOtJbT7gPYeyugA+mlA9ow1/GNwJQCp1gERzVsT0=; b=wJxvYeeo16dEKg +rst+W/1askAplTJctm7gW0FZ4PWLP84medJj5xivTYsF17NzyoZmOuHsAc1Ne5Kz7UIFpvsR7KjF 6KzHVH5TIHtDWXiiaWES5P2zpxFy60eux/w5nB1eMDpuwysn2S5MTkjiCk3Z/azqvBCrAAZdEaw2b D3JffOPLemYXL5UNxFNy55xQPSgM1RYPqoW6G8TfK1xXkNobHjSZPPKhBb3qnnnNaGfOHd0qBMRTr eezFd+Uvu3hEj5g9dTH1AobMG6vYxpc2rdb91LE6DyEUtJ0jafOkouFbiFsrTZp4uHytBDJ9CgUXz CU8r3+8d62MigljtKweg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdSob-005eoc-0V; Tue, 05 Sep 2023 09:57:45 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdSoX-005enI-1m for linux-arm-kernel@lists.infradead.org; Tue, 05 Sep 2023 09:57:43 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-68c0d4cc3a4so1395415b3a.1 for ; Tue, 05 Sep 2023 02:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693907859; x=1694512659; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9MXWXFgX5aFPhZ6qllDXEBQgIeC6Jxy5NEVmVqVP4Hs=; b=SdiBgLPknBWT7Zh3sJj6Itw5ApPd5xkASIqB3aDbswrwLFd31STL6yks/VfMuRul7V P0Hx9Nk0eXALonSantKfDS4FHdm/rqNJRo+Jgn/Y6AANxP++UWtf4Lc17d9jIFdJapvy VX85k2N09HZlL2GNhHH6WcIQA55CWyD6tn6cr4YJnUJwIA0XFzcWzveWj/fp4zNFY4b2 lLZyCzr3kv7D1nppquWYVqOIzie9WyLn7/4GXZ6y4Bg+3r89dHeJ+oStgZXdlm8MODoY OtIJtqEs+jyUFxxGPehBVTVWQ9ZJ/3m9iV3VHLyzzV8BXg8R95w9283mXCP7q6xc55ov ksPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693907859; x=1694512659; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9MXWXFgX5aFPhZ6qllDXEBQgIeC6Jxy5NEVmVqVP4Hs=; b=k61zr0g188j22TUhE81N7fPlZ9W2mgafYgLsdETYxa7AICx2lVHttMID6d771MRnzh cXGwplAEfAlu5LCyX0XYyz66wiPxJAXBOs4E2KYWie9OpfFAxP6Fvi2dG/UefrbxGqvH BbTWKmVGjhRUGP7RY6wxxc66mVQmdTgYAT3Ogpss8AIssrw1Ckc79x6wSK5XPN8xpdgf x3vSCddfBt+JpBQtLNfXnKhTYii9Hw4afPlfvahay9cqb93uA9ncI+6LrY3FzyOL+4Hx 5DU7Opfgfj3DccmiyfoOTAKyADbbKkdigh10TMOgV+kmphwYHDQvJbCfMwH2dfodggyL 8byg== X-Gm-Message-State: AOJu0YwNYg6ZrsfCrfApBJEFnXXoRcB+yTOvR6DeF9+SCVZoHo72ZBZu IcRHiEc0pvd+JZWZN2FRCDU= X-Google-Smtp-Source: AGHT+IG9oGAsnYDLZhL+LakWC4U811CoL+trnqHsY45OMKtbt/MUxwWcgiOmJozHaNgB60WIAUpsRQ== X-Received: by 2002:a05:6a20:748d:b0:13b:9e04:5466 with SMTP id p13-20020a056a20748d00b0013b9e045466mr12415184pzd.49.1693907859389; Tue, 05 Sep 2023 02:57:39 -0700 (PDT) Received: from [10.10.14.80] (1-34-21-66.hinet-ip.hinet.net. [1.34.21.66]) by smtp.gmail.com with ESMTPSA id x26-20020aa784da000000b0064d57ecaa1dsm8710981pfn.28.2023.09.05.02.57.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 02:57:39 -0700 (PDT) Message-ID: <18b78489-6a12-a09f-620d-985be747f9da@gmail.com> Date: Tue, 5 Sep 2023 17:55:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC Content-Language: en-US To: Krzysztof Kozlowski , patrick@stwcx.xyz, Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Arnd Bergmann , Olof Johansson , soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: cosmo.chou@quantatw.com, potin.lai@quantatw.com, daniel-hsu@quantatw.com References: <20230830090212.3880559-1-peteryin.openbmc@gmail.com> <20230830090212.3880559-2-peteryin.openbmc@gmail.com> From: PeterYin In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_025741_586841_0312FFB1 X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/30/23 17:44, Krzysztof Kozlowski wrote: > On 30/08/2023 11:02, peteryin wrote: >> Add linux device tree entry related to >> Minerva specific devices connected to BMC SoC. >> >> Signed-off-by: peteryin > To clarify: your full name or known identity is "peteryin"? > >> --- >> arch/arm/boot/dts/Makefile | 1 + >> .../boot/dts/aspeed-bmc-facebook-minerva.dts | 385 ++++++++++++++++++ >> 2 files changed, 386 insertions(+) >> create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 9e1d7bf3cff6..edb0b2105333 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >> aspeed-bmc-facebook-wedge400.dtb \ >> aspeed-bmc-facebook-yamp.dtb \ >> aspeed-bmc-facebook-yosemitev2.dtb \ >> + aspeed-bmc-facebook-minerva.dtb \ > Nothing improved here. > >> aspeed-bmc-ibm-bonnell.dtb \ >> aspeed-bmc-ibm-everest.dtb \ >> aspeed-bmc-ibm-rainier.dtb \ > >> + "","","","","","","","", >> + /*O0-O3 line 224-231*/ >> + "","","","","","","","", >> + /*O4-O7 line 232-239*/ >> + "","","","","","","","", >> + /*P0-P3 line 240-247*/ >> + "","","","","","","","", >> + /*P4-P7 line 248-255*/ >> + "","","","","","","",""; >> +}; >> + > Nor here. > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > Could you please clarify for me? Are you asking if the last line should not have a blank line, or I can't set a comment for the sgpio line like this: /*P4-P7 line 248-255*/ > Thank you. > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel