From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E26C5C433EF for ; Wed, 8 Jun 2022 09:35:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tiwImk0mnd6hF67s0UR0Dc8leK4LNWr8op/FjZepi9c=; b=N1dZ0MT3Qjsfbf hixOHK14WhmILlM6odrUoWRCDDfnTFCfCFiYG3m4XuPWPkNUx5PXQVR45utHwVjVHMhAfxxCojsOs vUBlO19WoR2eQOfcyrWPu9o+yLzFS3vuLdGz3xUBEC9OKaoidnixzO+4h0eZKU8oNNHpM51IjzSdy do81QpQryF6zAxPHsCqTdicr4JI9pb9PwupwEo7rlUR6fdtX8FV3ywvKN+oD4lc8u7MR4tXAU9YbF RfVQbTjyDFMK4YN5IxrOxIpMlNYnc8rrYvmb8jys91oTX+aJ60sSsWdDScHGJ0kF7WO/jqR6KX9E+ g23M9CDyGTKxraN7pInw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nys4z-00CPDJ-CK; Wed, 08 Jun 2022 09:34:22 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nys4a-00CP3E-K4 for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 09:33:58 +0000 Received: by mail-ej1-x62b.google.com with SMTP id v1so29592532ejg.13 for ; Wed, 08 Jun 2022 02:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZfZbcQl+BD4m4GvvgoxEYulyWPQbslWZIUb/bydU51Y=; b=Fm2x5X7BWWrduLHXcvbjhZrXy3KT7WDDSrSNCzf7n3Uj8PAW2CsRUoOw6y2Tw+lj/3 uGUXzn63669Q9xVBTvL2u59BOUTe+mt1kA8wdpWOXMZow86b2j/UFatLEJf8cUSxh0y/ vCGZhNkY/Yw6tpWYrMZ8k29sWvG2Na9CgZtBKKPtSVoBH4Jn3sRTJ2y+CLmQyCIKymK/ vB4G8J64FeyYzcS57JSdahDNhhqEB0O1NRT8F0mHn8bhr8HGLzGO5mUye1HxgXEOyxuV 0plkpOf2y1gGSHULbJNtHjKibZsPwkKkwPA41tC0FYMtIR6DHLo9UTQs/Lk1KYqe9Rnm 11fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZfZbcQl+BD4m4GvvgoxEYulyWPQbslWZIUb/bydU51Y=; b=ZUUKb8DFmgj0QjPF7sDT3EJKtRYJ8bxayYsBJW1JltTxtfPeIiE7WfPp/vLd8ZpGDD sfCoWjoglTHNsUj8w2IqC/jcd7bLOFMdnFmUp5nzjwiZ9GHgvatmrbH9GKqO9qXyQRuW vA37c4OctIYoSomj7tPIMh5hcXuD8WGbx801rqEKuPQ18mfX1bagTFKqJoxZ0oyYG5Ug 2OkjmNfkRwliZxTkWBPWsDf9xR9Bz1WF8YwSZVEzf2TMsfqySv78KZ2VWkCCZNvNlM1y cVqDQks+W8Oho2zRQqK7dQsJTkhO+xjAdGHBxsm+qDV+EHX1g6QL/nwDTgvFUXWJh+ai QAOw== X-Gm-Message-State: AOAM533vGb1s4MFbKI95y1ofGCsmlczTmNeIVUapx5aBRJlAwt8YQrSn UIH9KAqIEoSKaQO3Rmcf2aUf+z1D8+X+Ew== X-Google-Smtp-Source: ABdhPJzEtXPNk7J7EASb6iGEsm561kmYPbwceqTmY03OzGejejqTqbheB8ZkBL2ZhO/YZGCCKKm/vA== X-Received: by 2002:a17:907:3e11:b0:6fe:cce4:57e5 with SMTP id hp17-20020a1709073e1100b006fecce457e5mr29429490ejc.640.1654680834512; Wed, 08 Jun 2022 02:33:54 -0700 (PDT) Received: from [192.168.0.191] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id o13-20020a17090608cd00b006fedcb78854sm8883545eje.164.2022.06.08.02.33.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 02:33:53 -0700 (PDT) Message-ID: <18c84400-2fb1-e802-d43a-766c7dcb80aa@linaro.org> Date: Wed, 8 Jun 2022 11:33:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema Content-Language: en-US To: Kavyasree.Kotagiri@microchip.com, krzysztof.kozlowski+dt@linaro.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com References: <20220607144740.14937-1-kavyasree.kotagiri@microchip.com> <20220607144740.14937-2-kavyasree.kotagiri@microchip.com> <1345050e-b6a4-64be-1359-8d31d88769ab@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_023356_723952_4278EDCF X-CRM114-Status: GOOD ( 16.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/06/2022 11:31, Kavyasree.Kotagiri@microchip.com wrote: >>> Convert the Atmel flexcom device tree bindings to json schema. >>> >>> Signed-off-by: Kavyasree Kotagiri >>> --- >>> v1 -> v2: >>> - Fix title. >>> >>> .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ >>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ >>> 2 files changed, 97 insertions(+), 63 deletions(-) >>> create mode 100644 >> Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- >> flexcom.txt >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >> b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>> new file mode 100644 >>> index 000000000000..05cb6ebb4b2a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>> @@ -0,0 +1,97 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Atmel Flexcom (Flexible Serial Communication Unit) >>> + >>> +maintainers: >>> + - Kavyasree Kotagiri >>> + >>> +description: >>> + The Atmel Flexcom is just a wrapper which embeds a SPI controller, >>> + an I2C controller and an USART. Only one function can be used at a >>> + time and is chosen at boot time according to the device tree. >>> + >>> +properties: >>> + compatible: >>> + const: atmel,sama5d2-flexcom >> >> Same comment applies as before... Your previous set was better here and >> for some reason you decided to change it. This should be enum so you >> avoid useless change next patch. >> > Thanks for your comments. > Do you mean use "enum" instead of "const" in current patch itself and add new compatible in 2/3 patch? Yes. This is how you did it in previous patchsets. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel