From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98619C32751 for ; Wed, 7 Aug 2019 10:55:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 690AF21E6E for ; Wed, 7 Aug 2019 10:55:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DEovhhVu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="Bf5pxvIG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 690AF21E6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qO7dTdEIq3roNNRRDXNvxuv/1mtYMOyLzSpRaqk9tHg=; b=DEovhhVuCI8Q0Z PLtT0dwgFjfLBpdqJA+BrkEomSy5uyPajcjYfYYnpdENYfZX2OjoTHVUqSut4gnTDrE26kz0hBtVo iX13BsayipaPZe6I3EDGpB39ayltejz+XM9+XMYubPMvYOC5r9t8gs8UfcLCSG7U+gavzsCg+TJQf qqFp3J22ONHs1lhxd+J1AWFEqWyvz+J15HO2jUhPDTh2gI+oI0L5OZkk10gQX0fb5lTz17fTc+6hX 6Co4sB9HLPhscfdw4cpIgG3wI8FfcQYb8uy0nUMMIY5dr1ockZanihL3eKNXVg90m36+KkEWZiNAE unKYGV2jq5vtI/KIUuWg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvJaz-0005dM-Sv; Wed, 07 Aug 2019 10:55:05 +0000 Received: from mail-eopbgr730040.outbound.protection.outlook.com ([40.107.73.40] helo=NAM05-DM3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvJax-000533-61 for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2019 10:55:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ENoD+yMehG25v9QSulmK8b8tpTrUBSAiH614CHYlEKR0yhv3Bd6oC1eYQS0f7YRUC4XhHKwuhG2enZUgV+hrKqg4mcRU1SRzHrPaEHFFu55I91Jg+QY79rH7Y3XS6vEnxLT/yFmnlRExzwx2qFXaooO56O0yHiwdZsAs0sPY9zX/n3qjKyX4aw2KAL5ZFQTSKPDq/0yaxvEkrgsW3E0TaID3t7AlQm4vNXDk0+YyU+2QQpnwUA8MBBXWrGusPviCCp8skrsbdDZ+vNrmH/7o3gUiO4DtsYECGyXSpYAJefYHPnj/iJrkLvgcKrdrnF1A23uxXQG5As8De2i7UVp4NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3EORylzvgMSTu1Kizarvs2NiqOnNmzDynNiBGI83gx4=; b=M9l9Xjj8yZjmgCFIBMb6XbMURXuJce5Hdy1AmpZu96Q7HTryRG0pfHH4uG6tcRxF+8UlKRKcARlLkaX+qCxEmGAA8J1sh96HlTiCt4HicrTXlj3TSBF8/Gz0iL5BxWaKuAdZkvslGnkHdfFLd+GbrTeYN7ju63Al8h9jDPftRMh8OiYXxBgRjxIUkiFREWUpHKhRkms17R099XGLCXu2hJN7JS2o4t4YRljVClXNhMm54UmE8q24+cZjffw9YqUhYUMA/YTbRvQrZTmUcOuGRAoklOvrXM2VY4SFsSu6mTuSDclcnGdeWbUqJR95Li7T6I0yAMw/lC03A561d6uNcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=amd.com;dmarc=pass action=none header.from=amd.com;dkim=pass header.d=amd.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3EORylzvgMSTu1Kizarvs2NiqOnNmzDynNiBGI83gx4=; b=Bf5pxvIGN1eaNia/hiOgDkcN7I5JGNxuW8dLWezw0m82zP0fXf2bENXS1iEVphdAfnsJKzYodFHEw8PRwxmD94AN2JUxI9ssdS80RHS9pifpVjXfLunJ/kwDgh4BTm0imWD9WwLqgn2iUXhIxmOEjALAUg0eTzXasoS+stsJJnY= Received: from DM5PR12MB1546.namprd12.prod.outlook.com (10.172.36.23) by DM5PR12MB1659.namprd12.prod.outlook.com (10.172.40.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Wed, 7 Aug 2019 10:55:01 +0000 Received: from DM5PR12MB1546.namprd12.prod.outlook.com ([fe80::fc5f:ce01:e8c8:db89]) by DM5PR12MB1546.namprd12.prod.outlook.com ([fe80::fc5f:ce01:e8c8:db89%12]) with mapi id 15.20.2136.018; Wed, 7 Aug 2019 10:55:01 +0000 From: "Koenig, Christian" To: Christoph Hellwig Subject: Re: [PATCH] drm/amdgpu: replace readq/writeq with atomic64 operations Thread-Topic: [PATCH] drm/amdgpu: replace readq/writeq with atomic64 operations Thread-Index: AQHVTMvE140hqrZvSkOTllezqlrDj6bvREIAgAAdQoCAAB4dAIAAA9yA Date: Wed, 7 Aug 2019 10:55:01 +0000 Message-ID: <18cd9fa5-2d87-2f41-b5fa-927b9790287d@amd.com> References: <20190807025640.682-1-tao.zhou1@amd.com> <20190807070834.GA24792@infradead.org> <20190807104104.GA18773@infradead.org> In-Reply-To: <20190807104104.GA18773@infradead.org> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 x-originating-ip: [2a02:908:1252:fb60:be8a:bd56:1f94:86e7] x-clientproxiedby: PR0P264CA0001.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::13) To DM5PR12MB1546.namprd12.prod.outlook.com (2603:10b6:4:8::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10d059da-019e-4f50-36a8-08d71b25b1e9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DM5PR12MB1659; x-ms-traffictypediagnostic: DM5PR12MB1659: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 01221E3973 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(4636009)(136003)(396003)(346002)(376002)(39860400002)(366004)(199004)(189003)(7736002)(6246003)(6506007)(86362001)(64126003)(478600001)(53936002)(102836004)(2906002)(71200400001)(25786009)(4326008)(8676002)(81156014)(256004)(8936002)(386003)(5660300002)(81166006)(14454004)(71190400001)(31686004)(68736007)(36756003)(31696002)(305945005)(6916009)(66446008)(66946007)(66556008)(65826007)(66476007)(186003)(6116002)(76176011)(99286004)(58126008)(316002)(54906003)(6436002)(6486002)(486006)(6512007)(11346002)(446003)(46003)(65806001)(65956001)(476003)(2616005)(52116002)(229853002)(64756008)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1659; H:DM5PR12MB1546.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: GbgniQUfV0L1SWGCBySXlpjv2glLL7wDaOSGuoqM1Z7ah8WaNbKjVvp3mWoRIkSE1O+NgKCEAVw1bDs7N3sMUWCte4qNqIizT8Kx/UrDlNjuj8/T2Jc23LDcXueXyGfrd3lvYTFYAljVqCIlEOYaDQEAJhwuU5vxR8ixFpI7Oa1ajx82qgQtZJ3cPq46UY86XKRLyfQiuwlegrNab4wb7FkQyFS1XJ041fD22E1AS1nYqP6rqWwqBP+c5vqrqz/PegVWXpzdfo852PumIpzWNaw1tAJl03qlQO+Edoq7LKiRDK1RjDgv1A9OI1IcXYtt95JfoM7doOysWqgafKbhfiB+c/qSDQktNf1S8ezmeF1gMQqPFhRHPelm58DirA6a/1M/RcQvp1K5DRMg/FLmdHwnrBsFjTArHlQVa6sCp3w= Content-ID: <38B2E3E82706954B8BB64564CFF144C3@namprd12.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10d059da-019e-4f50-36a8-08d71b25b1e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2019 10:55:01.2423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ckoenig@amd.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1659 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_035503_297497_00512C45 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arm-kernel@lists.infradead.org" , "kernel-build-reports@lists.linaro.org" , "Zhou1, Tao" , "amd-gfx@lists.freedesktop.org" , "broonie@kernel.org" , "linux-next@vger.kernel.org" , "Deucher, Alexander" , "akpm@linux-foundation.org" , "Li, Dennis" , "Zhang, Hawking" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 07.08.19 um 12:41 schrieb Christoph Hellwig: > On Wed, Aug 07, 2019 at 08:53:25AM +0000, Koenig, Christian wrote: >> Am 07.08.19 um 09:08 schrieb Christoph Hellwig: >>> On Wed, Aug 07, 2019 at 10:56:40AM +0800, Tao Zhou wrote: >>>> readq/writeq are not supported on all architectures >>> NAK. You must not use atomic_* on __iomem (MMIO) memory. >> Well then what's the right thing to do here? >> >> Essentially writeq/readq doesn't seems to be available on all >> architectures either. > writeq/readq are provided whenever the CPU actually supports 64-bit > atomic loads and stores. Is there a config option which we can make the driver depend on? I mean that ARM doesn't support 64bit atomic loads and stores on MMIO is quite a boomer for us. Toa do you of hand know what we actually need the 64bit atomic stores for? E.g. what is the hardware background? Regards, Christian. > If it doesn't provide them atomic64* is > not going to be atomic vs the I/O device either. And that is on top > of the fact that for various architectures you can't simply use > plain loads and stores on MMIO memory to start with, which is why > we have the special accessors and the __iomem annotation. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel