From: lori.hikichi@broadcom.com (Lori Hikichi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH INTERNAL 1/1] ASoC: cygnus: Remove set_fmt from SPDIF dai ops
Date: Thu, 28 Sep 2017 16:50:10 -0700 [thread overview]
Message-ID: <18d0bb50-7a5d-8099-7d98-57f9e40bd6cd@broadcom.com> (raw)
In-Reply-To: <1506637775-18293-3-git-send-email-lori.hikichi@broadcom.com>
On 9/28/2017 3:29 PM, Lori Hikichi wrote:
> The SPDIF port cannot modify its format so a set_fmt function is not
> needed. Previously, we used a generic set_fmt for all ports and returned
> an error code for the SPDIF port. It is cleaner to not populate the
> set_fmt field.
>
> Signed-off-by: Lori Hikichi <lori.hikichi@broadcom.com>
> ---
> sound/soc/bcm/cygnus-ssp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound/soc/bcm/cygnus-ssp.c
> index 15c438f..b9a3bb8d 100644
> --- a/sound/soc/bcm/cygnus-ssp.c
> +++ b/sound/soc/bcm/cygnus-ssp.c
> @@ -1136,6 +1136,13 @@ static int cygnus_ssp_resume(struct snd_soc_dai *cpu_dai)
> .set_tdm_slot = cygnus_set_dai_tdm_slot,
> };
>
> +static const struct snd_soc_dai_ops cygnus_spdif_dai_ops = {
> + .startup = cygnus_ssp_startup,
> + .shutdown = cygnus_ssp_shutdown,
> + .trigger = cygnus_ssp_trigger,
> + .hw_params = cygnus_ssp_hw_params,
> + .set_sysclk = cygnus_ssp_set_sysclk,
> +};
>
> #define INIT_CPU_DAI(num) { \
> .name = "cygnus-ssp" #num, \
> @@ -1174,7 +1181,7 @@ static int cygnus_ssp_resume(struct snd_soc_dai *cpu_dai)
> .formats = SNDRV_PCM_FMTBIT_S16_LE |
> SNDRV_PCM_FMTBIT_S32_LE,
> },
> - .ops = &cygnus_ssp_dai_ops,
> + .ops = &cygnus_spdif_dai_ops,
> .suspend = cygnus_ssp_suspend,
> .resume = cygnus_ssp_resume,
> };
Please ignore this patch. It was accidentally included in the patch set and is a
duplicate of another patch already in the patch set.
next prev parent reply other threads:[~2017-09-28 23:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 22:29 [PATCH v1 0/3] Minor updates to driver Lori Hikichi
2017-09-28 22:29 ` [PATCH v1 1/3] ASoC: cygnus: Add EXPORT_SYMBOL for helper function Lori Hikichi
2017-09-28 22:29 ` [PATCH INTERNAL 1/1] ASoC: cygnus: Remove set_fmt from SPDIF dai ops Lori Hikichi
2017-09-28 23:50 ` Lori Hikichi [this message]
2017-10-04 11:27 ` Applied "ASoC: cygnus: Remove set_fmt from SPDIF dai ops" to the asoc tree Mark Brown
2017-09-28 22:29 ` [PATCH v1 2/3] ASoC: cygnus: Remove set_fmt from SPDIF dai ops Lori Hikichi
2017-09-28 22:29 ` [PATCH v1 3/3] ASoC: cygnus: Remove support for 8 bit audio and for mono Lori Hikichi
2017-10-04 11:27 ` Applied "ASoC: cygnus: Remove support for 8 bit audio and for mono" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18d0bb50-7a5d-8099-7d98-57f9e40bd6cd@broadcom.com \
--to=lori.hikichi@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox