From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] gpio: 74x164: Use dynamic gpio number assignment if no pdata is present
Date: Fri, 07 Sep 2012 16:01:01 +0200 [thread overview]
Message-ID: <1903354.7S2pl9Kbxh@flexo> (raw)
In-Reply-To: <1347020296-18796-4-git-send-email-maxime.ripard@free-electrons.com>
On Friday 07 September 2012 14:18:12 Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Florian Fainelli <florian@openwrt.org>
Thank you Maxime!
> ---
> drivers/gpio/gpio-74x164.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> index 604b998..ef8baac 100644
> --- a/drivers/gpio/gpio-74x164.c
> +++ b/drivers/gpio/gpio-74x164.c
> @@ -75,12 +75,6 @@ static int __devinit gen_74x164_probe(struct spi_device
*spi)
> struct gen_74x164_chip_platform_data *pdata;
> int ret;
>
> - pdata = spi->dev.platform_data;
> - if (!pdata || !pdata->base) {
> - dev_dbg(&spi->dev, "incorrect or missing platform data\n");
> - return -EINVAL;
> - }
> -
> /*
> * bits_per_word cannot be configured in platform data
> */
> @@ -94,6 +88,12 @@ static int __devinit gen_74x164_probe(struct spi_device
*spi)
> if (!chip)
> return -ENOMEM;
>
> + pdata = spi->dev.platform_data;
> + if (pdata && pdata->base)
> + chip->gpio_chip.base = pdata->base;
> + else
> + chip->gpio_chip.base = -1;
> +
> mutex_init(&chip->lock);
>
> dev_set_drvdata(&spi->dev, chip);
> @@ -104,7 +104,6 @@ static int __devinit gen_74x164_probe(struct spi_device
*spi)
> chip->gpio_chip.direction_output = gen_74x164_direction_output;
> chip->gpio_chip.get = gen_74x164_get_value;
> chip->gpio_chip.set = gen_74x164_set_value;
> - chip->gpio_chip.base = pdata->base;
> chip->gpio_chip.ngpio = 8;
> chip->gpio_chip.can_sleep = 1;
> chip->gpio_chip.dev = &spi->dev;
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-09-07 14:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 12:18 [PATCHv2 0/7] gpios: Add daisy-chaining and dt support to 74x164 Maxime Ripard
2012-09-07 12:18 ` [PATCH 1/7] gpio: 74x164: Use module_spi_driver boiler plate function Maxime Ripard
2012-09-07 12:18 ` [PATCH 2/7] gpio: 74x164: Use devm_kzalloc Maxime Ripard
2012-09-07 12:18 ` [PATCH 3/7] gpio: 74x164: Use dynamic gpio number assignment if no pdata is present Maxime Ripard
2012-09-07 14:01 ` Florian Fainelli [this message]
2012-09-07 21:04 ` Linus Walleij
2012-09-07 12:18 ` [PATCH 4/7] gpio: 74x164: Add device tree support Maxime Ripard
2012-09-07 21:05 ` Linus Walleij
2012-09-07 12:18 ` [PATCH 5/7] gpio: 74x164: Add support for the daisy-chaining Maxime Ripard
2012-09-07 14:03 ` Florian Fainelli
2012-09-07 21:08 ` Linus Walleij
2012-09-07 21:07 ` Linus Walleij
2012-09-10 1:51 ` Shawn Guo
2012-09-11 16:57 ` Linus Walleij
2012-09-12 2:07 ` Shawn Guo
2012-09-07 12:18 ` [PATCH 6/7] gpio: 74x164: dts: Add documentation for the dt binding Maxime Ripard
2012-09-07 12:18 ` [PATCH 7/7] ARM: dts: cfa10049: Add the 74HC595 gpio expanders Maxime Ripard
2012-09-10 2:23 ` Shawn Guo
2012-09-10 9:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1903354.7S2pl9Kbxh@flexo \
--to=florian@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox