Re: [PATCH v2 2/2] dt-bindings: arm: rockchip: Add Firefly ITX-3588J board

["Heiko Stübner" <heiko@sntech.de>]

Hi,

Am Freitag, 13. Dezember 2024, 19:08:55 CET schrieb Shimrra Shai:
> Document the compatibles for the new board.
> 
> Signed-off-by: Shimrra Shai <shimrrashai@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 753199a12..9ee96acdc 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -190,6 +190,11 @@ properties:
>            - const: firefly,firefly-rk3399
>            - const: rockchip,rk3399
>  
> +      - description: Firefly ITX-3588J
> +        items:
> +          - const: firefly,itx-3588j
> +          - const: rockchip,rk3588
> +

looking at the product-page, this is not _one_ complete board. Instead
it seems to be a system-on-module + baseboard design.

It looks like it uses the Core-3588J system-on-module [0].

We already have a number of those in the binding file to take as example
on how to structure that. For example FriendlyElec CM3588-based boards .

So you could do

      - description: Firefly Core-3588J-based boards
        items:
          - enum:
              - firefly,itx-3588j
          - const: firefly,core-rk3588j
          - const: rockchip,rk3588


Thanks
Heiko



[0] https://en.t-firefly.com/product/core/core3588j