From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AC88C433F5 for ; Tue, 3 May 2022 19:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b2WIz01fEZnclcsb13eS3ZW3+yvbJ52Jrt+MiMKKg6M=; b=R/Ws8827Y4FQL4 xByLFyYyHQK5xYOslJIsjF5p1dqj+guY3mrgt7O1B/BQLcl+erYH7/V95zZ9bhaYptgglFnisTaKF 06S/fugLE+E7P+xLFRCGph2nQTFq16S8VGZArRLPLXpQGUZkulm18vsK96RpWW5jUWMH7aU0NESJu UIv4UXtXBWYsur/A7OL+uH90Xa0w+p8avKyZBiSzQauiGleBuykoazIJZJdCOnX4oQBKJY3VDvJZ6 Evq2e9GJXPOUkp7tLn79gLr8CeksUuo7jhhvV1hFUfjqlqyt3CJGQCHC5OCHTLRUeRRoTEeAgABsb K9mvpP9dhh7agMTPptYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlyc8-007Sgx-KQ; Tue, 03 May 2022 19:55:16 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlyc5-007Sg2-Dn for linux-arm-kernel@lists.infradead.org; Tue, 03 May 2022 19:55:15 +0000 Received: by mail-ed1-x532.google.com with SMTP id z19so21024057edx.9 for ; Tue, 03 May 2022 12:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f+DEWzHhrxACEjCwf7T0XjTn5ZBDS8HwV0VUoztADHg=; b=dWLQHeoIxj+f1p4NCW93iqTklgcPL8WN0VuU+snkXlk2e1hf/c1RslsVyzMpo2rubA aZXIFZUrQG8a+AyRVzwzNx4AWUU+bUr21V+BiFmJ56ovyWrWbxyDAn3BvwRUjlNZzaA+ 2pbWWBgON/CUoe/eI+HkhFGZ74Xt/QC0HWHDGK13u6ECrm+y1OX8PqX6f6pN7NmsV8CN lvFk9hEsITGgScX/jyvHbEIg4J7rsMYP3IAq4FFqLh4CYMnmw3NgJ1m+5IALM1N/M0tB 93TM1R0pam1GOV+dM0YG942rezIGdI63lEAjEb+x5tCWD1/MyXGdvekj8hgNttSjmCPc wLAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f+DEWzHhrxACEjCwf7T0XjTn5ZBDS8HwV0VUoztADHg=; b=kURHmUWx2fn4uYsh6C0roGm0NueAEQWwULEZTCNpgTmghRE4XQM51zVCUdlbgVUYMB TDkU8C+Ezwzrzngk2772iUOgFp8UroMBSbnLB0cGqCgPy0ZBkO7UOJQS8h1LNLKuqheB gMGLim5oPto9b7NDZLFLW7DJNjhY42TN5/bd/DDb7at+21YiC16woId8HOW1fLMFLHSj ANNV8An0Z0TzVzeaK4kv0kk41MsrmvABj7hqOHZJZuqgp99xPdH3QRGub9ttGBIzPGLa 6UoqPD+8KC++i6VrqT4eaaNO7I20PdXL82pmxlQmFAQLpimmo/T2qecX25QTxNzjn3uq /PCg== X-Gm-Message-State: AOAM532IPB1EqvYw76TmyDKl2qhTRbGE00nnEQdR1i/G3SWt2sQkyZnt EK8Z4LstU3+6Y39XXx16wrU= X-Google-Smtp-Source: ABdhPJxVyHdtQ9I2qKWzhlqsVlMnvcDSlegTZwE6qyb2HVxhTsJ1dRUbc42Lcopb65c/ra5IlrQMqQ== X-Received: by 2002:a05:6402:2142:b0:413:6531:bd9e with SMTP id bq2-20020a056402214200b004136531bd9emr19319635edb.5.1651607709862; Tue, 03 May 2022 12:55:09 -0700 (PDT) Received: from kista.localnet (cpe1-3-76.cable.triera.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id g3-20020a50ee03000000b0042617ba63acsm8337929eds.54.2022.05.03.12.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 12:55:09 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: icenowy@outlook.com, Rob Herring Cc: Chen-Yu Tsai , Samuel Holland , Ulf Hansson , Linus Walleij , Andre Przywara , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Icenowy Zheng Subject: Re: Re: [PATCH 05/12] dt-bindings: clock: sunxi-ng: add bindings for R329 CCUs Date: Tue, 03 May 2022 21:55:08 +0200 Message-ID: <1910544.usQuhbGJ8B@kista> In-Reply-To: References: <20220422140902.1058101-1-icenowy@aosc.io> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220503_125513_537487_7AE60B67 X-CRM114-Status: GOOD ( 26.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 02. maj 2022 ob 23:34:27 CEST je Rob Herring napisal(a): > On Fri, Apr 22, 2022 at 11:41:08PM +0800, icenowy@outlook.com wrote: > > From: Icenowy Zheng > > > > R329 has a CPUX CCU and a R-CCU, with all PLLs in R-CCU. > > > > Add bindings for them, with R-CCU only taking 3 oscillators as input and > > main CCU taking oscillators + PLLs as input. > > > > Signed-off-by: Icenowy Zheng > > --- > > .../clock/allwinner,sun4i-a10-ccu.yaml | 62 ++++++++++++++-- > > include/dt-bindings/clock/sun50i-r329-ccu.h | 73 +++++++++++++++++++ > > include/dt-bindings/clock/sun50i-r329-r-ccu.h | 45 ++++++++++++ > > include/dt-bindings/reset/sun50i-r329-ccu.h | 45 ++++++++++++ > > include/dt-bindings/reset/sun50i-r329-r-ccu.h | 24 ++++++ > > 5 files changed, 241 insertions(+), 8 deletions(-) > > create mode 100644 include/dt-bindings/clock/sun50i-r329-ccu.h > > create mode 100644 include/dt-bindings/clock/sun50i-r329-r-ccu.h > > create mode 100644 include/dt-bindings/reset/sun50i-r329-ccu.h > > create mode 100644 include/dt-bindings/reset/sun50i-r329-r-ccu.h > > > > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10- ccu.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10- ccu.yaml > > index 15ed64d35261..c7a429e55483 100644 > > --- a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml > > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml > > @@ -45,6 +45,8 @@ properties: > > - allwinner,sun50i-h6-r-ccu > > - allwinner,sun50i-h616-ccu > > - allwinner,sun50i-h616-r-ccu > > + - allwinner,sun50i-r329-ccu > > + - allwinner,sun50i-r329-r-ccu > > - allwinner,suniv-f1c100s-ccu > > - nextthing,gr8-ccu > > > > @@ -106,6 +108,7 @@ else: > > - allwinner,sun50i-a100-ccu > > - allwinner,sun50i-h6-ccu > > - allwinner,sun50i-h616-ccu > > + - allwinner,sun50i-r329-r-ccu > > > > then: > > properties: > > @@ -118,14 +121,57 @@ else: > > maxItems: 3 > > > > else: > > - properties: > > - clocks: > > - minItems: 2 > > - maxItems: 2 > > - > > - clock-names: > > - minItems: 2 > > - maxItems: 2 > > + if: > > + properties: > > + compatible: > > + const: allwinner,sun50i-r329-ccu > > + then: > > + properties: > > + clocks: > > + minItems: 13 > > + maxItems: 13 > > This is (or should be) implied by the size of 'items'. Did you find that > to not be the case? > > > + items: > > + - description: High Frequency Oscillator (usually at 24MHz) > > + - description: Low Frequency Oscillator (usually at 32kHz) > > + - description: Internal Oscillator > > + - description: CPUX PLL > > + - description: Peripherals PLL > > + - description: Peripherals PLL (2x) > > + - description: Peripherals PLL derivated 800MHz clock > > + - description: Audio PLL 0 > > + - description: Audio PLL 0 (/2) > > + - description: Audio PLL 0 (/5) > > + - description: Audio PLL 1 > > + - description: Audio PLL 1 (2x) > > + - description: Audio PLL 1 (4x) > > > diff --git a/include/dt-bindings/clock/sun50i-r329-ccu.h b/include/dt- bindings/clock/sun50i-r329-ccu.h > > new file mode 100644 > > index 000000000000..116f8d13a9b3 > > --- /dev/null > > +++ b/include/dt-bindings/clock/sun50i-r329-ccu.h > > @@ -0,0 +1,73 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (c) 2021 Sipeed > > It's 2022. > > > diff --git a/include/dt-bindings/clock/sun50i-r329-r-ccu.h b/include/dt- bindings/clock/sun50i-r329-r-ccu.h > > new file mode 100644 > > index 000000000000..c327d1a1b602 > > --- /dev/null > > +++ b/include/dt-bindings/clock/sun50i-r329-r-ccu.h > > @@ -0,0 +1,45 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > diff --git a/include/dt-bindings/reset/sun50i-r329-ccu.h b/include/dt- bindings/reset/sun50i-r329-ccu.h > > new file mode 100644 > > index 000000000000..bb704a82443f > > --- /dev/null > > +++ b/include/dt-bindings/reset/sun50i-r329-ccu.h > > @@ -0,0 +1,45 @@ > > +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ > > > diff --git a/include/dt-bindings/reset/sun50i-r329-r-ccu.h b/include/dt- bindings/reset/sun50i-r329-r-ccu.h > > new file mode 100644 > > index 000000000000..40644f2f21c6 > > --- /dev/null > > +++ b/include/dt-bindings/reset/sun50i-r329-r-ccu.h > > @@ -0,0 +1,24 @@ > > +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ > > Why the different licenses? GPL-2.0 OR BSD-2-Clause is preferred. MIT is > fine if that's what matches the dts files. Yes, most, if not all, DT files for Allwinner are dual licensed under GPL2+ and MIT. There are still some files under include/dt-bindings which are dual licensed under GPL2+ and X11, but I believe those files are for older SoCs. Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel