From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, maz@kernel.org,
will@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, steven.price@arm.com,
aneesh.kumar@kernel.org, oupton@kernel.org, gshan@redhat.com,
joey.gouly@arm.com, tabba@google.com, yuzenghui@huawei.com,
linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com,
sdonthineni@nvidia.com, alpergun@google.com,
fj0570is@fujitsu.com, WeiLin.Chang@arm.com,
lpieralisi@kernel.org, enju.kohei@fujitsu.com,
sudeep.holla@arm.com, jonathan.cameron@oss.qualcomm.com
Subject: Re: [PATCH v22 09/10] firmware: arm_rmm: Add wrappers for Realm related RMI commands
Date: Fri, 2 Oct 2026 16:28:06 +0100 [thread overview]
Message-ID: <1910861a-1188-4ba9-ace9-be82304c95a5@arm.com> (raw)
In-Reply-To: <ar-QC4vtcULyJ5dW@arm.com>
On 02/10/2026 12:05, Catalin Marinas wrote:
> On Fri, Oct 02, 2026 at 07:15:05AM +0100, Suzuki K Poulose wrote:
>> +/*
>> + * rmi_smccc_invoke_once: Invoke the RMI call and return the results. Do not
>> + * retry the command. Let the caller deal with RMI_BUSY or RMI_BLOCKED.
>> + *
>> + * @regs: Input parameters filled in. Updated with the ouptput results
>> + * after the call.
>> + */
>> +static __always_inline void rmi_smccc_invoke_once(struct arm_smccc_1_2_regs *regs)
>> +{
>> + struct arm_smccc_1_2_regs args = *regs;
>> +
>> + arm_smccc_1_2_smc(&args, regs);
>> +}
>
> Nit: I mentioned on v21 - is the copy to args still needed? Can we not
> do just:
Sorry, yes, you are right. This is a single call and we are fine to
overwrite the results.
>
> arm_smccc_1_2_smc(regs, regs);
>
> (no need to respin, I can fix it locally)
Yes please
Suzuki
>
next prev parent reply other threads:[~2026-10-02 15:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 6:14 [PATCH v22 00/10] firmware: arm_rmm: Add RMM v2.0 base RMI support Suzuki K Poulose
2026-10-02 6:14 ` [PATCH v22 01/10] firmware: arm_rmm: Add SMC definitions for calling the RMM Suzuki K Poulose
2026-10-02 6:14 ` [PATCH v22 02/10] firmware: arm_rmm: Check for RMI support at init Suzuki K Poulose
2026-10-02 6:14 ` [PATCH v22 03/10] firmware: arm_rmm: Configure the RMM with the host's page size Suzuki K Poulose
2026-10-02 6:15 ` [PATCH v22 04/10] firmware: arm_rmm: Add support for SRO Suzuki K Poulose
2026-10-02 6:15 ` [PATCH v22 05/10] firmware: arm_rmm: Activate the RMM Suzuki K Poulose
2026-10-02 6:15 ` [PATCH v22 06/10] firmware: arm_rmm: Ensure the RMM has GPT entries for memory Suzuki K Poulose
2026-10-02 6:15 ` [PATCH v22 07/10] kernel: hibernate: Add an arch hook for preventing hiberation Suzuki K Poulose
2026-10-02 11:03 ` Catalin Marinas
2026-10-02 15:29 ` Suzuki K Poulose
2026-10-02 13:32 ` Sudeep Holla
2026-10-02 6:15 ` [PATCH v22 08/10] arm64: Block hibernate and kexec while RMM is active Suzuki K Poulose
2026-10-02 6:15 ` [PATCH v22 09/10] firmware: arm_rmm: Add wrappers for Realm related RMI commands Suzuki K Poulose
2026-10-02 11:05 ` Catalin Marinas
2026-10-02 15:28 ` Suzuki K Poulose [this message]
2026-10-02 6:15 ` [PATCH v22 10/10] firmware: arm_rmm: hotplug: Skip memory added to ZONE_MOVABLE Suzuki K Poulose
2026-10-02 7:57 ` David Hildenbrand (Arm)
2026-10-02 18:49 ` [PATCH v22 00/10] firmware: arm_rmm: Add RMM v2.0 base RMI support Catalin Marinas
2026-10-03 5:57 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1910861a-1188-4ba9-ace9-be82304c95a5@arm.com \
--to=suzuki.poulose@arm.com \
--cc=WeiLin.Chang@arm.com \
--cc=alpergun@google.com \
--cc=aneesh.kumar@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=enju.kohei@fujitsu.com \
--cc=fj0570is@fujitsu.com \
--cc=gankulkarni@os.amperecomputing.com \
--cc=gshan@redhat.com \
--cc=joey.gouly@arm.com \
--cc=jonathan.cameron@oss.qualcomm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=sdonthineni@nvidia.com \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox