From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7891CC67861 for ; Sat, 6 Apr 2024 21:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: Cc:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=633xHrbJ8Mhuf5iT0OhzoQli0WBYc5t5AO8yNQPEcJg=; b=dDv/hIGMJrssSj 7lMVoWTp8kN/YieiHFJ7jSniRcc9MHY+bKaX1an2q8vYXGcE2A4fHQoST9Vs6vlRmUr7m8/Stl11D 6ZVWTL4NRFZV4Ec5IxJTBDLGq8YasUmTV8A0PrQ7d8W3+E7KeXFatlQxVp7jx0S0jiWFiXrS8OF9j aob8DimlBeqtxKwIKvhGsZ1QsgHZgSOlh31lt9w/+TH9C164VHgkfsNLhV1IHGCbboR/i5w8W4cVW j7D7EWBGJPeUunmReVAnjh6ztIc0YnxMQJclGaiopsMIIk46YKFhgg7pnwA+L2Gb1QzFiGXKErIO4 /SPD+lG/piWbm9bH379A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtDbY-0000000B42S-2GXC; Sat, 06 Apr 2024 21:29:40 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtDbW-0000000B422-15e3 for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2024 21:29:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1712438976; bh=jtSgZNk3hRgVdNXAxN/QO4zcEXGXqHzRRQIB7hldayU=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=GlZYdxsop3DOYjVwcXWveKt6wlvClTn+wFiMEgZ/vEi8s6kyhtfk3qmIB7988mpka FndZhQGS7XFhScAncYu1rgxMC8gkcVnO7cv2etkgDv9AEei+rapMhQYeGh3ZkFlJxc tJIB/0BzUQy4e1EyFutCTN5NIco/b3mSudoB2x3L0RcGK19XHrC4gsYQVpPr1B86OZ Oim0WRSc/PdOi49uZpeOA9bWulNuiBVaVW2OAgJPLzICCYVq/QD6nWGcxDDAH0hKkm UtkS0iRqKbiGHfDZawCWBb6sWplU9LE+JChY9H8PZPxDuqNTlOeHFkjoDO0squ7s9F kLJxYcuhdlTOA== Received: from [100.113.15.66] (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 5EAE837809CE; Sat, 6 Apr 2024 21:29:30 +0000 (UTC) Message-ID: <1913ab65-b3d2-40b9-9f81-c9ee9c769d91@collabora.com> Date: Sun, 7 Apr 2024 02:30:03 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com, suzuki.poulose@arm.com, ryan.roberts@arm.com, rob.herring@arm.com, Catalin.Marinas@arm.com, broonie@kernel.org, will@kernel.org, mark.rutland@arm.com Subject: Re: [PATCH 3/4] selftests/arm: Add elf test To: Dev Jain , shuah@kernel.org, linux-arm-kernel@lists.infradead.org References: <20240405084410.256788-1-dev.jain@arm.com> <20240405084410.256788-4-dev.jain@arm.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240405084410.256788-4-dev.jain@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_142938_472766_6972FE60 X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/5/24 1:44 PM, Dev Jain wrote: > This patch introduces an ELF parsing test; the 5th byte of the ELF header > must be 0x01 for a 32-bit process. A basic sanity check is required to ensure > that we are actually testing a 32-bit build. > > Signed-off-by: Dev Jain > --- > tools/testing/selftests/arm/elf/parse_elf.c | 75 +++++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 tools/testing/selftests/arm/elf/parse_elf.c > > diff --git a/tools/testing/selftests/arm/elf/parse_elf.c b/tools/testing/selftests/arm/elf/parse_elf.c > new file mode 100644 > index 000000000000..decd65699858 > --- /dev/null > +++ b/tools/testing/selftests/arm/elf/parse_elf.c > @@ -0,0 +1,75 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2024 ARM Limited > + * > + * Author : Dev Jain > + * > + * Parse elf header to confirm 32-bit process > + */ > + > +#define _GNU_SOURCE > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +/* The ELF file header. This appears at the start of every ELF file. */ > + > +struct elf_header { > + unsigned char e_ident[16]; /* Magic number and other info */ > + uint16_t e_type; /* Object file type */ > + uint16_t e_machine; /* Architecture */ > + uint32_t e_version; /* Object file version */ > + uint64_t e_entry; /* Entry point virtual address */ > + uint64_t e_phoff; /* Program header table file offset */ > + uint64_t e_shoff; /* Section header table file offset */ > + uint32_t e_flags; /* Processor-specific flags */ > + uint16_t e_ehsize; /* ELF header size in bytes */ > + uint16_t e_phentsize; /* Program header table entry size */ > + uint16_t e_phnum; /* Program header table entry count */ > + uint16_t e_shentsize; /* Section header table entry size */ > + uint16_t e_shnum; /* Section header table entry count */ > + uint16_t e_shstrndx; /* Section header string table index */ > +}; > + > +static int read_elf_header(const char *elfFile) > +{ > + struct elf_header header; > + FILE *file; > + > + file = fopen(elfFile, "r"); > + if (file) { > + > + /* store header in struct */ > + fread(&header, 1, sizeof(header), file); > + fclose(file); > + > + /* sanity check: does it really follow ELF format */ > + if (header.e_ident[0] == 0x7f && > + header.e_ident[1] == 'E' && > + header.e_ident[2] == 'L' && > + header.e_ident[3] == 'F') { > + if (header.e_ident[4] == 0x01) > + return 0; > + return 1; > + } > + ksft_exit_fail_msg("Cannot parse /proc/self/exe\n"); > + } > + ksft_exit_fail_msg("Cannot open /proc/self/exe\n"); > + exit(EXIT_FAILURE); Instead of failing and exiting multiple times here, use ksft_print_msg, return error or -1 from here and fail the test case in ksft_test_result(). > +} > + > +int main(int argc, char *argv[]) > +{ > + const char *file_name; > + > + ksft_print_header(); > + ksft_set_plan(1); > + > + file_name = "/proc/self/exe"; > + ksft_test_result(read_elf_header(file_name) == 0, "ELF is 32 bit\n"); > + ksft_finished(); > +} -- BR, Muhammad Usama Anjum _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel