Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: mikpe@it.uu.se (Mikael Pettersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic v2
Date: Wed, 21 Oct 2009 01:02:31 +0200	[thread overview]
Message-ID: <19166.16775.583244.140972@pilspetsen.it.uu.se> (raw)
In-Reply-To: <1256078002-27919-1-git-send-email-linus.walleij@stericsson.com>

Linus Walleij writes:
 > This moves the clocksource_set_clock() and clockevent_set_clock()
 > from the MIPS timer code into clockchips and clocksource where
 > it belongs. The patch was triggered by code posted by Mikael
 > Pettersson duplicating this code for the IOP ARM system. The
 > function signatures where altered slightly to fit into their
 > destination header files, unsigned int changed to u32 and inlined.
 > 
 > Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
 > Cc: Thomas Gleixner <tglx@linutronix.de>
 > Tested-by: Mikael Pettersson <mikpe@it.uu.se>
 > Reviewed-by: Ralf Baechle <ralf@linux-mips.org>
 > ---
 > Changes v1->v2:
 > - Fixed Mikaels comments: spelling, terminology.
 > - Kept the functions inline: all uses and foreseen uses
 >   are once per kernel and all are in __init or __cpuinit sections.
 > - Unable to break out common code - the code is not common and
 >   implementing two execution paths will be more awkward.
 > - Hoping the tglx likes it anyway.

Very minor spelling nits below.

 > --- a/include/linux/clockchips.h
 > +++ b/include/linux/clockchips.h
 > @@ -115,6 +115,28 @@ static inline unsigned long div_sc(unsigned long ticks, unsigned long nsec,
 >  	return (unsigned long) tmp;
 >  }
 >  
 > +/**
 > + * clockevent_set_clock - calculates an appropriate shift
 > + *			  and mult values for a clockevent given a

can't have 'an' and a plural form, so s/an //

 > --- a/include/linux/clocksource.h
 > +++ b/include/linux/clocksource.h
 > @@ -257,6 +257,28 @@ static inline u32 clocksource_hz2mult(u32 hz, u32 shift_constant)
 >  }
 >  
 >  /**
 > + * clocksource_set_clock - calculates an appropriate shift
 > + *			   and mult values for a clocksource given a

ditto

  reply	other threads:[~2009-10-20 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20 22:33 [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic v2 Linus Walleij
2009-10-20 23:02 ` Mikael Pettersson [this message]
2009-10-25 22:18 ` Linus Walleij
2009-11-03 13:51   ` Linus Walleij
2009-11-03 15:29     ` Thomas Gleixner
2009-11-10 17:03 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19166.16775.583244.140972@pilspetsen.it.uu.se \
    --to=mikpe@it.uu.se \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox