From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDC48C6FD1F for ; Sat, 25 Mar 2023 07:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XmMG7zMviaBd/LI0GGostt78X0Bh0SHbE2N0y3PaYH8=; b=IbPRjG4gROPi8a fsC7w0BPm/6ogiBaT5S5E+eP8PRnChMmer83mnhVm6XpuTFagZywq/vy9ZK5r0S/H+1jTwp9s+RGL X602lbVJx6B2YkPWsF+/JSEuS25JH3ZCYGOuw8qn3mDz4RZ2RT/XjzuIX2EGXMzA/heRO9s4c65Ef me656TowqqRAsEMudRO1ix7bypHL/SQCpXBgPG9AtcJ8oBj19NSDY+0ZF1VMmAHu+w5O3TVJnmvhk GKK1dwgvnVB1yBuV/WVnYNznzzK1CzhztE+dWmSJ7uc2K6BGRbuCCqgVS4ONFk70C2JjJA5BCVszk 8NiMFTmC+WCEqRxHF97A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfy6x-006Km9-0s; Sat, 25 Mar 2023 07:14:47 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfy6t-006KlD-2t for linux-arm-kernel@lists.infradead.org; Sat, 25 Mar 2023 07:14:45 +0000 Received: by mail-ed1-x535.google.com with SMTP id t10so16008154edd.12 for ; Sat, 25 Mar 2023 00:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679728481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tKSigRHH+PS1fXr6YtfPL0lgeDwBUnudMTVAS6GkLQA=; b=iad1hEloIeNWTkeC7J3lNjpD3n3CrQROpyL59K1nwy53c3XvO2utqbKhsiRxIbfygw q89h6R8+TUn6imm2/erN2rRB4rc/7Efp/eMygldgyfD4X+hrMINbDaWkBXf/bieshJ+Y UzLkakckWt5RvcDAeAPAuUVFFq23Ka5Y0LTsZRhnbCIuFN18x03lDPkbOQ7B4jqeeso+ gGabt4Ob/AFF5+/D4lEyHiu94xPeioaevJNcCdVViD9Le+3RDprA4FarEtnkIBg1SPem LJEHRf/lOX2LPThvu78vCRDwQWIctyJjtspCeTUbNzj8aM09X6u53u1pmc4gBn+i0PQ/ gQTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679728481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tKSigRHH+PS1fXr6YtfPL0lgeDwBUnudMTVAS6GkLQA=; b=rF0F34aQcZ/sbb19qHRY3OR/hg4EyPM6N+/tzkeylY3PhyneDuheO9iNYPP32mt75D 8A+yOZbMJt2PkQSDrFUgR38jT2fZ2XYD7Y1qrKf4Zi+r9i3VeqzdiviGE0xmM4MtjVPu Xq++z1500qaNH6EUNI7rPgFEcDVuxAJ96dADnQ/Fc5HwW/tyY6nan7wTb1RcbffB7pIi v/yTX9BE7AbYOHqzmQO9qLs7KQstgPs4OygnQ/Sers7NVgCSYqtuT3dJPLUUpEkWNm1k VQK9aylaqW8st1DcE4zQqJ+C75ofZgs7LLKAjW89x1CydfatcJQ6GVHsKctdiCo5VdL+ qg+w== X-Gm-Message-State: AO0yUKWhHlk2OpNu3REkZAcOJnfPiohG1igpJKIoQ6zYCX2ODjhDn2Uy ZG+u+7ftMw8xAIEG9/+g4ow= X-Google-Smtp-Source: AK7set8uTpTaUFXnqv8P2EaUXEm89ZCDBdhR1oDYkEehQSByi6yexPuTTUhvxT/8GXRy4pfLDtjB9Q== X-Received: by 2002:a05:6402:b8c:b0:4b6:821e:1859 with SMTP id cf12-20020a0564020b8c00b004b6821e1859mr11650958edb.7.1679728481194; Sat, 25 Mar 2023 00:14:41 -0700 (PDT) Received: from kista.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id s12-20020a50d48c000000b005023aaf52desm58357edi.95.2023.03.25.00.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Mar 2023 00:14:40 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Paul Kocialkowski Cc: Paul Kocialkowski , Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Laurent Pinchart , Adam Pigg , Thomas Petazzoni Subject: Re: [PATCH 8/9] media: sun6i-isp: capture: Implement MC I/O with extended enum_fmt Date: Sat, 25 Mar 2023 08:14:39 +0100 Message-ID: <1923234.PYKUYFuaPT@kista> In-Reply-To: <20230324151228.2778112-9-paul.kocialkowski@bootlin.com> References: <20230324151228.2778112-1-paul.kocialkowski@bootlin.com> <20230324151228.2778112-9-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230325_001443_953211_107B9274 X-CRM114-Status: GOOD ( 20.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 24. marec 2023 ob 16:12:27 CET je Paul Kocialkowski napisal(a): > This driver needs the media-controller API to operate and should not be > considered as a video-device-centric implementation. > > Properly report the IO_MC device cap and extend the enum_fmt > implementation to support enumeration with an explicit mbus_code. > > Signed-off-by: Paul Kocialkowski > --- > .../staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c > index 1595a9607775..5160b93b69ff 100644 > --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c > +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c > @@ -439,6 +439,12 @@ static int sun6i_isp_capture_enum_fmt(struct file *file, void *private, > struct v4l2_fmtdesc *fmtdesc) > { > u32 index = fmtdesc->index; > + u32 mbus_code = fmtdesc->mbus_code; Nit: reverse christmas tree Other than that: Reviewed-by: Jernej Skrabec Best regards, Jernej > + > + if (mbus_code && !sun6i_isp_proc_format_find(mbus_code)) > + return -EINVAL; > + > + /* Capture format is independent from proc format. */ > > if (index >= ARRAY_SIZE(sun6i_isp_capture_formats)) > return -EINVAL; > @@ -685,7 +691,8 @@ int sun6i_isp_capture_setup(struct sun6i_isp_device *isp_dev) > > strscpy(video_dev->name, SUN6I_ISP_CAPTURE_NAME, > sizeof(video_dev->name)); > - video_dev->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING; > + video_dev->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING | > + V4L2_CAP_IO_MC; > video_dev->vfl_dir = VFL_DIR_RX; > video_dev->release = video_device_release_empty; > video_dev->fops = &sun6i_isp_capture_fops; > -- > 2.39.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel