From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A99C4CF9C6B for ; Tue, 24 Sep 2024 09:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UGv54ZPch4dldjaHLdymCbKvQ0+65iKRTDiB+9dLMKQ=; b=2i0gvUSioHXveUtU8ahFUSJaF7 5hdvmON1bCX1jSkXYdtWS0hI47HSHyPHcwnBH6qg5J483snKUshSBQqslHl8EM5Q7QNf4aw1ADbRw PyN56VXbr6WRKNbuHQefM+fWNlzFFYX+Cl3TZkZiRrtE/iV06z71tEBt6V2kwfi3jr4LWMLs1VzNL 3c8ZYtHEodZnZ6QqUDF/HFKqEV8qEhHtO1JH4Y4XxDX58bcRtojmmX3SHO/Jd2wFfGvarIb3YHpbY RwsV/SXafKNDZQxTRiJVb2jgHWF0aHs/j8xRDCe3DlPHFENZiw75xMbxGTQ30o/DTCG1qxpqt1QyO Y6hb1pqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1st20z-00000001qFr-2L56; Tue, 24 Sep 2024 09:39:25 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1st1tt-00000001oQI-1QUR; Tue, 24 Sep 2024 09:32:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UGv54ZPch4dldjaHLdymCbKvQ0+65iKRTDiB+9dLMKQ=; b=XgMQkuNEPbTmfKL9s1c+A/kV+T qKg9bStvD9OtjJQ8qSw+YqR22Eni9tEyVb+xEVgH7smYY+RaGgofr2C9+jG1mqmE/Xpm+p/V7gmre RmcYgomIwXxgK3m/I1nxiLAgXZylKpLVDfEjrQ+incAaQ5J/HNrCas1vu1uBikbeut+32DFXpv7FA Q2F5Kwklay2l83N8jxkbTgj9r5KoECXAoWYCtV9dgu8x8HnYTEcQhjVPj1E7/Fwgy0HXa70N/NW8Y Lw38bETPsCjEMR/L3NETmUNgcpp0dgaRN49/qZ0M9kvSUf2/2kwRCWWH/yl3zkfHxnleb9s91gnX6 iFbINuvg==; Received: from 90-177-212-167.rck.o2.cz ([90.177.212.167] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1st1tb-0000eW-6G; Tue, 24 Sep 2024 11:31:47 +0200 From: Heiko Stuebner To: Marc Kleine-Budde , kernel@pengutronix.de, Vincent Mailhol , Geert Uytterhoeven Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP Date: Tue, 24 Sep 2024 11:31:45 +0200 Message-ID: <1931378.eGJsNajkDb@phil> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_023205_448907_D27A054F X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 24. September 2024, 11:15:31 CEST schrieb Geert Uytterhoeven: > The Rockchip CAN-FD controller is only present on Rockchip SoCs. Hence > add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this > driver when configuring a kernel without Rockchip platform support. > > Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller") > Signed-off-by: Geert Uytterhoeven makes a lot of sense, and with the compile-test in, it'll still get test-build Reviewed-by: Heiko Stuebner > --- > drivers/net/can/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/can/rockchip/Kconfig b/drivers/net/can/rockchip/Kconfig > index e029e2a3ca4b04df..fd8d9f5eeaa434ac 100644 > --- a/drivers/net/can/rockchip/Kconfig > +++ b/drivers/net/can/rockchip/Kconfig > @@ -3,6 +3,7 @@ > config CAN_ROCKCHIP_CANFD > tristate "Rockchip CAN-FD controller" > depends on OF || COMPILE_TEST > + depends on ARCH_ROCKCHIP || COMPILE_TEST > select CAN_RX_OFFLOAD > help > Say Y here if you want to use CAN-FD controller found on >