From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40FC0C3DA64 for ; Tue, 6 Aug 2024 15:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JsESnciDNwsBhsH6pSpZ4jKH7C3n0UTHpQXotuehS5s=; b=jMjKJkO87w4saWM+W5Z/d+HePJ YBC6Sb9AkTVMKVcSIrAIF0j3/c48PghOTYWgEA4H/H2m36UEZeIVJqfYVkoEKfSZBHDK4ucFI4XAe mUmZnQZZmh1mSlvzRzDd6Mo3ufvCXoj6rHFngmJFdTwOMf3Szu3LYbLImP0iL8PnNF+Y6ADIHmTfV U6ZjYduWRZ3dWlbJekJvhtq/SKZwx2TxHx1P1TV6Tg8LwJ2wSa/rbDRL/FffL9TJ0K4pgHmeYFuhM OJJ2C4yxjq2v2+r5oxTUAL69QOzO5+sepRkwcmrtEtopdSLDYm1XwMuW49P+mpWkYOR+/TW8f+GnN I/eVdjnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbLtA-000000028wd-3NTJ; Tue, 06 Aug 2024 15:14:16 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbLsd-000000028p0-0Kbh; Tue, 06 Aug 2024 15:13:44 +0000 Received: from i53875a9f.versanet.de ([83.135.90.159] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sbLsT-0005t0-N2; Tue, 06 Aug 2024 17:13:33 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-kernel@vger.kernel.org, zhangqing , Detlev Casanova Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, Finley Xiao , YouMin Chen , Liang Chen , Sugar Zhang Subject: Re: [PATCH v2 3/3] clk: rockchip: Add clock controller for the RK3576 Date: Tue, 06 Aug 2024 17:13:30 +0200 Message-ID: <1936032.MyG8hOvIyE@diego> In-Reply-To: <2335430.ElGaqSPkdT@trenzalore> References: <20240802214053.433493-1-detlev.casanova@collabora.com> <2335430.ElGaqSPkdT@trenzalore> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_081343_148631_7A693559 X-CRM114-Status: GOOD ( 16.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Detlev, Am Dienstag, 6. August 2024, 16:15:41 CEST schrieb Detlev Casanova: > The suggestion from Heiko was that those reset should be managed by the > subsystems that use them, because they are on a different offset and therefore > seem to be on a different core. > > But I think I will include them here like you suggested because: > - That's actually how it is done for rk3588 (which is quite close th rk3576), > - According to you and the TRM, those resets are on the same core, just with > big offsets. > > Having the same structure for both SoC makes sense for maintening them. Just without the big offsets between areas please. Similar to how rk3588 does it already. And yep most likely they are in the same block. Just that huge block of space for the cru somehow suggested some algamation of multiple ones, but looking up the rk3588, you're right that it really seems to be one block. I did request the rk3576 TRM from Rockchip - hopefully they'll follow up with that at some point ;-) . Heiko