From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2D1FC636CB for ; Sat, 28 Jan 2023 21:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=txH1oNZNwl7N5Azp4l0MbQ9mUvCTtopSFgrcRi/0IsY=; b=VINe0XVkDBPLX+ VR1u88GrFRHnRzC1hYeN9zbR5r2T6BXZ3v7Ym4ZkpGQPfbx+16fezurHUQLuFxgotWvm2hSfbLiXt RsTk35UxPlQ5ngDZisq/houRVQJ7gb9N86PL3+cbFDuescGz4/uFa89EmO3EN01vaTbpyFBR729aX RzICuLWJuuxSsNg2RCnxBu/x+/r2oWKCfkFLxFCKTcqkcPLl9PoT3KKbj7/2N+EkkPWcUvOMEILoP RPSCvNhLZSyf5dvgSJVQ7R+EA8K8mvEOeY22hJhx+QzXBnNOPjGDeyXUoRUq5NXnts665K15E6ku5 JXNPY0R8qz8FOV7mC01Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLt67-000iBV-AH; Sat, 28 Jan 2023 21:50:55 +0000 Received: from mail.z3ntu.xyz ([128.199.32.197]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLt64-000iB4-2V for linux-arm-kernel@lists.infradead.org; Sat, 28 Jan 2023 21:50:53 +0000 Received: from g550jk.localnet (unknown [62.108.10.64]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 20CD0CC3A1; Sat, 28 Jan 2023 21:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1674942192; bh=9iikV1aWGTt9Mh+BoQkZ8MLRghcUR/xHdzBYyKknK3Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=r96VFzjFyxTrWOeQl4TIxsKCSjynicL2byqQrIH88j+TgGhVbK816BGns0NFYSEQO qeRuRa0gMl/ajJTLjOcQN3KJThbStbuo+iXglXwfYdScWPjEKvxOJllGCPoy45XOe+ hScL9sejbf1340Sj3lTGhffxi7RAn3+7N2zBlDoM= From: Luca Weiss To: Stefan Hansson , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ~postmarketos/upstreaming@lists.sr.ht Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, matti.lehtimaki@gmail.com, Krzysztof Kozlowski Subject: Re: [PATCH 2/3] dt-bindings: arm: qcom: Add MSM8926 and Samsung Galaxy Tab 4 10.1 LTE Date: Sat, 28 Jan 2023 22:43:11 +0100 Message-ID: <1938307.usQuhbGJ8B@g550jk> In-Reply-To: <05a6f073-7002-0156-1225-cd838e482307@linaro.org> References: <20230122144749.87597-1-newbyte@postmarketos.org> <7c69e654-fe57-ad5c-9b41-15aaeaa73102@postmarketos.org> <05a6f073-7002-0156-1225-cd838e482307@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230128_135052_307123_B9AC2A11 X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Montag, 23. J=E4nner 2023 19:08:03 CET Krzysztof Kozlowski wrote: > On 23/01/2023 18:41, Stefan Hansson wrote: > >>> 2. You base on other SoC but you do not include its compatibles. Why?= Is > >>> it intended? None of the properties applicable to other SoC will match > >>> here, thus I actually wonder if you run dtbs_check... > > = > > Sorry, I forgot about running dtbs_check. However, I'm not sure I > > understand the question. What do you mean by that I don't include its > > compatibles? > = > I understood you include the msm8226.dtsi which is a different SoC. If > you include it, you get all of its content. We do it only for compatible > devices, but your device does not indicate compatibility with msm8226. Hi Krzysztof, the way the earlier Qualcomm SoCs work, especially regarding naming scheme = is = the following. There's for example the msm8x74 family which includes msm8974, msm8674, = msm8274, and the a bit differently named apq8074 where the significant = different are the RF capabilities, I think with those only 8974 had LTE, 86= 74 = and 8274 only 3G but different band support, and the apq8074 has no mobile = radio. The same exists for sure also for 8x16 and 8x26, probably a bunch of other = SoCs as well. So from software side (apart from modem firmware of course) it can be treat= ed = in practise as the same SoC so that's why we included the dtsi in this case= in = msm8226 but also msm8926 and apq8026. But the compatible on board-level is in practise (to my knowledge) not real= ly = used for anything important other than having a nice string in the dts file= . I = know some software uses compatible from user space but there for = differentiating between different devices and ignoring the SoC compatibles. But while they are software-compatible for the most part, they *are* distin= ct = SoCs with different capabilities and I just don't see the point in trying t= o = establish some kinds of relationships between different SoCs that are somew= hat = or very similar (msm8226 and msm8974 also share many components but are = obviously different SoCs). And also e.g. (nearly) all apq* dts files we already have in mainline only = have apq compatible and not the corresponding msm* compatible. And I think = that's totally legitimate. Regards Luca > = > > I ran `$ make dtbs_check DT_SCHEMA_FILES=3Dqcom.yaml` locally just now, > > and it only gave me errors from the qcom-msm8974pro-oneplus-bacon dtb. > > Maybe I'm running it wrong? > = > No clue, I cannot test because your patches do not apply cleanly. > = > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel