From mboxrd@z Thu Jan 1 00:00:00 1970
From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=)
Date: Sat, 16 Jun 2018 14:24:09 +0200
Subject: [PATCH 5/5] drm/rockchip: lvds: add missing of_node_put
In-Reply-To: <1527102436-13447-6-git-send-email-Julia.Lawall@lip6.fr>
References: <1527102436-13447-1-git-send-email-Julia.Lawall@lip6.fr>
<1527102436-13447-6-git-send-email-Julia.Lawall@lip6.fr>
Message-ID: <1948755.WvuARZiism@diego>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org
Hi Julia,
Am Mittwoch, 23. Mai 2018, 21:07:16 CEST schrieb Julia Lawall:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> //
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
>
> for_each_child_of_node(root, child) {
> ... when != of_node_put(child)
> when != e = child
> + of_node_put(child);
> ? break;
> ...
> }
> ... when != child
> //
>
> Signed-off-by: Julia Lawall
thanks for catching this. I've added a "Fixes"-tag and
applied the patch to drm-misc-next
Thanks
Heiko