From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF9F2C43381 for ; Tue, 12 Mar 2019 08:42:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91A9C2171F for ; Tue, 12 Mar 2019 08:42:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MNJ78kHU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91A9C2171F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DorbGTgu9RJJVkjokj8dNnO3DEt44NPED4rcL7UZSaw=; b=MNJ78kHUMG40/R AtCqQeTNZTaFXmpSFhmvxEiUtjlOEVTjUqduizzwMpQETlcWuPRJnDVa7Vf3NqFX1F7ZhZSJYtdKO 0395/wyjfaYh/q2X3rH2QZopRMzBJW9RH1zMB4u4L050/6btIfY8Jx2+CuwWEDyh5mEJhvrepWXK5 G1jwSzsf0oby9Rd0nwsvMzqYCe4iIpxo35DhNo1mx3agFV/Ul5FguWgNT9JlquhCpuHJVi6Agoi4R s/heIkLdqQvuMfTKOH7e2ti7QHmP1xCSKzlmHc8+qD2HdU8aUWPzhISub2do4IWnXAYFBUXfSTv8q ++L4mamtn2eOOGlkH4Eg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3czh-0006dZ-Du; Tue, 12 Mar 2019 08:42:41 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3cze-0006cq-23; Tue, 12 Mar 2019 08:42:39 +0000 Received: from we0652.dip.tu-dresden.de ([141.76.178.140] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h3cza-0000YP-1a; Tue, 12 Mar 2019 09:42:34 +0100 From: Heiko Stuebner To: Jonas Karlman Subject: Re: [PATCH] ARM: dts: rockchip: rk3288: fix missing grf reference in tsadc node Date: Tue, 12 Mar 2019 09:42:33 +0100 Message-ID: <1950463.k8Yvi4fDWQ@phil> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_014238_251869_58068649 X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , Rob Herring , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Sonntag, 24. Februar 2019, 22:52:00 CET schrieb Jonas Karlman: > The following message can be seen during boot: > > rockchip-thermal ff280000.tsadc: Missing rockchip,grf property > > Fix this by adding rockchip,grf property to tsadc node. > > Fixes: b67d6bc38823 ("ARM: dts: rockchip: add main thermal info to rk3288") > Signed-off-by: Jonas Karlman applied for 5.2 The warning doesn't affect rk3288 (v2 tsadc) and the grf requirement only got introduced later on after the rk3288 tsadc node, so I've dropped the Fixes tag, also reducing the workload of the stable poeple In general it looks like driver quality of the tsadc deteriorated over time, as it shouldn't warn about missing GRF references on platforms not needing it in the first place. And GRF locations should of course also live in the per-soc data structures as GRF register never are stable like the constants currently suggest. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel