From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: Declare operation structures as const
Date: Fri, 15 Feb 2013 21:56:09 +0100 [thread overview]
Message-ID: <1952247.y2EsDpZE5I@avalon> (raw)
In-Reply-To: <CACRpkdaN+j+cV-=d-cDSw6aoq4Hh0Ary8wpAeYQU7wvpTAQgcQ@mail.gmail.com>
Hi Linus,
On Friday 15 February 2013 21:51:51 Linus Walleij wrote:
> On Fri, Feb 15, 2013 at 3:43 PM, Laurent Pinchart wrote:
> > The pinconf, pinctrl and pinmux operation structures hold function
> > pointers that are never modified. Declare them as const.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
>
> Nice I love consting.
>
> > This patch hasn't been compile-tested on all the above platforms,
> > Tested-by and/or Acked-by tags would thus be welcome.
>
> I get this on all platforms after this patch:
>
> /linux-pinctrl/drivers/pinctrl/pinconf.c: In function
> 'pinconf_dbg_config_print':
> /linux-pinctrl/drivers/pinctrl/pinconf.c:708:12: warning: assignment
> discards 'const' qualifier from pointer target type [enabled by
> default]
>
> Pls fix! :-)
Hmmm... There's no pinconf_dbg_config_print() function in mainline. Where does
it come from ?
> > I've left the sh-pfc driver untouched for now, it will be handled as part
> > as my next (hopefully soon to come) sh-pfc pinctrl series.
>
> Sounds like a deal.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-02-15 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 14:43 [PATCH] pinctrl: Declare operation structures as const Laurent Pinchart
2013-02-15 20:51 ` Linus Walleij
2013-02-15 20:56 ` Laurent Pinchart [this message]
2013-02-15 20:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1952247.y2EsDpZE5I@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox