public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: Fix MDMA0 clock number
Date: Mon, 30 Dec 2013 15:32:32 +0100	[thread overview]
Message-ID: <19574645.fFapTcOjJm@amdc1227> (raw)
In-Reply-To: <20131218193203.23538.30551@quantum>

Hi Mike,

On Wednesday 18 of December 2013 11:32:03 Mike Turquette wrote:
> Quoting Tomasz Figa (2013-12-18 06:49:10)
> > Hi Kukjin,
> > 
> > On Thursday 12 of December 2013 08:32:02 Abhilash Kesavan wrote:
> > > Fix wrong clock number in mdma0 node.
> > > 
> > > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> > > ---
> > >  arch/arm/boot/dts/exynos5250.dtsi |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> > > index 9db5047..177becd 100644
> > > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > > @@ -559,7 +559,7 @@
> > >                       compatible = "arm,pl330", "arm,primecell";
> > >                       reg = <0x10800000 0x1000>;
> > >                       interrupts = <0 33 0>;
> > > -                     clocks = <&clock 271>;
> > > +                     clocks = <&clock 346>;
> > >                       clock-names = "apb_pclk";
> > >                       #dma-cells = <1>;
> > >                       #dma-channels = <8>;
> > > 
> > 
> > Can we have your ack for this patch?
> > 
> > I'd like to apply the whole series into samsung-clk fixes branch and
> > send a pull request to Mike to get it and one more fix into his tree.
> 
> Do these fixes need to go into the current -rc fixes cycle or can they
> go for 3.14?

I'd say that this should go as an -rc fix, because on some systems on
which the firmware may leave the mdma0 clock disabled by default,
trying to initialize MDMA0 by PL330 driver might cause booting failure.

Can we get your ack on this, so I could apply this and send you a pull
request with all fixes?

Best regards,
Tomasz

      reply	other threads:[~2013-12-30 14:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  3:02 [PATCH 1/3] clk: samsung: exynos5250: Fix ACP gate register offset Abhilash Kesavan
2013-12-12  3:02 ` [PATCH 2/3] clk: samsung: exynos5250: Add MDMA0 clocks Abhilash Kesavan
2013-12-12  3:02 ` [PATCH 3/3] ARM: dts: Fix MDMA0 clock number Abhilash Kesavan
2013-12-18 14:49   ` Tomasz Figa
2013-12-18 18:06     ` Kukjin Kim
2013-12-18 19:32     ` Mike Turquette
2013-12-30 14:32       ` Tomasz Figa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19574645.fFapTcOjJm@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox