From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B8B4C48BD7 for ; Thu, 27 Jun 2019 12:43:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43A4A2083B for ; Thu, 27 Jun 2019 12:43:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="frNlH8o2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43A4A2083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WGweJYmLYQYfHlgl2TEs5Kh/BC5XIYvfNaxujfUECUc=; b=frNlH8o2tdRn4w gxJYlFUDqYP4raD/YmojEQc9ApxipOU+9PJnKtU1GRh/tXgekORDNd7WwZzEMTr+zocLXy5yzwsUw 74zhE5nPOmz9Ow4UB5D24Rm5aiQhIuKoxhA2S3ULb1+tu+Dlq6YbPiR3c0Eso+/oToBUJga5ag6OC +Gekg/zHWdXXBcHcTGdzP8QXbY7LuMJfKosu+2e5xT+0JRksDH4/dPge+vSeQ2/M+ToYGNUjUgpRg sacIdMMuOBTNL/AudBhPkP3COm/whgy2b/Ouxe7yADHylSA+4rzmBaAm2aCaiqMcm486tGZSzWdyM 00k6JGOhfZsiDHVb/6jw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgTk0-0008BW-AQ; Thu, 27 Jun 2019 12:43:04 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgTjv-0008AP-SU; Thu, 27 Jun 2019 12:43:01 +0000 Received: from wf0413.dip.tu-dresden.de ([141.76.181.157] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgTjj-0007wm-2p; Thu, 27 Jun 2019 14:42:47 +0200 From: Heiko Stuebner To: Enric Balletbo i Serra Subject: Re: [PATCH] arm64: dts: rockchip: Update DWC3 modules on RK3399 SoCs Date: Thu, 27 Jun 2019 14:42:46 +0200 Message-ID: <1960228.jn0vabPeDx@phil> In-Reply-To: <20190613162745.12195-1-enric.balletbo@collabora.com> References: <20190613162745.12195-1-enric.balletbo@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190627_054300_236822_FCE04C29 X-CRM114-Status: GOOD ( 12.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Felipe Balbi , Masahiro Yamada , Tony Xie , Viresh Kumar , Randy Li , linux-kernel@vger.kernel.org, Vicente Bergas , linux-rockchip@lists.infradead.org, Rob Herring , Klaus Goger , Matthias Brugger , Collabora Kernel ML , linux-arm-kernel@lists.infradead.org, Christoph Muellner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Donnerstag, 13. Juni 2019, 18:27:45 CEST schrieb Enric Balletbo i Serra: > As per binding documentation [1], the DWC3 core should have the "ref", > "bus_early" and "suspend" clocks. As explained in the binding, those > clocks are required for new platforms but not for existing platforms > before commit fe8abf332b8f ("usb: dwc3: support clocks and resets for > DWC3 core"). > > However, as those clocks are really treated as required, this ends with > having some annoying messages when the "rockchip,rk3399-dwc3" is used: > > [ 1.724107] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2 > [ 1.731893] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2 > [ 2.495937] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2 > [ 2.647239] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2 > > In order to remove those annoying messages, update the DWC3 hardware > module node and add all the required clocks. With this change, both, the > glue node and the DWC3 core node, have the clocks defined, but that's > not really a problem and there isn't a side effect on do this. So, we > can get rid of the annoying get clk error messages. > > [1] Documentation/devicetree/bindings/usb/dwc3.txt > > Signed-off-by: Enric Balletbo i Serra applied for 5.3 Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel