Re: [PATCH v2] arm64: dts: imx8mp: Add device tree for Nitrogen8M Plus ENC Carrier Board

[Martyn Welch <martyn.welch@collabora.com>]

 ---- On Thu, 27 Mar 2025 14:25:38 +0000  Andrew Lunn <andrew@lunn.ch> wrote --- 
 > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-nitrogen-som.dtsi
 > > @@ -0,0 +1,415 @@
 > > +&eqos {
 > > +    pinctrl-names = "default";
 > > +    pinctrl-0 = <&pinctrl_eqos>;
 > > +    phy-handle = <&ethphy0>;
 > > +    phy-mode = "rgmii-id";
 > > +    status = "okay";
 > > +
 > > +    mdio {
 > > +        compatible = "snps,dwmac-mdio";
 > > +        #address-cells = <1>;
 > > +        #size-cells = <0>;
 > > +
 > > +        ethphy0: ethernet-phy@4 {
 > 
 > Just conformation, the PHY is on the SOM? Are the magnetics and RJ45
 > socket on the SOM, or the carrier?
 > 

The PHY is on the SOM, the magnetics and RJ45 socket are on the carrier.

 > > +            compatible = "ethernet-phy-ieee802.3-c22";
 > > +            reg = <4>;
 > > +            eee-broken-1000t;
 > 
 > > +#if 0
 > > +            interrupts-extended = <&gpio3 2 IRQ_TYPE_LEVEL_LOW>;
 > > +            reset-gpios = <&gpio3 16 GPIO_ACTIVE_LOW>;
 > > +#endif
 > 
 > Please don't have disabled properties.
 > 

ack.

 > > +            reg-mask = <0x90>;
 > 
 > What does this property do? It is not one i recognise.
 > 

Good question. Seems I missed quite a few bits whilst trying to clean this DTB up. Will try again....

Martyn

 >      Andrew
 >