From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/21] ARM: ux500: Supply the UART clocks lookup to the DBX500 DT
Date: Mon, 03 Jun 2013 15:50:20 +0200 [thread overview]
Message-ID: <196465635.q8uKhQ7JEM@wuerfel> (raw)
In-Reply-To: <1370266965-7901-10-git-send-email-lee.jones@linaro.org>
On Monday 03 June 2013 14:42:33 Lee Jones wrote:
> @@ -650,6 +650,9 @@
> <&dma 13 0 0x0>; /* Logical - MemToDev */
> dma-names = "rx", "tx";
>
> + clocks = <&clk 83>, <&clk 40>;
> + clock-names = "uart0", "apb_pclk";
> +
> status = "disabled";
> };
>
> @@ -662,6 +665,9 @@
> <&dma 12 0 0x0>; /* Logical - MemToDev */
> dma-names = "rx", "tx";
>
> + clocks = <&clk 84>, <&clk 41>;
> + clock-names = "uart1", "apb_pclk";
> +
> status = "disabled";
> };
>
This seems wrong: why would one of them have a clock named "uart0"
and the other one call it "uart1"? The clock name should be defined
in the binding and specific to the driver using it, not a string that
indicates where it is connected to.
Arnd
next prev parent reply other threads:[~2013-06-03 13:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:42 [PATCH 00/21] ARM: ux500: Enable Clock look-up from Device Tree Lee Jones
2013-06-03 13:42 ` [PATCH 01/21] ARM: ux500: Supply the PRCMU Clock node Lee Jones
2013-06-03 13:42 ` [PATCH 02/21] ARM: ux500: Supply the Ethernet clock lookup to Snowball's DT Lee Jones
2013-06-03 13:42 ` [PATCH 03/21] ARM: ux500: Supply the TWD Timer clock lookup to the DBX500 DT Lee Jones
2013-06-03 13:42 ` [PATCH 04/21] ARM: ux500: Supply the RTC " Lee Jones
2013-06-03 13:42 ` [PATCH 05/21] ARM: ux500: Supply the GPIO clocks " Lee Jones
2013-06-03 13:42 ` [PATCH 06/21] ARM: ux500: Supply the USB clock " Lee Jones
2013-06-03 13:42 ` [PATCH 07/21] ARM: ux500: Supply the DMA " Lee Jones
2013-06-03 13:42 ` [PATCH 08/21] ARM: ux500: Supply the I2C clocks " Lee Jones
2013-06-03 13:54 ` Arnd Bergmann
2013-06-03 14:27 ` Lee Jones
2013-06-03 15:29 ` Arnd Bergmann
2013-06-03 13:42 ` [PATCH 09/21] ARM: ux500: Supply the UART " Lee Jones
2013-06-03 13:50 ` Arnd Bergmann [this message]
2013-06-03 13:42 ` [PATCH 10/21] ARM: ux500: Supply the SDI (MMC) " Lee Jones
2013-06-03 13:42 ` [PATCH 11/21] ARM: ux500: Supply the MSP (Audio) " Lee Jones
2013-06-03 13:42 ` [PATCH 12/21] ARM: ux500: Remove AUXDATA relating to GPIO clock-name bindings Lee Jones
2013-06-03 13:42 ` [PATCH 13/21] ARM: ux500: Remove AUXDATA relating to UART " Lee Jones
2013-06-03 13:42 ` [PATCH 14/21] ARM: ux500: Remove AUXDATA relating to SDI (MMC) " Lee Jones
2013-06-03 13:42 ` [PATCH 15/21] ARM: ux500: Remove AUXDATA relating to I2C " Lee Jones
2013-06-03 13:42 ` [PATCH 16/21] ARM: ux500: Remove AUXDATA relating to MSP (Audio) " Lee Jones
2013-06-03 13:42 ` [PATCH 17/21] ARM: ux500: Remove AUXDATA relating to USB " Lee Jones
2013-06-03 13:42 ` [PATCH 18/21] ARM: ux500: Remove AUXDATA relating to Ethernet " Lee Jones
2013-06-03 13:42 ` [PATCH 19/21] ARM: ux500: Remove AUXDATA relating to DMA " Lee Jones
2013-06-03 13:42 ` [PATCH 20/21] ARM: ux500: Reclassify PRCMU AUXDATA entry Lee Jones
2013-06-03 13:42 ` [PATCH 21/21] clk: ux500: Supply provider look-up functionality to support Device Tree Lee Jones
2013-06-03 15:49 ` Arnd Bergmann
2013-06-04 10:57 ` Linus Walleij
2013-06-04 20:52 ` Arnd Bergmann
2013-06-05 8:05 ` Lee Jones
2013-06-11 20:28 ` Mike Turquette
2013-06-12 12:56 ` Grant Likely
2013-06-10 21:05 ` [PATCH 00/21] ARM: ux500: Enable Clock look-up from " Ulf Hansson
2013-06-11 10:01 ` Lee Jones
2013-06-11 12:07 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=196465635.q8uKhQ7JEM@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox