From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3950FC433F5 for ; Mon, 21 Feb 2022 13:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OUQKNebL+SEIzUozTgCSNCywmD9za3u46KBVnTy5Btc=; b=MxdhubmusTRKIo WyVY3sRTrmset3BH1Ivqw5NWNVmTdmzhaS/a5+fjqsxRamVZWOx//jtFX/wtf/MldYbqMhzbrSRvg YKJySL6AZFsDb+CpLKDlhlClpYPUHtDfpa+UbSZNM3sRVLXDJnVAX2NVD5Km9R9EAD9G1rmKgQrQU 89USS7+RZyVE+/r2vz18BaFnYSAR4EYC7JlVN2gaaZvpWuS83Wk5JbfQnA0h8y1mgOl9/JbQujFGm mN9OYuPzyPiphW1pRSuh+Q38yshVlzmFW9jNV37HvZQe8OHRhkZBUmNdH/h758ZRhLrYnoGnCjI4/ w8Rq5qODswV4foULJ21w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM96d-0062Pe-RD; Mon, 21 Feb 2022 13:52:00 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM8bv-005ryI-VN for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 13:20:17 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A9C8D3F1E6 for ; Mon, 21 Feb 2022 13:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645449614; bh=khb30gE+RkFEqmWXwauRdw21yNeM7x8VXwtb7dTjxrk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t7KNvlr5/wlubIja/R1BCH3ZwjcG8zSQdxBU/37EH48lJvMdmiVNiGyOgf823LFJr b6SmvODIzTM0RoTRa9Ylb6zx8ZIYLqKohCHKg9gGr4uO3QGLLtjUis557bC7iAsmO3 N7qqjNA+LGT5i0WTfSCVYoJ1uMDFKbYaKenviqqd4h/T2+4YqwemEiW0shqoGCbqz+ 8enAkM1yhLvId1ZHMLIGpRhLqKp3dGSyx28/NEmcuu1gwsAP6bgHY0GC6Mng5ODpQq mcuQf+7c5G1/KSszmdshERWaTpcQFLvp0sCRlMy+1SVAwWU2v8Xzu+rsL8Kulc8dcB lgWQY3/SqI03g== Received: by mail-ed1-f69.google.com with SMTP id j29-20020a508a9d000000b00412aa79f367so7286139edj.0 for ; Mon, 21 Feb 2022 05:20:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=khb30gE+RkFEqmWXwauRdw21yNeM7x8VXwtb7dTjxrk=; b=cfkNEnwmB7W94fV0oWwhVieHEa8S9PcNIwwAgTMgfjdcLibWgDrIanHkbPBQZarU3i i5tqmtfN9t0duzMzfxTf593Us0PRpPc8I3shx9wknWK9za//NV5SU0stKmWFoVKkd7TT wXqTthM/a9+tl40fwkiO3vZF2IffJmea65fj5k3CNqyNvQzAke/WMwYnsmoV/sCuGtFW Pr+E/ibOY2CPozQHTCD90P5GR5J7l+x+JWDFifselH1UyK50tsvg18IRrhybIk3h3Wda c6jdG/zqWn6OjvjpHSigP+2sqTNPGu7fewurs1xD8H4WbGuNibJVz02KBzj9MRYb9Pr+ 0wUg== X-Gm-Message-State: AOAM5330RseBWhUEDaSNAeQWd3YSoulUDz10CFVVayXALxL+klDbFskJ Tf/+V/hqgpeij3YdQ59MsejWb0sg+PFteo5XEpJ1jC9rdG5a1GtITGGJE0IJt5Az7j1l2jVx1Zo PIyOq/Kra6qiYuUzFAWK5rc4Zz2hY7YRRu6u72o/caBrkWJk2t0kW X-Received: by 2002:a50:aa87:0:b0:40f:28a0:d0d6 with SMTP id q7-20020a50aa87000000b0040f28a0d0d6mr21735611edc.368.1645449614308; Mon, 21 Feb 2022 05:20:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJyn8wRl+WsEMmydGs9g9zLLhKIDtqHUJiepwJxzF0w7Uxxo57NBO0zLCpmBeBDH0NoWgBQ/Vw== X-Received: by 2002:a50:aa87:0:b0:40f:28a0:d0d6 with SMTP id q7-20020a50aa87000000b0040f28a0d0d6mr21735589edc.368.1645449614162; Mon, 21 Feb 2022 05:20:14 -0800 (PST) Received: from [192.168.0.122] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id 18sm5084626ejj.1.2022.02.21.05.20.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 05:20:13 -0800 (PST) Message-ID: <19705501-2391-14a4-0eac-4b2b647a9735@canonical.com> Date: Mon, 21 Feb 2022 14:20:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC PATCH 8/8] arm64: dts: ti: use 'freq-table' in UFS node Content-Language: en-US To: Nishanth Menon Cc: Alim Akhtar , Avri Altman , Rob Herring , Wei Xu , Andy Gross , Bjorn Andersson , Vignesh Raghavendra , Tero Kristo , "James E.J. Bottomley" , "Martin K. Petersen" , Chanho Park , Srinivas Kandagatla , Jan Kotas , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220219184224.44339-1-krzysztof.kozlowski@canonical.com> <20220219184554.44887-1-krzysztof.kozlowski@canonical.com> <20220221131340.q3hjpjevqrfvhggv@specimen> From: Krzysztof Kozlowski In-Reply-To: <20220221131340.q3hjpjevqrfvhggv@specimen> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_052016_198534_CFAE3DE4 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/02/2022 14:13, Nishanth Menon wrote: > On 19:45-20220219, Krzysztof Kozlowski wrote: >> The 'freq-table-hz' property is deprecated by UFS bindings. >> The uint32-array requires also element to be passed within one <> block. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> index 599861259a30..c3afef0321ae 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> @@ -1257,7 +1257,9 @@ ufs@4e84000 { >> compatible = "cdns,ufshc-m31-16nm", "jedec,ufs-2.0"; >> reg = <0x0 0x4e84000 0x0 0x10000>; >> interrupts = ; >> - freq-table-hz = <250000000 250000000>, <19200000 19200000>, <19200000 19200000>; >> + freq-table = <250000000 250000000 > > is much more readable and less error prone in case of a large > set. Pairs are easily visible if split per line, so readability is similar. Not much is lost. > >> + 19200000 19200000 >> + 19200000 19200000>; > > are you sure the removal of the tuple adds value? DT schema requires it, or rather: I do not know how to express uint32 tuples in DT schema. All my tries failed. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel