From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i.MX51: Full iomux support
Date: Wed, 15 Dec 2010 16:10:16 +0100 [thread overview]
Message-ID: <19720.55896.197553.407321@ipc1.ka-ro> (raw)
In-Reply-To: <87y67rcdnf.fsf@lechat.rtp-net.org>
Hi,
Arnaud Patard (Rtp) writes:
> Sascha Hauer <s.hauer@pengutronix.de> writes:
[...]
> > The following series picks up the patch from Lothar Wa?mann replacing
> > the struct pad_desc with a 64bit variable and adds full i.MX51 iomux
> > support based on this patch.
> > The iomux configurations are taken from the Freescale pinmux tool, so the
> > definitions should be rather complete. Anyway, there are some modes
> > not present in the tool.
> > I took the padmux settings from the old iomux support where present.
>
> I'm seeing a lot of changes in the iomux file and I have a patch [1]
> setting the SION bit for all gpios configuration so that reading the PSR
> value is giving usefull results when the gpio is configured as output. I
> wanted to send it this week but it will obviously conflict with
> this. Should I test your patchset first and if it's working, wait
> for its merge or should I send it anyway ? How do you want to deal with
> this (as long as you're fine with setting the SION bit for all gpios) ?
>
I had done the same, but had some trouble with this.
E.g. on our board GPIO1_7 is used as a generic GPIO to enable an
external clock oscillator for the USBH1 ULPI PHY. When the SION bit
for this pad was set, I got strange errors on the USBH1 port
(disconnecting low speed devices behind a hub would stall the
bus). When I removed the SION bit for that pin everything worked
well.
It looks like the SION setting may adversly affect the GPIO functions
on the i.MX51.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
next prev parent reply other threads:[~2010-12-15 15:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 14:01 [PATCH] i.MX51: Full iomux support Sascha Hauer
2010-12-15 14:01 ` [PATCH 1/2] MXC IOMUX-V3 replace struct pad_desc with bitmapped cookie (step 2) Sascha Hauer
2010-12-15 14:01 ` [PATCH 2/2] ARM i.MX51: Full iomux support Sascha Hauer
2010-12-15 14:29 ` [PATCH] " Arnaud Patard (Rtp)
2010-12-15 15:10 ` Lothar Waßmann [this message]
2010-12-15 15:23 ` Sascha Hauer
2010-12-15 15:37 ` Arnaud Patard (Rtp)
2010-12-27 17:47 ` Nguyen Dinh-R00091
2010-12-27 18:25 ` Nguyen Dinh-R00091
2010-12-28 7:38 ` Lothar Waßmann
2010-12-15 15:15 ` Sascha Hauer
2010-12-15 15:19 ` Lothar Waßmann
2010-12-15 16:12 ` Peter Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19720.55896.197553.407321@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox