public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: dts: rockchip: add roc-rk3328-cc board
Date: Mon, 22 Jan 2018 11:40:47 +0100	[thread overview]
Message-ID: <1977166.SIloaIvObo@phil> (raw)
In-Reply-To: <20180120095404.32117-1-djw@t-chip.com.cn>

Hi Levin,

Am Samstag, 20. Januar 2018, 17:54:04 CET schrieb djw at t-chip.com.cn:
> From: Levin Du <djw@t-chip.com.cn>
> 
> Hi all,
>   This version uses SPDX license tag.
> 
> The roc-rk3328-cc is a credit card size single board computer using the
> Rockchip RK3328 Quad-Core ARM Cortex A53 64-Bit Processor and supporting
> up to 2GB 2133MHz LPDDR4 memory. It provides eMMC module socket, MicroSD
> Card slot, USB 2.0/3.0, Gigabit Ethernet, HDMI/CVBS, Infrared Receiver,
> SPDIF/I2S, and SPI/I2C/UART/PWM interfaces.
> 
> The devicetree currently supports basic peripherals.
> 
> Signed-off-by: Levin Du <djw@t-chip.com.cn>

> +&i2c1 {
> +	status = "okay";
> +
> +	rk805: rk805 at 18 {

As noted by Rob in his review, this should be
	rk805: pmic at 18 {

While I'd normally just change that myself when applying it looks like
you also got comments from Andy to address, so you could change this too.


Thanks
Heiko

  reply	other threads:[~2018-01-22 10:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-06  9:45 [PATCH] arm64: dts: rockchip: add roc-rk3328-cc board djw at t-chip.com.cn
2018-01-11 20:30 ` Rob Herring
2018-01-12  8:33   ` Heiko Stuebner
2018-01-15 18:09     ` Rob Herring
2018-01-20  9:54 ` [PATCH v2] " djw at t-chip.com.cn
2018-01-22 10:40   ` Heiko Stuebner [this message]
2018-01-23  2:10 ` [PATCH v3] " djw at t-chip.com.cn
2018-01-29 23:21   ` Rob Herring
2018-02-02 21:47   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1977166.SIloaIvObo@phil \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox