From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38659C76191 for ; Thu, 25 Jul 2019 19:49:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1426B229F3 for ; Thu, 25 Jul 2019 19:49:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V6EH5pmQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1426B229F3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pQIG/ejKqteCXSa9G2nyEAlhyF8rPKNK0pYGeFoJfKw=; b=V6EH5pmQWt8uai pb6101EhmXV7rvuBuWyoEEop5MsvqnxV/rmVwsOehUy2baWz5LJ8bWLo44B0GrPGRc+jDS6NDkrDJ 01UWV4rtLz36wWuRmvTbeYru65Sz2Ti9Da0bl9H6BG8rGdtYI6G/kBU72DBIlpwHLFNRVFXTvNBxI vlICcssz2B9RQx2Qx5Mcz25Ju1lVMLE21tGmmZbQ3JSJBZH284iKapMeMKdZqu8lxyugQkdFxee+k T7/DzEbVqSz+g/BmcQDBVSZjop4Qzcte1xukS+8Ed39vktOVfFohOxbtGRqKeC58ZM+MJe3PGeTvj 4MezcwV7b8/X5FD4dmHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqjkU-0005cc-Gr; Thu, 25 Jul 2019 19:49:58 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqjkR-0005c6-LK; Thu, 25 Jul 2019 19:49:56 +0000 Received: from d57e23da.static.ziggozakelijk.nl ([213.126.35.218] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqjkO-0001oe-Bz; Thu, 25 Jul 2019 21:49:52 +0200 From: Heiko Stuebner To: Nick Desaulniers Subject: Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable Date: Thu, 25 Jul 2019 21:49:51 +0200 Message-ID: <1978058.CBpQlN27Fr@phil> In-Reply-To: References: <20190627222220.89175-1-nhuck@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_124955_840632_50D1F57A X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: clang-built-linux , sboyd@kernel.org, mturquette@baylibre.com, zhangqing@rock-chips.com, LKML , Nathan Huckleberry , linux-rockchip@lists.infradead.org, andy.yan@rock-chips.com, linux-clk@vger.kernel.org, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 28. Juni 2019, 00:32:38 CEST schrieb Nick Desaulniers: > On Thu, Jun 27, 2019 at 3:22 PM 'Nathan Huckleberry' via Clang Built > Linux wrote: > > > > Clang produces the following warning > > > > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable > > 'mux_pll_src_3plls_p' [-Wunused-const-variable] > > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > > > > Looks like this variable was never used. Deleting it to remove the > > warning. > > Indeed, looks like it was dead when introduced in: > commit e44dde279492 ("clk: rockchip: add clock controller for rk1108") > > I don't see a pattern between when mux_pll_src_4plls_p vs > mux_pll_src_2plls_p is used, so it's not clear where or even if > mux_pll_src_3plls_p should be used. The possible sources for a clock really differ often, so there is no general rule on when to use which sources ... except looking it up in the soc manual. And I guess any possible conflict will turn up when someone wants to use a clock that currently may reference the wrong sources. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel