From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B86DC47077 for ; Thu, 11 Jan 2024 13:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l5pYIAYjdlG3tm9K2A83BwArxZUW3IZB7uYzOyWv2e4=; b=2iYvo5Cof5WUmj oieP5ZHgqUGqv0X1bdJ5ffyfyZ+85mFNK1ZO/5k8tBOdzDuwuR2yAXEEci8ZkzUrj6IIpH/Awlkhu 8Xyyg7kH2cFNReb11TcWwiFZjsEuYdRuNRD5YtphFDcKLgz9cExiWv4Ttjh6+IG0sGdtHtZ997CwZ 7y7c2v94yUDL89KCchy1yDKbMDZhB0db71jDM8E7T+DJsJo/gJ3IxskOKAxfTr7l1XvCBvav64u3M MtgN5WAU1bBXb7JDwRUiqO9j9OewaP/NMGgAZZTQ/uxKmlB11idAXyzntVD+GqDKJZ8anSV7pDuCZ IbOo+znUGtlAWrwCbiTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNv54-000AOE-1X; Thu, 11 Jan 2024 13:26:46 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNv50-000AMI-2i for linux-arm-kernel@lists.infradead.org; Thu, 11 Jan 2024 13:26:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1704979602; x=1736515602; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lc0mfrR0brTHHoM4aeTwhDwKfsnEdj9csKTdzY8eoBs=; b=D7GLyJRYCD+hQcnbrCiP42K8n10IPsibTeowGWfZm4tuKK2UMX2b07tF 3b3RMBcqKFXmSPgSPjWRwE6f2r4v1c1gYrekg+vAh6EIC4MSUAnqmAHpH jPMaq/6z045QRq09sl+ECtSTCGb6LU+u3aJFfsOO4EMcV7HLFLkCVr9Wx WhF4h++xadbd8DfMk2ZQoEgk2/gzYub26UMKaw2Rksjot7RzuB66cUK6i SK9fshkePoK6i+dWsumSj3Mhtl8Xp5nKAR0CxTRPeEnypj5nAHCa3NH5+ XX7/dvO5JJO8ggV00wj9eNtznEiYgy1JXJIHRGL743wJVjZaP9UsKkX3w g==; X-IronPort-AV: E=Sophos;i="6.04,186,1695679200"; d="scan'208";a="34852285" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 11 Jan 2024 14:26:36 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 1C4CF280075; Thu, 11 Jan 2024 14:26:36 +0100 (CET) From: Alexander Stein To: Conor Dooley Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Ulf Hansson , Marek Vasut , Pengutronix Kernel Team , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/5] dt-bindings: soc: imx93-media-blk-ctrl: Add LDB subnode into schema and example Date: Thu, 11 Jan 2024 14:26:36 +0100 Message-ID: <1985138.usQuhbGJ8B@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231024-reimburse-domain-893407e09833@spud> References: <20231020130019.665853-1-alexander.stein@ew.tq-group.com> <8331331.NyiUUSuA9g@steina-w> <20231024-reimburse-domain-893407e09833@spud> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240111_052643_290462_8758D854 X-CRM114-Status: GOOD ( 34.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Conor, Am Dienstag, 24. Oktober 2023, 11:08:56 CET schrieb Conor Dooley: > On Tue, Oct 24, 2023 at 08:30:16AM +0200, Alexander Stein wrote: > > Am Montag, 23. Oktober 2023, 18:37:29 CEST schrieb Conor Dooley: > > > On Mon, Oct 23, 2023 at 08:27:20AM +0200, Alexander Stein wrote: > > > > Am Sonntag, 22. Oktober 2023, 19:39:12 CEST schrieb Conor Dooley: > > > > > On Fri, Oct 20, 2023 at 03:00:15PM +0200, Alexander Stein wrote: > > > > > > Document the LDB bridge subnode and add the subnode into the > > > > > > example. > > > > > > For the subnode to work, the block control must scan its subnod= es > > > > > > and > > > > > > bind drivers to them, do not misuse either simple-bus or > > > > > > simple-mfd > > > > > > here. > > > > > > = > > > > > > Signed-off-by: Alexander Stein > > > > > > --- > > > > > > = > > > > > > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 44 > > > > > > +++++++++++++++++++ > > > > > > 1 file changed, 44 insertions(+) > > > > > > = > > > > > > diff --git > > > > > > a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk= -ct > > > > > > rl.y > > > > > > aml > > > > > > b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk= -ct > > > > > > rl.y > > > > > > aml > > > > > > index b3554e7f9e76..5ba66dfb0e05 100644 > > > > > > --- > > > > > > a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk= -ct > > > > > > rl.y > > > > > > aml > > > > > > +++ > > > > > > b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk= -ct > > > > > > rl.y > > > > > > aml> > > > > > > = > > > > > > @@ -24,6 +24,12 @@ properties: > > > > > > reg: > > > > > > maxItems: 1 > > > > > > = > > > > > > + '#address-cells': > > > > > > + const: 1 > > > > > > + > > > > > > + '#size-cells': > > > > > > + const: 1 > > > > > > + > > > > > > = > > > > > > '#power-domain-cells': > > > > > > const: 1 > > > > > > = > > > > > > @@ -46,9 +52,16 @@ properties: > > > > > > - const: csi > > > > > > - const: dsi > > > > > > = > > > > > > + bridge@20: > > > > > > + type: object > > > > > > + $ref: /schemas/display/bridge/fsl,ldb.yaml# > > > > > > + unevaluatedProperties: false > > > > > > + > > > > > > = > > > > > > required: > > > > > > - compatible > > > > > > - reg > > > > > > = > > > > > > + - '#address-cells' > > > > > > + - '#size-cells' > > > > > = > > > > > It seems to make little sense to me that these would become requi= red > > > > > when the bridge is optional. Is it valid to have one of these > > > > > media-blk-ctrls without the ldb subnode? > > > > = > > > > fsl,imx93-media-blk-ctrl privides several power-domains (DSI, CSI, > > > > ISI, > > > > PXP > > > > and LCDIF), currently unused. This series introduces the usage for > > > > LCDIF > > > > power domain. LDB is the LVDS display bridge. So there are several > > > > power > > > > domains which don't requires the usage of ldb. > > > > On the other hand I prefer consistency, so I opted to keep things > > > > similar > > > > to commit 1cb0c87d27dc. If it shall not be added here, it should be > > > > removed in > > > > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl= .ya > > > > ml > > > > as well. > > > = > > > IIRC the tooling will complain if you have an enabled node containing > > > #address-cells and/or #size-cells but no child nodes, so making > > > #address-cells or #size-cells required will cause problems. Looks like > > > the only user has the child node, so it didn't crop up yet. > > = > > I was not able to raise a warning with enabled media_blk_ctrl having > > #address- cells/#size-cells being set but no subnode. > > I don't have a strong opinion on this, but I prefer having both bindings > > as > > similar as possible. > = > The complaint is from dtc, possibly only at W=3D1: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" > property I was still not able to trigger this. But anyway this binding is for i.MX93 = MEDIAMIX Block Control. There is exactly one of this instance in the SoC. S= o = there is always the LVDS bridge included, thus the ldb subnode shall be add= ed. Given this IMHO #address-cells/#size-cells can be required. Best regards, Alexander -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel