From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45BA6C43603 for ; Fri, 13 Dec 2019 22:25:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DB4122527 for ; Fri, 13 Dec 2019 22:25:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sa2/DasQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DB4122527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1vSiORL6QzsPdpCWjEr7IX2voy9aho8JhJ0FPJLiyKs=; b=Sa2/DasQtDK1X9 DQwjNLbfC9mq1hqzauEqdRkKHyo3c2sk9Yl8xy28wQ5eE2QtEL/3xDcNGdjTR4wsT+TAUlhk7bj/z qN1dovHl53oUurJ+tKN05C+UyV6a/fgOJ4BBsbpiCirjt3JTqYLfGkY1eaqYCx1ljx6YMICmPPLz2 ZXxDXiCfYuU8OHLsEqmdBVp8LBzCGRJbDFralzotoCOzF6O6kkvQ+Cu2gvfrlPhjRCZktCn2dQwWK IxNcXCUNsiSqNQ68q5SWIHu4zYtVOd7SCV7QrfdRPr5SVZJ28eFLhW3uH81h8zkPfszzAySU5v7Oo z2Qzdtoo3WxeYpmBv+Pw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifpIS-0003y1-CN; Fri, 13 Dec 2019 18:04:12 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifpIP-0003xS-74; Fri, 13 Dec 2019 18:04:10 +0000 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifpIA-00036V-0l; Fri, 13 Dec 2019 19:03:54 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Daniel Vetter Subject: Re: [PATCH 06/10] drm/xrockchip: plane_state->fb iff plane_state->crtc Date: Fri, 13 Dec 2019 19:03:53 +0100 Message-ID: <1986448.RzC9sFZk56@diego> In-Reply-To: <20191213172612.1514842-6-daniel.vetter@ffwll.ch> References: <20191213172612.1514842-1-daniel.vetter@ffwll.ch> <20191213172612.1514842-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_100409_403000_2B01AD93 X-CRM114-Status: GOOD ( 13.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Daniel Vetter , Sandy Huang , DRI Development , linux-rockchip@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 13. Dezember 2019, 18:26:08 CET schrieb Daniel Vetter: > Checking both is one too much, so wrap a WARN_ON around it to stope > the copypasta. > = > Signed-off-by: Daniel Vetter > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org patch subject should be "drm/rockchip" without the x, otherwise Reviewed-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/dr= m/rockchip/rockchip_drm_vop.c > index d04b3492bdac..cecb2cc781f5 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -724,7 +724,7 @@ static int vop_plane_atomic_check(struct drm_plane *p= lane, > int max_scale =3D win->phy->scl ? FRAC_16_16(8, 1) : > DRM_PLANE_HELPER_NO_SCALING; > = > - if (!crtc || !fb) > + if (!crtc || WARN_ON(!fb)) > return 0; > = > crtc_state =3D drm_atomic_get_existing_crtc_state(state->state, crtc); > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel