From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 11/18] iommu: exynos: remove useless device_add/remove callbacks
Date: Thu, 23 Oct 2014 16:02:06 +0200 [thread overview]
Message-ID: <1987006.J2W7PED0yz@wuerfel> (raw)
In-Reply-To: <54477EDA.3060104@samsung.com>
On Wednesday 22 October 2014 11:54:34 Marek Szyprowski wrote:
> On 2014-10-22 11:26, Arnd Bergmann wrote:
> > On Wednesday 22 October 2014 11:15:00 Alban Browaeys wrote:
> >> Le mardi 16 septembre 2014 ? 13:54 +0200, Marek Szyprowski a ?crit :
> >>> The driver doesn't need to do anything important in device add/remove
> >>> callbacks, because initialization will be done from device-tree specific
> >>> callbacks added later. IOMMU groups created by current code were never
> >>> used.
> >>>
> >>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> >>
> >> The exyons iommu init fails if those are removed, that is it never reach
> >> init_done:
> >> 1. exynos_iommu_setup
> >> 2. - exynos_iommu_init
> >> 3. ---bus_set_iommu
> >> 4. ------ add_iommu_group
> >>
> >> that is (4) add_iommu_group returns ENODEV to bus_set_iommu, the latter
> >> doing so to exynos_iommu_init. Which thus error out before the init_done
> >> is set to true.
> > On a related note, I found that the exynos iommu driver does not check
> > for the presence of an exynos iommu before calling bus_set_iommu,
> > and this breaks multiplatform kernels.
> >
> > Please fix.
>
> For the time being please apply this patch:
> https://lkml.org/lkml/2014/8/5/163
>
> The proper solution will be applied when driver will be adapted to common of
> iommu support, which is still under discussion.
>
The patch looks good.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Can you send it to the iommu maintainer please?
Arnd
next prev parent reply other threads:[~2014-10-23 14:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 11:54 [PATCH v2 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 01/18] arm: dma-mapping: arm_iommu_attach_device: automatically set max_seg_size Marek Szyprowski
2014-09-24 17:06 ` Will Deacon
2014-09-25 10:43 ` Marek Szyprowski
2014-09-25 18:34 ` Will Deacon
2014-09-16 11:54 ` [PATCH v2 02/18] arm: exynos: bind power domains earlier, on device creation Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 03/18] drm: exynos: detach from default dma-mapping domain on init Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 04/18] clk: exynos: add missing smmu_g2d clock and update comments Marek Szyprowski
2014-09-22 12:09 ` Tomasz Figa
2014-09-16 11:54 ` [PATCH v2 05/18] ARM: DTS: Exynos4: add System MMU nodes Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 06/18] iommu: exynos: don't read version register on every tlb operation Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 07/18] iommu: exynos: remove unused functions Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 08/18] iommu: exynos: remove useless spinlock Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 09/18] iommu: exynos: refactor function parameters to simplify code Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 10/18] iommu: exynos: remove unused functions, part 2 Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 11/18] iommu: exynos: remove useless device_add/remove callbacks Marek Szyprowski
2014-10-21 10:59 ` Alban Browaeys
2014-10-22 9:15 ` Alban Browaeys
2014-10-22 9:26 ` Arnd Bergmann
2014-10-22 9:54 ` Marek Szyprowski
2014-10-23 14:02 ` Arnd Bergmann [this message]
2014-10-24 7:41 ` [PATCH] iommu: exynos: make driver multiarch friendly Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 12/18] iommu: exynos: add support for binding more than one sysmmu to master device Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 13/18] iommu: exynos: add support for runtime_pm Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 14/18] iommu: exynos: rename variables to reflect their purpose Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 15/18] iommu: exynos: document internal structures Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 16/18] iommu: exynos: remove excessive includes and sort others alphabetically Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 17/18] iommu: exynos: init from dt-specific callback instead of initcall Marek Szyprowski
2014-09-16 11:54 ` [PATCH v2 18/18] iommu: exynos: add callback for initializing devices from device tree Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1987006.J2W7PED0yz@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox