Re: [PATCH v1 1/2] media: dt-bindings: i2c: add Giantec GT97xx VCM

Krzysztof Kozlowski
2024-04-22T03:26:29Z

On 20/04/2024 03:18, Zhi Mao wrote:
> Add YAML device tree binding for GT9768 & GT8769 VCM,
> and the relevant MAINTAINERS entries.
>
> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

If there is going to be any new version, then:

> .../bindings/media/i2c/giantec,gt9769.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)

> +title: Giantec Semiconductor, Crop. GT9768 & GT9769 Voice Coil Motor (VCM)
> +
> +maintainers:
> + - Zhi Mao <zhi.mao@mediatek.com>
> +
> +description: |-

Drop |-

> + The Giantec GT9768 & GT9768 is a 10-bit DAC with current sink capability.
> + The DAC is controlled via I2C bus that operates at clock rates up to 1MHz.
> + This chip integrates Advanced Actuator Control (AAC) technology
> + and is intended for driving voice coil lens in camera modules.
> +
> +properties:
> + compatible:
> + enum:
> + - giantec,gt9768
> + - giantec,gt9769
> +
> + reg:
> + maxItems: 1
> +
> + vin-supply: true
> +
> + vdd-supply: true
> +
> +required:
> + - compatible
> + - reg
> + - vin-supply
> + - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +

Drop blank line

> + i2c {

Best regards,
Krzysztof