Re: [PATCH v1 1/2] media: dt-bindings: i2c: add Giantec GT97xx VCM

Krzysztof Kozlowski
2024-04-22T03:18:34Z

On 22/04/2024 03:49, Zhi Mao (毛智) wrote:
> Hi, Krzysztof
>
> Thanks for your feedback.
>
> On Sat, 2024-04-20 at 13:21 +0200, Krzysztof Kozlowski wrote:
>>
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>> On 20/04/2024 03:18, Zhi Mao wrote:
>>> Add YAML device tree binding for GT9768 & GT8769 VCM,
>>> and the relevant MAINTAINERS entries.
>>>
>>> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
>>> ---
>>
>> Sorry, there was v1. Please do not send same versions twice. BTW, use
>> patman or b4 for your submissions if versioning is tricky.
>>
> Sorry, it make you confused.
> As we create the version number from "0" base, they are supposed as

No, we don't. Use the tools if you cannot get it right.

> v0/v1/...
> So, the previouse version is:
> v0:
> https://lore.kernel.org/all/20240410104002.1197-1-zhi.mao@mediatek.com/
>
> If necessary, I can send a new v2 patch.
> Do we need do it?

When you look through the window outside and you see cars passing by, do
you count them from 0? Car drivers, I see 0 car. Next car drivers, I see
1 (first) car?

Please use b4 to version this properly.

No need for v2. I will get to review this.

Best regards,
Krzysztof