From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A354BC433EF for ; Tue, 1 Feb 2022 10:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JJ0NjoV0tbJ80iO3uuDfMbyFzEKbWJybqzC5//9B+Nk=; b=GHFzTD/WvpmqYZ i1JbEMl3+lCV3vQf6oOBftcjotXFOsesH8tTMfh6Je0zarCkgAyiuE5eiCdV0dCrZ3nu6Rj9Vezkc zzogZb0EddPfq9Th/ewFpx2yBIOfj5Pa6O8RLOSJW5iFBvUPMwy92TWfw3dIu1guEX0A/01bQP/Dk bMMQan/e6PwjwhFR5kweY0x0UBKrYWd1NrFpCqx7XJ53b8Iwapf8zC+EZzrkeTrZXxYcXRGZZ4Af+ AdoUynjRLRs1Yf53zCB1IuAaWI/fttsZk3jiIdMEShmFLOHQTi9pcctkkoJoeJXT2Q0Y+QsKXeyC/ EyZAkpZSzQnxSknVsB4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEqDs-00BiRP-BI; Tue, 01 Feb 2022 10:17:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEqDo-00BiQI-T1 for linux-arm-kernel@lists.infradead.org; Tue, 01 Feb 2022 10:17:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643710631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1rSMPibeU2/x9y1HGJmwIBX0MF6r0zdDZVn4ZSeYeqM=; b=PuFfyHYgCQSmyhPHrMQNwnlKp5H7K8rY8AzOjQqB2kvIF2a0QK4gNYXEQjQsS9MDuqFGbi kD7VZOz/jIHqHbPWlOmi2qNNQ07GdZRdmvMnRtAhOSSvyfQLRzrLTdJY2qJfDaVz+1uRlR GKua/dxgobIE/hlmODU5BfzMH9Vopms= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-459-fyb1meBdP9Cv7kQ5UUK0Ow-1; Tue, 01 Feb 2022 05:17:05 -0500 X-MC-Unique: fyb1meBdP9Cv7kQ5UUK0Ow-1 Received: by mail-wr1-f69.google.com with SMTP id x4-20020adfbb44000000b001d83e815683so5796442wrg.8 for ; Tue, 01 Feb 2022 02:17:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=1rSMPibeU2/x9y1HGJmwIBX0MF6r0zdDZVn4ZSeYeqM=; b=Jdkptl1ApbaLS4pUhr14m65Ln5rsR6cMW06IAnGk8Xfdqdc+vgKdhGHj6rHlwAycN0 Cn6WXzGZtEZEnaeHcJ6vjRHbLZ9IpGj7FiwW5yeb86bhytSlUu4UPjNAOh0M5R8+VMR8 QjM0EsEJSXy/kruKMpL6KAxXj/FwZJkC1A58fib6RrqNf7N0Kzrhd/pGgYDAXOjXw8uK SyZBeyYlBWJiiMne/OpSYjW4b6K0Zs0CVKeVqzk1rD7CHBsY9oKIiktcxfK3b4QklkP/ hk+qkc4fEttmF9pmmh4BvpqXxbSp4pVRIKhm2X/N2/bV/fS39R0RUtW8KqDBU7LJYECB i1ZQ== X-Gm-Message-State: AOAM533UBSfwYn8yEUqvcJAdJ8kgOBj5IUDChAv6YZOCAVLjtCdCGFLb bi7EiXlj9XbFJfeWdoq5TP89zNvEJbamIbXw4+LvuhEzGqkWjGIm4A5IwnzUSj0XG+6G7XUIR23 K+lZOZ5akVMXmsUTUvioPzcOkn8R2R74DSUM= X-Received: by 2002:adf:f54d:: with SMTP id j13mr20271546wrp.596.1643710624127; Tue, 01 Feb 2022 02:17:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJwW9cnbVOET7eNHaJPpg1tW+PwHgA1p1BZnH/wRYWshALkMr1QDZjc+KGZLPaL4fKlWIFXhpA== X-Received: by 2002:adf:f54d:: with SMTP id j13mr20271503wrp.596.1643710623856; Tue, 01 Feb 2022 02:17:03 -0800 (PST) Received: from ?IPV6:2003:cb:c711:ba00:67b6:a3ab:b0a8:9517? (p200300cbc711ba0067b6a3abb0a89517.dip0.t-ipconnect.de. [2003:cb:c711:ba00:67b6:a3ab:b0a8:9517]) by smtp.gmail.com with ESMTPSA id p2sm1600619wmc.33.2022.02.01.02.17.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Feb 2022 02:17:03 -0800 (PST) Message-ID: <19907f0c-4d83-4d85-4233-f4ee727574a0@redhat.com> Date: Tue, 1 Feb 2022 11:17:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH RFC v1] drivers/base/node: consolidate node device subsystem initialization in node_dev_init() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Greg Kroah-Hartman , Michal Hocko , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Yoshinori Sato , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Rafael J. Wysocki" , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org References: <20220128151540.164759-1-david@redhat.com> <3be2e20c-f0b9-c080-adf4-b0e17c046eb0@redhat.com> <20220131094041.GA15392@linux> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220131094041.GA15392@linux> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_021713_022971_4E27210E X-CRM114-Status: GOOD ( 21.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31.01.22 10:40, Oscar Salvador wrote: > On Mon, Jan 31, 2022 at 08:48:54AM +0100, David Hildenbrand wrote: >> Hi Oscar, > > Hi David :-), > >> Right, and the idea is that the online state of nodes (+ node/zone >> ranges) already has to be known at that point in time, because >> otherwise, we'd be in bigger trouble. > > Yeah, I wanted to check where exactly did we mark the nodes online, > and for the few architectures I checked it happens in setup_arch(), > which is called very early in start_kernel(), while driver_init() > gets called through arch_call_rest_init(), which happens at the end > of the function. > > I am not sure whether we want to remark that somehow in the changelog, > so it is crystal clear that by the time the node_dev_init() gets called, > we already set the nodes online. > > Anyway, just saying, but is fine as is. I'll adjust the first paragraph to: ... and call node_dev_init() after memory_dev_init() from driver_init(), so before any of the existing arch/subsys calls. All online nodes should be known at that point: early during boot, arch code determines node and zone ranges and sets the relevant nodes online; usually this happens in setup_arch(). Thanks! -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel