From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board
Date: Wed, 08 Oct 2014 17:20:42 +0200 [thread overview]
Message-ID: <1998495.eXa2FjeVGo@wuerfel> (raw)
In-Reply-To: <CAPDyKFowKK2UbwQ3uUmX7yzgsyFVxQ+sKb=dh+a0_T5K4agYGw@mail.gmail.com>
On Wednesday 08 October 2014 14:50:46 Ulf Hansson wrote:
> On 8 October 2014 14:07, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Thursday 02 October 2014 20:16:44 Ulf Hansson wrote:
> >> On 2 October 2014 18:10, Bartlomiej Zolnierkiewicz
> >> <b.zolnierkie@samsung.com> wrote:
> >> > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc
> >> > and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device
> >> > tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is
> >> > not specified. Fix it.
> >> >
> >> > Without this patch:
> >> > - "mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators"
> >> > patch causes a SD card detection to fail
> >> > - "mmc: dw_mmc: Support voltage changes" patch causes a boot hang
> >> >
> >> > This patch fixes both above problems.
> >> >
> >> > Suggested-by: Doug Anderson <dianders@google.com>
> >> > Cc: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> >> > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> >> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> >> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> >>
> >> Unless it causes a bunch non-trivial conflicts, I suggest we take this
> >> through my mmc tree to not break bisectability.
> >
> > Have you tried if it conflicts with arm-soc? If not,
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> In conflicts, but it's trivial to fix it.
>
> Since it actually fixes a regression which is inserted from my mmc
> tree, I thought it makes sense to take it through here. Anyway, the
> decision is yours.
>
Why does it cause a regression though? Does this mean you are breaking
any boot with an old DT file and a new kernel? That would be very
bad, the driver is supposed to keep working with an existing dtb.
Arnd
next prev parent reply other threads:[~2014-10-08 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 16:10 [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board Bartlomiej Zolnierkiewicz
2014-10-02 16:19 ` Doug Anderson
2014-10-02 16:39 ` Bartlomiej Zolnierkiewicz
2014-10-02 16:45 ` Doug Anderson
2014-10-02 17:24 ` Bartlomiej Zolnierkiewicz
2014-10-06 16:51 ` Doug Anderson
2014-10-08 0:19 ` Jaehoon Chung
2014-10-08 9:31 ` Ulf Hansson
2014-10-02 18:16 ` Ulf Hansson
2014-10-08 12:07 ` Arnd Bergmann
2014-10-08 12:50 ` Ulf Hansson
2014-10-08 15:20 ` Arnd Bergmann [this message]
2014-10-08 15:29 ` Doug Anderson
2014-10-08 18:28 ` Arnd Bergmann
2014-10-09 8:46 ` Ulf Hansson
2014-10-09 11:41 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1998495.eXa2FjeVGo@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).