From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2BCCC433ED for ; Fri, 7 May 2021 01:34:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B86E61106 for ; Fri, 7 May 2021 01:34:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B86E61106 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References:In-Reply-To: Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2CylAFkgZoqIFvwVHHVCJ6CHyFNqSlqEfpl46JJ0Ins=; b=RzMF2QsAL1SVMTFzpoTMW6YMK ckFjjA3v9nXA51995u5etbrqSiCvLz0kxE8ubacmODeCgL8vvPmW/ANgFVLVYW2X/5MijxWvc8ZEY EZejyruWpQZDL+IKJVQjH2SrOUzT5/E5+cXbqfEpLjr5mAREsViWUluTw37TKw09SeI2O8oqe2JH7 sn0uRa8JB6AU4h4oceOdq/xNoG2jrEF0OhRDVCq8+34x28wfGZLaJTSA7jP928x+UwcJeH3uNn76F dCE6QcbTI+NaQWepJmLpHMQzkRfSyam5o5+fBuFU4EHGCS6mp/J7U/lVbY1/ogH1NCTT8nikNgLCt PmW59zsww==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lepMk-005m6y-Li; Fri, 07 May 2021 01:33:18 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lepMh-005m6J-43 for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 01:33:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+6WcnuLbg5MQPQ1CNTZXV3RZb2wmRjjrGjFSoRIlm5c=; b=tyFubhdx5/g5To83bs3lwy6H2Q PX0FjdHjN/59z22TWOVhUc4jTW5epEeWIwkr0Ggfk8pUyP9tFtb0aWNDGfZHn5oEA4Lxhwj5d7IWH IR8H80Ir84HvGa5ihma3KbnCc+ku54tDoeVYBOwzgn3jxP3YwC0EJmzP6fMts4MJoOK+6j6GPV/CE iQpPOe4YWws7f/DQJ4s4vPRIh+/mUre2I9eWScNlgSabRwzN2LoA7Q2A3SqobAfEBM6T7AExLu2DL 8tzPtS53e0xv1dHdHuRP8y4ehvIRTx4KLDmgGIzQclVLv319V9CmTDeXBMBBj139vsGVwzX4gzIbZ 1uKDBTOw==; Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lepMe-006VVB-Ig for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 01:33:13 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id F0D01580961; Thu, 6 May 2021 21:33:05 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Thu, 06 May 2021 21:33:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=+6WcnuLbg5MQPQ1CNTZXV3RZb2wmRjj rGjFSoRIlm5c=; b=mM4BlZeQY4pW7UnBanVkm1/3Xe2AMYufr/nsRKlSNNB5fxB Mxl1jABk8kV4jz6Ch8PZbQbF8qnTiv+4l01e10azRU6JchcfFpEwUu6LNXwfTZ9b PM1H+Q8IshrfYR1LZpAhD9LlCHUPSHx+SNzk1iklCZMUS/Hc8ujdS6uiXRryf7bP CIz3o4X0HbmTUTNSkPTdDeZtwJYy2DQVvVbaWg2ZKE86td8uHa0iWIUz8brta8jE FUd+YYXJSa1Q52SKI45Q+7ZyWhntc4aT4F/yS4rT+jimtQO6cTLl2NJNmBJEu4Ph bd42sSFZCdwyIl/D2exko6hdv/NXVv16FUTZvMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+6Wcnu Lbg5MQPQ1CNTZXV3RZb2wmRjjrGjFSoRIlm5c=; b=r63mby3ej96oPK2tiYm30r H1fbdvfDfbGWMYsUZY0+gxQkqtHizU//VMkAR8UGgnDDBf72aLJHDULp+4FRqZr9 jqKmMRyHqA3t3KJNEVExb5Azir2YT4ZrtbjuLD2rZabOeg8ro9akHWxKaQgb2gYM aNWwaaU7xeAJXF8S4MV/DIM4sgrU/fQAl2injk09sl6FpIU+pcGJii06zqjDj92D kpVmKvvRzUpXLWMGJezr7EvnPZ5DYTEp6Ustq/ulP5IqPZHNjsORf0vtSpgC133X QtMNnDdAhn3gWbdUHWMoPHGDSTZlZKlfIlEKT7t99Ki1YncrBMWJSsSECayPH/dQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeguddggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhepuddttdekueeggedvtddtueekiedutdfguedutdefieeuteefieelteet vddthfeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id F415FA00079; Thu, 6 May 2021 21:33:03 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-448-gae190416c7-fm-20210505.004-gae190416 Mime-Version: 1.0 Message-Id: <19a81e25-dfa1-4ad3-9628-19f43f4230d2@www.fastmail.com> In-Reply-To: <20210506102458.GA20777@pengutronix.de> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-6-steven_lee@aspeedtech.com> <20210506102458.GA20777@pengutronix.de> Date: Fri, 07 May 2021 11:02:29 +0930 From: "Andrew Jeffery" To: "Philipp Zabel" , "Steven Lee" Cc: "Ulf Hansson" , "Rob Herring" , "Joel Stanley" , "Adrian Hunter" , "Ryan Chen" , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" , "Hongwei Zhang" , "Ryan Chen" , "Chin-Ting Kuo" Subject: =?UTF-8?Q?Re:_[PATCH_v3_5/5]_mmc:_sdhci-of-aspeed:_Assert/Deassert_reset?= =?UTF-8?Q?_signal_before_probing_eMMC?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_183312_703528_B4B6431D X-CRM114-Status: GOOD ( 13.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 6 May 2021, at 19:54, Philipp Zabel wrote: > Hi Steven, > > On Thu, May 06, 2021 at 06:03:12PM +0800, Steven Lee wrote: > > + if (info) { > > + if (info->flag & PROBE_AFTER_ASSET_DEASSERT) { > > + sdc->rst = devm_reset_control_get(&pdev->dev, NULL); > > Please use devm_reset_control_get_exclusive() or > devm_reset_control_get_optional_exclusive(). > > > + if (!IS_ERR(sdc->rst)) { > > Please just return errors here instead of ignoring them. > The reset_control_get_optional variants return NULL in case the > device node doesn't contain a resets phandle, in case you really > consider this reset to be optional even though the flag is set? It feels like we should get rid of the flag and leave it to the devicetree. I'm still kind of surprised it's not something we want to do for the 2400 and 2500 as well. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel