From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 966B2C3ABA3 for ; Fri, 2 May 2025 11:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Tz0Qyi+rYLdiyL94yfUmQf0GAPdsB4sjN3Vr+h5NUMw=; b=aOgoPwqXk4Wd+IftieRl+M4Rls Oo2QsTG1cggfWuCS0xs1QLNDwKhC5PTUDqvbDOx+v+FhT0ofriAE+Us6jDkraOmZknu5l8zU9y41U qy0tn418P/YiV4fIt/ktmN2MBv/D0W6JFcn4VTrUYXuOXOcq4hAdiWFPE3dm7kMsYo/WmNXXdN38X bUIalgSDqBUhfw5Sk6S2t/6Usn8SmGsGwEyOnY+utoLU2zk23C3/vIQQ/vOhfwG0enaudAm4kPnmK j0f1uz8hLNOu3lT9N3HKaFXuNc4UN1x9j+7QNs3MYf1nc2qXwfkFetvmVBoKtmh0uVvCrjpkc9kMD mNs4rToA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAoaL-00000001meE-3tgu; Fri, 02 May 2025 11:29:41 +0000 Received: from lelvem-ot02.ext.ti.com ([198.47.23.235]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAoGy-00000001joP-0BG1 for linux-arm-kernel@lists.infradead.org; Fri, 02 May 2025 11:09:41 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 542B9UKj389669 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 2 May 2025 06:09:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1746184170; bh=Tz0Qyi+rYLdiyL94yfUmQf0GAPdsB4sjN3Vr+h5NUMw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=NirENkiQRPkeD/oD+xACE05qKJzX4WNXrM2HgkHdb6nSm78hCRUW+iwVZ3IP4u9mS rFdkMyrUnQlr8YUUlGapbbtEiTjKo1I91LjamguOPa1GBXTl3X4OI/srLjl2o50AaN G4wutEZjEYRTzR+oO/kuiPNbUhAXtDzvSqwxOkc8= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 542B9UTB017423 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 2 May 2025 06:09:30 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 2 May 2025 06:09:30 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 2 May 2025 06:09:30 -0500 Received: from [10.249.134.35] ([10.249.134.35]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 542B9OFu058493; Fri, 2 May 2025 06:09:25 -0500 Message-ID: <19dd4cc6-c110-4c2d-b725-5e7bd1a4226c@ti.com> Date: Fri, 2 May 2025 16:39:23 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/4] arm64: dts: ti: k3-am62x: Add required voltage supplies for IMX219 To: Devarsh Thakkar , , CC: , , , , , , , , , , , , References: <20250429154133.3377962-1-r-donadkar@ti.com> <20250429154133.3377962-3-r-donadkar@ti.com> Content-Language: en-US From: "Donadkar, Rishikesh" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250502_040940_182360_215AE059 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02-05-2025 13:45, Devarsh Thakkar wrote: > On 29/04/25 21:11, Rishikesh Donadkar wrote: >> The device tree overlay for the IMX219 sensor requires three voltage >> supplies to be defined: VANA (analog), VDIG (digital core), and VDDL >> (digital I/O). >> >> Add the corresponding voltage supply definitions to avoid dtbs_check >> warnings. >> > On a side-note device-tree overlay requiring these voltages is an > implied reason, it's mainly because the schematics mention that and > bindings want to capture same topography in device-tree too. > > So maybe good to mention that and share schematic link too in commit > message : > > https://datasheets.raspberrypi.com/camera/camera-module-2-schematics.pdf > > With these changes, feel free to add, > > Reviewed-by: Devarsh Thakkar Hi Devarsh, Thanks for the review. I will do this in the next revision. > > Regards > Devarsh > >> Signed-off-by: Rishikesh Donadkar >> --- >> .../boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 31 +++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso >> index dd090813a32d6..149c59c071823 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso >> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso >> @@ -15,6 +15,33 @@ clk_imx219_fixed: imx219-xclk { >> #clock-cells = <0>; >> clock-frequency = <24000000>; >> }; >> + >> + reg_2p8v: regulator-2p8v { >> + compatible = "regulator-fixed"; >> + regulator-name = "2P8V"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + vin-supply = <&vcc_3v3_sys>; >> + regulator-always-on; >> + }; >> + >> + reg_1p8v: regulator-1p8v { >> + compatible = "regulator-fixed"; >> + regulator-name = "1P8V"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + vin-supply = <&vcc_3v3_sys>; >> + regulator-always-on; >> + }; >> + >> + reg_1p2v: regulator-1p2v { >> + compatible = "regulator-fixed"; >> + regulator-name = "1P2V"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + vin-supply = <&vcc_3v3_sys>; >> + regulator-always-on; >> + }; >> }; >> >> &main_i2c2 { >> @@ -40,6 +67,10 @@ ov5640: camera@10 { >> >> clocks = <&clk_imx219_fixed>; >> >> + VANA-supply = <®_2p8v>; >> + VDIG-supply = <®_1p8v>; >> + VDDL-supply = <®_1p2v>; >> + >> reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>; >> >> port {