From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05CF8C87FD3 for ; Fri, 8 Aug 2025 13:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i5QrXCqm+pifeK6qyJpbRjapusOqLRIsZv1SdbjtFgM=; b=qKZ81VQcrFOMm0UUPwYJi2G8ve f7LERXAyeh6cVN/yEr6h1dHhe3zPXx/oD7hwpJDE2fBiz80RhqG/5aDnSRXHDQRlMSFUOlNISLsao Cjx562DR0LQb475/9FpZd3UIaqUxfitB4/RUv+9qZsY4U/7PNiBX0AV26lWYtqRUOS3fOEdoFPsAf tfbBFm4hA5IAm9vzZ7H1XAGcTH/AG65Qy3v7sUCGCkzf3CXA/FH7hdbOWmkIfv3NC1cWX5e482hR7 aCMxZ0Hw/FhQN+6dxgD3fNqH8RkzfxbOZN79CLXPhjR1d386022D3N4D4asqYhG4empn7km6wq4eE hYxrOoqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ukN8D-00000002v5f-3cyp; Fri, 08 Aug 2025 13:27:37 +0000 Received: from lelvem-ot01.ext.ti.com ([198.47.23.234]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ukN5g-00000002unR-1G0g for linux-arm-kernel@lists.infradead.org; Fri, 08 Aug 2025 13:25:01 +0000 Received: from fllvem-sh04.itg.ti.com ([10.64.41.54]) by lelvem-ot01.ext.ti.com (8.15.2/8.15.2) with ESMTP id 578DOWEo602038; Fri, 8 Aug 2025 08:24:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1754659472; bh=i5QrXCqm+pifeK6qyJpbRjapusOqLRIsZv1SdbjtFgM=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=oPXgVpUky4MiMEuzV1gaxhmE2P+CcZTLHNyN2yEibVfjZ/F5eY7MQ2SGoxsMEMgws CDyKh2OOKPW2sGr69AInzj4bQcGNAFUnX+p0uOROD4gmIoO7VqqklFxjDyxJgsHdUF 6fXLAC6SNg3YueNO8Qt6voOsWnMUjzmbCnldmJ0M= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by fllvem-sh04.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 578DOVfQ1612002 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Fri, 8 Aug 2025 08:24:31 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Fri, 8 Aug 2025 08:24:30 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Fri, 8 Aug 2025 08:24:30 -0500 Received: from [10.249.145.16] ([10.249.145.16]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 578DONpB3102888; Fri, 8 Aug 2025 08:24:23 -0500 Message-ID: <19dd9aa9-43c6-4483-9cdf-f297e41ecdec@ti.com> Date: Fri, 8 Aug 2025 18:54:22 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] drm/tidss: Fixes data edge sampling To: Tomi Valkeinen , Louis Chauvet CC: , Jyri Sarha , Tomi Valkeinen , , , , , , Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , "Rob Herring" , Krzysztof Kozlowski , "Conor Dooley" , Sam Ravnborg , Benoit Parrot , Lee Jones , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , References: <20250730-fix-edge-handling-v1-0-1bdfb3fe7922@bootlin.com> <1951ecfe-d080-464c-8441-f5400f535495@ideasonboard.com> Content-Language: en-US From: devarsh In-Reply-To: <1951ecfe-d080-464c-8441-f5400f535495@ideasonboard.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250808_062500_418894_97D84202 X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tomi, Louis, On 07/08/25 18:51, Tomi Valkeinen wrote: > Hi, > > On 30/07/2025 20:02, Louis Chauvet wrote: >> Currently the driver only configure the data edge sampling partially. The >> AM62 require it to be configured in two distincts registers: one in tidss >> and one in the general device registers. >> >> Introduce a new dt property to link the proper syscon node from the main >> device registers into the tidss driver. >> >> Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display SubSystem") >> --- >> Cc: stable@vger.kernel.org >> >> Signed-off-by: Louis Chauvet > > I understand why you call this a fix, but I think this is not really a > fix. From looking at the patches, my understanding is that for DPI > outputs we have always only supported certain clock/data edge. I don't think driver makes a distinction between supported/unsupported or errors out in case it is run with "different" clock/data edge panel (for e.g DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE is set per the panel configuration). Instead it tries to program the VP registers per the DRM_BUS_FLAG* getting passed by framework per the connected panel and gives an incorrect behavior if those are different than defaults since those settings are not sufficient for these displays and instead extra MMR register settings are also required. So this > series is adding a new feature to the driver. > I think it is a bug due to above mentioned behavior, and good to have a Fixes tag. Regards Devarsh