From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 817FCC5478C for ; Tue, 27 Feb 2024 11:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y7KL0i4E1oZg1YU5DbCqEg1Br/0T5n/J15g8PHyvrOU=; b=aeOgrmH+EjVlLo RvhdQg/ltYiJbLU0eN6sgBJYq/HUo/glOh8m4h4gpnnHQimkprYYYGYS9V4q4vC1Ymm+v4CsSK6nx DnWj1NY7lyREZU+WvH+bxHYr91o1Uvv7W3WV1fsq2C8+xRWCxUgu5PJIs+7U9JyeCTTCd9KQR9PMT X2225MB6uJkFJaFRL9vcGQNlweFoeMaNlCnEXxE52L4b8H9D7r1OvIKmXQowHP1JU8ZZlpTk/ubt+ pNXRW7exhp5MlIt72Dp+qG0SbhzqscS/N7+UkpEM1y6V6vKYG3DjMiC4wMRV+Q0p7w3rTyjswcNW6 bK/3JCLqiktkOvdHbypQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1revvO-00000004zkA-3cKc; Tue, 27 Feb 2024 11:47:06 +0000 Received: from mta-65-226.siemens.flowmailer.net ([185.136.65.226]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1revvK-00000004zht-3ZpV for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 11:47:04 +0000 Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 2024022711465056f5bb1577a19e06fd for ; Tue, 27 Feb 2024 12:46:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=diogo.ivo@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=O9MtN3amMckTj4yG25B4boLtlatA/jeZ6MoIj8UNgmM=; b=DFSuvy0PeMOp5IfO+EgBY0uFGeJrupHUxfOc/+NN3b5mmjwoDEvIajHlSQdkWFaEyQdjZo mmC6zb17Tpz8qWXc3zYiBU7XY2y8TMQ9/RFkmzEzkVGETfOIyvFNA3/W4RPkDiKbo2+EHSrW 95NAkRoAdY1ejsNfNf2rAyenQWjFg=; Message-ID: <1a2c7175-e7f5-42b7-9a3e-dd727eed259a@siemens.com> Date: Tue, 27 Feb 2024 11:46:48 +0000 MIME-Version: 1.0 Subject: Re: [PATCH net-next v3 04/10] net: ti: icssg-prueth: Add SR1.0-specific configuration bits Content-Language: en-US To: Roger Quadros , danishanwar@ti.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Cc: jan.kiszka@siemens.com References: <20240221152421.112324-1-diogo.ivo@siemens.com> <20240221152421.112324-5-diogo.ivo@siemens.com> <5337e08b-a4dd-46d0-bc2e-a30b82aeeb15@kernel.org> From: Diogo Ivo In-Reply-To: <5337e08b-a4dd-46d0-bc2e-a30b82aeeb15@kernel.org> X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1320519:519-21489:flowmailer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_034703_471890_18892DD8 X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/26/24 17:23, Roger Quadros wrote: > Hi Diogo, > > On 21/02/2024 17:24, Diogo Ivo wrote: >> Define the firmware configuration structure and commands needed to >> communicate with SR1.0 firmware, as well as SR1.0 buffer information >> where it differs from SR2.0. >> >> +/* SR1.0 defines */ >> +#define PRUETH_MAX_RX_FLOWS_SR1 4 /* excluding default flow */ >> +#define PRUETH_RX_FLOW_DATA_SR1 3 /* highest priority flow */ >> +#define PRUETH_MAX_RX_MGM_DESC 8 >> +#define PRUETH_MAX_RX_MGM_FLOWS 2 /* excluding default flow */ >> +#define PRUETH_RX_MGM_FLOW_RESPONSE 0 >> +#define PRUETH_RX_MGM_FLOW_TIMESTAMP 1 > > Should we add suffix _SR1 to all SR1 specific macro names? >> +#define ICSSG_SHUTDOWN_CMD 0x81010000 >> + >> +/* SR1.0 pstate speed/duplex command to set speed and duplex settings >> + * in firmware. >> + * Command format: 0x8102ssPN, where >> + * - ss: sequence number. Currently not used by driver. >> + * - P: port number (for switch mode). >> + * - N: Speed/Duplex state: >> + * 0x0 - 10Mbps/Half duplex; >> + * 0x8 - 10Mbps/Full duplex; >> + * 0x2 - 100Mbps/Half duplex; >> + * 0xa - 100Mbps/Full duplex; >> + * 0xc - 1Gbps/Full duplex; >> + * NOTE: The above are the same value as bits [3..1](slice 0) >> + * or bits [7..5](slice 1) of RGMII CFG register. >> + */ >> +#define ICSSG_PSTATE_SPEED_DUPLEX_CMD 0x81020000 >> + > > How about bunching all S1.0 related changes at one place in this file? Both suggestions sound good, I'll add the missing _SR1 suffixes and move things together down in the file for v4. Best regards, Diogo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel