From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D16A6E7849A for ; Mon, 2 Oct 2023 06:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x7DlKrx8EHM5EdtRzzN+2cebVJtEAU1kZKWi7zlbr+Q=; b=GHwoU6DTRQN82F JlJujxydIyzuLNFSphjohPTPzi9gv6oZDu9KYUdC5Lx3c2Y3gM4RRlPOhgaxXpqQeGVR5xkibMp1v b++HWcKa9QQ2KnftSieHCP1rd0liFkOTx8xYxv6eaQatoA7Gl0fBOmt5ayaFvSgLfw+WXO1oKFoQu GeprlGPZ2oTT+cAt7EKCPh6EC+UwXDAWvEvDZxdkR1e1R9cGYvv6uK0zmmSCn7QFQGtJk9lZkVuLC VWD+oUrI3Lf5+WDMLFfr/pk+nv5EGiOZZ2hV9+lVRC+5VSwcEU26adwss/PN4+xgXPfvOFH7CZwmg DJkGFL8xpP4I116QfhhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnC8C-00C0j2-1p; Mon, 02 Oct 2023 06:10:12 +0000 Received: from mail-co1nam11on2062f.outbound.protection.outlook.com ([2a01:111:f400:7eab::62f] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnC88-00C0iE-1I for linux-arm-kernel@lists.infradead.org; Mon, 02 Oct 2023 06:10:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AuexrXL3aZS4TY6JSRFwSzyC6iYrbfMMUnTazt2nK7T4Fi5RPBEhggdx2dsfsGpj4vEl1BXw8wokhDQwHWhHOAdwCJ8EkuSM0DeE8o8lEo0yDEtU6dHYV0A0I/n/ahuSMTJOv5KC+/hiHiItEmT0ZI6ufRM6+wVTxYWVdzLoKxeA6dsXFUNqU7kMOYUYh2WPWtlkCdVe1zPZDjhZcyxUZRfwxM5OUpYCtcq5qqYyPCbdeA2I4/tnruNZax6TxJ4KwU2WonQc2kne8t9xMfPLPGcfI8gipdPIsdQxWgYXZau6VGPIdVXvprGbWiPQkflS40T8fzI09aHI7Mebivbh6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qqrmds45QYxFCicZxy83HlE8rojSX9pcqkTeHnbpH90=; b=djVNAkgzpbTpyEkX1+9A15cej/FGfsZmTljuG1MINeXYMWkQFdqGfZZ1+krFweCZpPo7huJNXeUmonhoNptyDz/yyBPzMSvbEzkJH/vKa8x/yg4xx8Pd8PmL+uOX6yKbor6FOjNrWsIjAQ2GV29sY5cYy8ErQguh6paY3ICmt2XKQB8FyZ5jpok3nZWigFjSEA7e8ih4pv/fGAMt/IaRn0FwAn1WPKXFZ+U12evcmfochxd+TLK2crz0JR4FS3fVyRnniHwOYGGFpZsbnFiGmAkoo6pAl57LkoL14l+SYVHRbpbuaAlPGXzplmP080jcmaQI9u+qAlZvCo7dulra8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qqrmds45QYxFCicZxy83HlE8rojSX9pcqkTeHnbpH90=; b=DjrC3ob9BeVTActodb3Gq4gKfSM7AgoZJtVwp8JkjylKyf7O2OzFFedc0M6miJj7Ba0Qg6IBOB8AZQk7PX0y7628FoJH+CODXwK2OyMLuT2wndeoBKMehoaAV5Q+jpuTOOErhctZKQyV/OCp7BTUOWnoRJbmo5Pd2TOsOHQp2Oc= Received: from MW4PR04CA0373.namprd04.prod.outlook.com (2603:10b6:303:81::18) by CH2PR12MB4956.namprd12.prod.outlook.com (2603:10b6:610:69::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.28; Mon, 2 Oct 2023 06:09:53 +0000 Received: from CO1PEPF000044F5.namprd05.prod.outlook.com (2603:10b6:303:81:cafe::a7) by MW4PR04CA0373.outlook.office365.com (2603:10b6:303:81::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.29 via Frontend Transport; Mon, 2 Oct 2023 06:09:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F5.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6838.14 via Frontend Transport; Mon, 2 Oct 2023 06:09:53 +0000 Received: from [192.168.137.2] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 2 Oct 2023 01:09:49 -0500 Message-ID: <1a38b6bf-00ef-4ada-a9a7-8dff5c3a1934@amd.com> Date: Mon, 2 Oct 2023 08:09:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] drivers: soc: xilinx: add check for platform To: Greg KH , Jay Buddhabhatti CC: , , , , , , , , , , , , References: <20230929105558.11893-1-jay.buddhabhatti@amd.com> <20230929105558.11893-4-jay.buddhabhatti@amd.com> <2023093034-spiny-diagnoses-3da7@gregkh> Content-Language: en-US From: Michal Simek Autocrypt: addr=michal.simek@amd.com; keydata= xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+ FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/ If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/ y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3 3i3l5DA= In-Reply-To: <2023093034-spiny-diagnoses-3da7@gregkh> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F5:EE_|CH2PR12MB4956:EE_ X-MS-Office365-Filtering-Correlation-Id: d514ae5a-de19-4ca4-3123-08dbc30e31b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vg9+r0aGwxbideR9hQe3hup9LUCfIMnufLx+ncGjucsP+XNPgai4PHVL9Afht2XvVjCR1O05owJV3Bx1Swmx3DdJnK/bscfTfNanbGGlRU4iAVUr7veLM7ZabKdmQ3rZjAi308EEowO4bASUCdu3bqIO9pDrMvk83v7YmwBzO5QvjGwCOjxOF+cSULWEfkTG5P9W+t7l+didEj2CNozIyUUbvhk2Kfz5ELQsbRcDrqifowEiUFBpt4hBwpG5zLudY9iJebjnnGsZkdIqb7NEh4kmFcwQFi/DBfmVxoatb3Xs5Ejgbd6Ixvv3glawWdOofaXetbxt00pTWCbjIanCIGa4bdg8+HwnVNldOf5B4CkkHvZdRXF0+hYqIXpv2UbcNvwNipZr3LpMwl5OZfeOwlNMZhQIUUXcbdswLPZCQw2f7OE6jiPk3Fzl6kzq8ipaAjluu4ojYr3PVoXL/EFa/KnJUQ0D8I5XgirNEXgjk1jSSqE9BorhR6IkaE0LBfka5EKXq9v7lqLvMAc43h4EORTgTltn1bZH7efC0IMKMYpuSPrJoGgOQjTsc8X+ttays//Yd+CyhRvzaaE2tv0Hkd6ayA/BxFWMjIhj2fXAC5YhO5PQJQyRb4P8A7MTU/wXds2yKZ5MdVtihVZM0ho9pIBVR3CqGEuPSeLRBSBevGhiof98QYFkbosFM3vBGFLGvEwHF51C+qWp+sSnaxPDgFz8Rq/ePmjMpujRkr3wiYxOi106J+E/E8QndmrRK7WTKnuPlpDSVLGqdwU1eej2Nrc+WZV4YdnG1hVrbFaBqTRttr8QL06238SF2qD1RfZM X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(136003)(396003)(346002)(39860400002)(376002)(230922051799003)(64100799003)(1800799009)(82310400011)(451199024)(186009)(40470700004)(46966006)(36840700001)(426003)(336012)(2616005)(26005)(16526019)(36860700001)(356005)(81166007)(82740400003)(31696002)(86362001)(36756003)(40480700001)(83380400001)(40460700003)(47076005)(316002)(54906003)(16576012)(44832011)(8676002)(8936002)(5660300002)(4326008)(41300700001)(6636002)(70206006)(110136005)(70586007)(2906002)(31686004)(6666004)(53546011)(478600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 06:09:53.1992 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d514ae5a-de19-4ca4-3123-08dbc30e31b1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4956 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231001_231008_469035_143BCA2A X-CRM114-Status: GOOD ( 20.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/30/23 09:17, Greg KH wrote: > On Fri, Sep 29, 2023 at 03:55:54AM -0700, Jay Buddhabhatti wrote: >> Some error event IDs for Versal and Versal NET are different. >> Both the platforms should access their respective error event >> IDs so use sub_family_code to check for platform and check >> error IDs for respective platforms. The family code is passed >> via platform data to avoid platform detection again. >> Platform data is setup when even driver is registered. >> >> Signed-off-by: Jay Buddhabhatti >> --- >> drivers/firmware/xilinx/zynqmp.c | 2 +- >> drivers/soc/xilinx/xlnx_event_manager.c | 25 ++++++++++++++++++++----- >> include/linux/firmware/xlnx-zynqmp.h | 16 ++++++++++++---- >> 3 files changed, 33 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c >> index 5f40288f69a9..6583efa9ac48 100644 >> --- a/drivers/firmware/xilinx/zynqmp.c >> +++ b/drivers/firmware/xilinx/zynqmp.c >> @@ -2019,7 +2019,7 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) >> np = of_find_compatible_node(NULL, NULL, "xlnx,versal"); >> if (np) { >> em_dev = platform_device_register_data(&pdev->dev, "xlnx_event_manager", >> - -1, NULL, 0); >> + -1, &pm_sub_family_code, 4); >> if (IS_ERR(em_dev)) >> dev_err_probe(&pdev->dev, PTR_ERR(em_dev), "EM register fail with error\n"); >> } >> diff --git a/drivers/soc/xilinx/xlnx_event_manager.c b/drivers/soc/xilinx/xlnx_event_manager.c >> index 38cfc161a713..8074ded7b39c 100644 >> --- a/drivers/soc/xilinx/xlnx_event_manager.c >> +++ b/drivers/soc/xilinx/xlnx_event_manager.c >> @@ -23,6 +23,7 @@ static DEFINE_PER_CPU_READ_MOSTLY(int, cpu_number1); >> >> static int virq_sgi; >> static int event_manager_availability = -EACCES; >> +static u32 pm_sub_family_code; > > Why is this not a per-device variable? Global variables like this for > drivers are almost always wrong. Not sure I get what you mean by per-device. Can you please elaborate on it? This is the part of firmware infrastructure and there is only one instance of the driver in the system registered from firmware driver itself. If this should be done in a generic way then there are much more variables which should be moved to driver data not just this one. Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel