From: Stefan Wahren <stefan.wahren@i2se.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-arm-kernel@lists.infradead.org,
Florian Fainelli <f.fainelli@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
Scott Branden <sbranden@broadcom.com>,
Marc Zyngier <maz@kernel.org>,
Serge Schneider <serge@raspberrypi.org>,
linux-kernel@vger.kernel.org, Phil Elwell <phil@raspberrypi.org>,
Matthias Brugger <mbrugger@suse.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
Martin Sperl <kernel@martin.sperl.org>,
Thomas Gleixner <tglx@linutronix.de>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Kristina Brooks <notstina@gmail.com>
Subject: Re: [PATCH v2] irqchip/bcm2835: Quiesce IRQs left enabled by bootloader
Date: Mon, 24 Feb 2020 10:21:39 +0100 [thread overview]
Message-ID: <1a5735e8-b876-92e4-9f1e-687f5abf8708@i2se.com> (raw)
In-Reply-To: <20200223182445.n44wgrourk4cpfoq@wunner.de>
Hi Lukas,
On 23.02.20 19:24, Lukas Wunner wrote:
> On Sun, Feb 23, 2020 at 06:59:56PM +0100, Stefan Wahren wrote:
>> thanks for all the investigation. Unfortunately the patch below doesn't
>> compile, since it lacks the definiton of REG_FIQ_ENABLE.
> Ugh, I recall fixing that when compile-testing. I must have forgotten
> to invoke "git commit --amend" before "git format-patch".
>
>> Btw the name is a little bit unlucky because it defines a single flag
>> within REG_FIQ_CONTROL instead of a separate register.
> The Foundation's repo uses that name so I stuck by it to reduce the
> number of merge conflicts Phil will have to resolve. Happy to change
> though, suggestions welcome.
readability has a higher prio. How about:
#define FIQ_CONTROL_ENABLE BIT(7)
Regards
Stefan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-24 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200212123651.apio6kno2cqhcskb@wunner.de>
2020-02-12 12:55 ` [PATCH v2] irqchip/bcm2835: Quiesce IRQs left enabled by bootloader Nicolas Saenz Julienne
2020-02-23 17:59 ` Stefan Wahren
[not found] ` <20200223182445.n44wgrourk4cpfoq@wunner.de>
2020-02-24 9:21 ` Stefan Wahren [this message]
2020-02-25 9:50 ` [PATCH v4] " Lukas Wunner
2020-02-07 16:11 [PATCH] " Marc Zyngier
2020-02-10 9:52 ` [PATCH v2] " Lukas Wunner
2020-02-12 4:47 ` Florian Fainelli
2020-02-12 8:13 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a5735e8-b876-92e4-9f1e-687f5abf8708@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jason@lakedaemon.net \
--cc=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lukas@wunner.de \
--cc=maz@kernel.org \
--cc=mbrugger@suse.com \
--cc=notstina@gmail.com \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=serge@raspberrypi.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).