linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: wcohen@redhat.com (William Cohen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0
Date: Wed, 7 Mar 2018 10:36:19 -0500	[thread overview]
Message-ID: <1a6f4b9f-d8dc-17e1-6f72-afbe510242e7@redhat.com> (raw)
In-Reply-To: <73a51582-2faa-6a75-6c7e-8888b24a3442@huawei.com>

On 03/07/2018 10:25 AM, John Garry wrote:
> On 07/03/2018 14:38, Arnaldo Carvalho de Melo wrote:
>> Em Wed, Mar 07, 2018 at 09:32:05AM -0500, William Cohen escreveu:
>>> On 03/07/2018 06:08 AM, Ganapatrao Kulkarni wrote:
>>>> There is MIDR change on ThunderX2 B0, adding an entry to mapfile
>>>> to enable JSON events for B0.
>>>>
>>>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
>>
>> Ganapatrao, can you please take this in consideration and if agreeing
>> send a v2 patch?
>>
>> With that I can add an Acked-by: wcohen, Right?

With that change I would ack it. -Will

>>
> 
> JFYI, This patch conflicts with "[PATCH v2 00/11] perf events patches for improved ARM64 support". I was planning on sending a v3 quite soon.
> 
>> - Arnaldo
>>>> ---
>>>> ?tools/perf/pmu-events/arch/arm64/mapfile.csv | 1 +
>>>> ?1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv b/tools/perf/pmu-events/arch/arm64/mapfile.csv
>>>> index e61c9ca..93c5d14 100644
>>>> --- a/tools/perf/pmu-events/arch/arm64/mapfile.csv
>>>> +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv
>>>> @@ -13,4 +13,5 @@
>>>> ?#
>>>> ?#Family-model,Version,Filename,EventType
>>>> ?0x00000000420f5160,v1,cavium,core
>>>> +0x00000000430f0af0,v1,cavium,core
>>>> ?0x00000000410fd03[[:xdigit:]],v1,cortex-a53,core
>>>>
>>>
>>> Hi,
>>> Like the cortex-a53 the last digit '0' of the match for the MIDR should be replaced with [[:xdigit:]] to allow for possible future revisions of chip:
>>>
>>> 0x00000000430f0af[[:xdigit:]],v1,cavium,core
>>>
>>>
>>> -Will Cohen
>>
>> .
> 
> Thanks,
> John
> 
>>
> 
> 

  reply	other threads:[~2018-03-07 15:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 11:08 [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0 Ganapatrao Kulkarni
2018-03-07 14:32 ` William Cohen
2018-03-07 14:38   ` Arnaldo Carvalho de Melo
2018-03-07 15:25     ` John Garry
2018-03-07 15:36       ` William Cohen [this message]
2018-03-07 17:35     ` Ganapatrao Kulkarni
2018-03-07 18:31       ` William Cohen
2018-03-08  4:14         ` Ganapatrao Kulkarni
2018-03-09 14:27           ` Ganapatrao Kulkarni
2018-03-09 14:34             ` Arnaldo Carvalho de Melo
2018-03-09 15:58               ` Will Deacon
2018-03-09 17:28                 ` Arnaldo Carvalho de Melo
2018-03-09 17:33                 ` Arnaldo Carvalho de Melo
2018-03-09 17:45                   ` Ganapatrao Kulkarni
2018-03-09 18:00                     ` Arnaldo Carvalho de Melo
2018-03-09 18:02                       ` Arnaldo Carvalho de Melo
2018-03-09 18:07                         ` Ganapatrao Kulkarni
2018-03-15 15:53           ` William Cohen
2018-03-15 16:47             ` John Garry
2018-03-21  2:37               ` William Cohen
2018-03-21 10:58                 ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a6f4b9f-d8dc-17e1-6f72-afbe510242e7@redhat.com \
    --to=wcohen@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).