From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35685C47077 for ; Wed, 17 Jan 2024 02:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gM9GOO5S3t8f9egNhmb9dMHAltzoEf4Jglc/Am9D0Ng=; b=UUpak5D/dD7zSu Au7yKD930HSlMDaWbfukn/vnhIpDeBsb1f6dNdEEJ/QB9YdJlejNJpDSrwmeQecsvupq/Zv9e/NFg K6AqmAbSuLB5cNG+Z1ntET7FbFm28fhfw6vy+QCUsSFr1ZMWo8w3bzspvz0Ougf4rRHjYvRFwx/ck kWGwC2TBrcIrexGYMVLgM8OZYGL3RrYloYr363w9aHqP5ndLKipa6ksINuJkbnuO0Ar2C9HpXw4tb xk96BbxUQmsZt+mRkBEcQsU7vR6hlsPGkMA303BPeEuL+po4lkoem52ZbXXzKXHWWnaasMQLlNla5 Y91h+t7vvHmKpf6ZNVuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPvml-00EEvb-38; Wed, 17 Jan 2024 02:36:11 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPvmh-00EEv6-1u for linux-arm-kernel@lists.infradead.org; Wed, 17 Jan 2024 02:36:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1705458967; x=1736994967; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=SeZhqpHfhhL14gEYlF5J7LST8mAd/5FSzjzIK+J2LQQ=; b=wkolp2zGphqoWAQ+UInyL3NSn/yK+W/EKHg+l3mxCsYbN7c+vczIWlrF lLzngt0xjjXRWbdKMBku0/hAjqH7U+2GZ4Ep/3cMPCen9yyCVjc7qqejf MC2jJIvkhobaw+mT3tOYpbJiUE1KC4jkO1mWiKoXLOmhbZ9gg2HEBlWJh oSIhi/nVHCxdAHg6TrVFH9xwW50s0Ci+rbntfsMi0mT/U/umlENr2pMNw elPRr7xtW7wozoxlMrxzKp55URC8RqUOBjq05W9saofmoVScSjyTRoO/D bZWD9MRoqZ3dWSZ3v2/9jTKVQb1FtiAGAtRjQj/8sbC3rG72Usu4P2Gvu Q==; X-CSE-ConnectionGUID: oCKMy2WoSFKismRMwoxpiA== X-CSE-MsgGUID: APkDsmD2SDqh26p6OyTWSg== X-IronPort-AV: E=Sophos;i="6.05,200,1701154800"; d="scan'208";a="182075909" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Jan 2024 19:36:06 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Jan 2024 19:35:30 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (10.10.215.250) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 16 Jan 2024 19:35:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NTJE2bephaq3zeT0NCYVycGs5CHWnVhUQs4Ic8lhTgAsDC3MgbphvYaPyyZK6AoyHdnrbUo7JAQdOebMesOgJA4ufYSFXzrHKT6XYrnoIYh2VIBEw9d+ihPkI2egqR+EN/SKgRYlU5nlCA/paKe3G8pOp+VO8DPrGqaB4hEhzhGI2Jm8twNE3KScRn5T0m3kSs3IL7CaSbUeWgWx6o69GD9GP3a2dM1CR2xvkRGpusxH7PbAtc641G+CXR6TgghubR56Y9scgsKL7iKyaUSLgErMHwwmCnX3XrfgXIJSy5RoPNdyTN8CDLAG7A1FnISGii8tTSiYvDcBNmygLlvvOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SeZhqpHfhhL14gEYlF5J7LST8mAd/5FSzjzIK+J2LQQ=; b=FcxaGhUhf7N7NeFYZLDxYo0pYKfOs2asbVjhAJVvk+WgOaAs9v7ce16Jj9OKe8koufBwkZ0JO3U+eyh8aAN/B6W0AfFXq4+udV1XvAHLmMEYSreWc+sgwrFVfnIVYeWpewNaz+gY5ZFPi6zuheSLAKBLgBYXEMXIQ+pCFquouFqpG2NiNc6G9HGDu3UvomlKoA3/x/amd5lPl/O7SF518mLtlsTDDEKlIS03nvcxaTcHAmXnPuP4Y3z8c+xkcIgTEdaVRmMnQK0rUYUaYM5Z7lvurGodu5dfnbOXDlOZif1R4HFcc+CcTx48T6CAdvv047pv9+DsYEd0tWORFKL04w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchip.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SeZhqpHfhhL14gEYlF5J7LST8mAd/5FSzjzIK+J2LQQ=; b=j5CcrpL6iiTvjoKdPl7wgTbuz7M/wuXnUZ/v1N2IUI3bYUgldr8mLzaaDSCxYqeBA15khHzQHxk7VRE4QUhgU2xy1RPeJXpy4lui+rbzow4SvA+NAIM9igwGJVAsZHJ77T+QirX2JUtBBMzTo108icAl7AOSt8ZuUoZG5f3THUNdN63pvnGIIZJRWNLPA5XXQKQr0hz4M1Uq7DjHyk4ZEnndrgZ1eP153aoQW+FleRyIkZgAyyN5Y/HOPfYIIjzCTUZvthY8/EukGgUGg20sPahGigvUDQrbkR2VEHpC4etBmnuI957BjLbhXFAIPp4xdnx4K0VpoGykounZ0yHKog== Received: from PH7PR11MB6451.namprd11.prod.outlook.com (2603:10b6:510:1f4::16) by SN7PR11MB6702.namprd11.prod.outlook.com (2603:10b6:806:269::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.23; Wed, 17 Jan 2024 02:35:26 +0000 Received: from PH7PR11MB6451.namprd11.prod.outlook.com ([fe80::80b9:80a3:e88a:57ee]) by PH7PR11MB6451.namprd11.prod.outlook.com ([fe80::80b9:80a3:e88a:57ee%3]) with mapi id 15.20.7202.020; Wed, 17 Jan 2024 02:35:26 +0000 From: To: Subject: Re: [PATCH v2 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema Thread-Topic: [PATCH v2 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema Thread-Index: AQHaSHCakAdMasJgKUaqbasJdJ7S+LDcuZGAgACRMYA= Date: Wed, 17 Jan 2024 02:35:25 +0000 Message-ID: <1a84946c-ba15-44ec-ae4a-3ad7a0673d4c@microchip.com> References: <20240116113800.82529-1-dharma.b@microchip.com> <20240116113800.82529-2-dharma.b@microchip.com> <20240116-coastal-amply-e495b07726df@spud> In-Reply-To: <20240116-coastal-amply-e495b07726df@spud> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6451:EE_|SN7PR11MB6702:EE_ x-ms-office365-filtering-correlation-id: 184b3398-0ac6-467c-755c-08dc1704f65b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ceaHOV5dgETih26chT6VvfUcwLwRddg757lT2e2GdNQVzXyEBmivr5jTSCIfmkmfQfM2Uyt4d21h/NTLQ6P9ZAD92PYxhbKBTgBa2T7IVeG+nhF5KL8EKTVl0tFYC7ySAsh7E5FbIPvj5BXfqZMwRCgPltGEXQEpoMqeHx0wL+ZIiAUQweTGF5pOTPmmCiv9KNo8HuXfA3ZVtqqaye4DEl8R9MJ2GsLsHXPMneWfHcyWDPvQkFzUEphB3kMU+PS/rTgNhz9ArwIZ/6eHj92U6xjoXMIMIqABumuKlHNFW8L7H0uLRKuw3jZ+D4PT35TI3FUiat4QXp5/dUZfzDbMhtQjqELYt8HC6WWSnNXh+CwbrZRylAu1bq68GRSZrFHCLZ/A7254nPzyb2hC9PYWOZ8S+r1K55aQfqONSWyTUDR8kcAdDHLzg4OkTYtB164ADAxLc71ltwwOqWJjW2gUFVYVpYrA/HCn/yV75kb+ezEvOA0Vg5jbrcGuHv6VvQcQ8pQ0j0+qYNZ7nnVnDmajqHOPdfxj9tyKcJv2T5SGBAmWQTBTPXEN5yshplLQPIIkfRn6v1egk0XAxD4JHDgQd8Wbwn60YSVfBN58wYPVDrJskxKuiLl13vc30+35GeAs0lH6AVg5va3Q10+GPZUictsHIUwcgsOsjipF3wg1zqnvzRGoNramObvNrrmbE1rYDsc+nQLEwy3TckbYterTkg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6451.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(366004)(346002)(396003)(376002)(230922051799003)(230173577357003)(230273577357003)(1800799012)(64100799003)(451199024)(186009)(31686004)(6506007)(71200400001)(107886003)(53546011)(6512007)(2616005)(26005)(38100700002)(36756003)(86362001)(31696002)(38070700009)(8936002)(2906002)(41300700001)(8676002)(4326008)(6486002)(122000001)(83380400001)(7416002)(5660300002)(478600001)(316002)(91956017)(76116006)(66946007)(66476007)(66446008)(64756008)(54906003)(66556008)(6916009)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WmFONWhXd1NlSkVLMnYwbGF0Vzd6RW5GUWxmOWh5Z0tlUUJTcU03cGUrVis4?= =?utf-8?B?WEZYeCsvMS8veFdaZkIwRWd3eDVQWGNDdkF2QWVxUXBNR0oxblhwWlVUNmxu?= =?utf-8?B?VzFiQ2lnaTAxV3NvQkYvRlRFRkd3ejFpamlKL3ZjWXhPekdpSkFmTHdIR3lt?= =?utf-8?B?MFVTMStLcFVXSEhoSFg2cDZYNENXME4rRDFmWWwrVWVDUWRiRG03OWJPd1hn?= =?utf-8?B?K2ROenR0VGV6K29qQTVNYmJqRlRYU2ZXQlRzZ040eW84TFZ4YVkrVkJLU1VZ?= =?utf-8?B?WmNadURlVDBPUW8xOUU5aHlQQ3d2ZmdzZmttQWRMNmhYUVE0MGM2ajJjcDVo?= =?utf-8?B?K2wvNkQxT2NvbWVaNE82VnRSTTJ3VEFQRHJWMDZpYW1YRG5DSUtWdjRZaG10?= =?utf-8?B?anhPdXJUT20xeDh5ZmY3V1dPVzVRTTNFekVFZjdlRkFCL2lYUXVRblorNnZx?= =?utf-8?B?ZGU5WDdON2M4Sm1nUlpQemliclBva0tGVHJLdEpCTkNYTVNtR2lwdGY2Vk5V?= =?utf-8?B?OUs5RVBvMFdYTUhxM1hjc1hyRjBibzQ0R3ZOUE1uaVZMb3RNUTVaWis2SXJ0?= =?utf-8?B?QllVTGtjU0R2T3FXbWhFTEJPWENZUEJIWHFJSVFILy9LakNKU3lOTUxvVEk3?= =?utf-8?B?V3RENU5hNVV5SXNJY2xseUV1dkF6eEJKMmtLMjk2U0d5b01nejhWQ09uYkI2?= =?utf-8?B?TEw4VXExbS9Gd0RJL2RQNUk4ODB0ajlMTmlmSGpqeHQ0eFRCdjQ1MDJJVCsr?= =?utf-8?B?L2ZqQjFoSEZKT1NwSWVhcUZlL1UzV2tBb1p2NHc3L3JKWHdxUk5Ia0E0dGta?= =?utf-8?B?TVg4bm5ZaTBrSFpWMThCRDdOQlJIQUg2eWVoUkdpbEFLb0hGdEUrNUIvbU53?= =?utf-8?B?c0lUL3A2U2ozY2F1WXdHVDNiZXVQWTRxZ2JFNUJLZWVDLzBOYkl1NExFRXZ3?= =?utf-8?B?dEtoM3pvR0MwVmVQQUh0MnpoRU1EVTBEYkh3OW1jZkZQMkFkRFcwWEdpVlJ1?= =?utf-8?B?aU8zbXd2TFhsNnhkTFlscEk5MXNJaEpaYnZiUmxEQXVlczdtRmlnT2xTZGhs?= =?utf-8?B?YU9pRGh0aW9ma3NsOXdyUFduYTFZemg3RnZ4SzdLNi95QlcrWkJVeE1iK1Mz?= =?utf-8?B?eUNkNGFWbnpBWTl4aGhwMlBTS3F0ZDVqa3V2TjFENFhxelhjSnptY00rbCtX?= =?utf-8?B?bmtrRk83dTNOMFJBb0dYSUx4N0xKcUxsVlJUZ0FrcGdYNGJUTElzUG10cmlH?= =?utf-8?B?Ky9xWWJMa1VWUWpEaVl1V09FQlFCVkdNbUJ3cloxU2RqbXlqOCtySkR2a3Uv?= =?utf-8?B?S1I4YVNYbUgxaDU0c3gwMm1JeDJBNDZSSU9Mb3ZUdVFOcFpyRi9rczJyZUFI?= =?utf-8?B?ZzZVM3E3QzEvN0FkN3JrdDBHeDUyaGh6U2hMU09RUTQ2SEg2WGNvZDhBM3M0?= =?utf-8?B?bG96RkQxb3djRWREQUFWbE1xYVZ2RnA0UkQ4dEJRQVVVY1IvaTBsQ1dja3Fh?= =?utf-8?B?K2lwQWtaK0xBZER2T2dLbGFSUlEwblc1a1pYVWk1MU1Kcnd2SlYxOTVLRjdB?= =?utf-8?B?WDVveVpNVXJXRFV0TVRBUVpsaUlpeTlmenp0VzZUTXJtR2NGZFluSm1lQ3d3?= =?utf-8?B?VktPR2UzcXJUUTgwZGtUWDVZRTlrZWgwclczWmtxVHdVR1ZhOTk4RXQ2YWp1?= =?utf-8?B?TTBlS0t0NjV2ZmhNbFdNL1VmdXZEcGFVRjk1M3FZYzZIQ1lHa1JWM2N0RGFT?= =?utf-8?B?L05uQytBRzdjMnpNdzR1RTRnTU85TEVsQk1EeERidWwrYU9OVVJld3E0Sno4?= =?utf-8?B?K2hWMTVvWXdBb0I2NFpyZDY2ZDFuUEtmTlF5dEhkNFBIaXllOFI0YlJZUlFz?= =?utf-8?B?SDBvajE4KzlNUkxJa3IxclBORlV1N1dKOWYydWtkY0VoNHlVd3Jta240ZkZB?= =?utf-8?B?SXZKdFIxUFp6YTFJOC9QaDJMaThQNko4M3ovdkF5V0M5S095blpiQUNBdXYy?= =?utf-8?B?Nk95d3NUTTJia0lZaDBuQ2FZKzJyUlJXTEptTExFZHlJQ05kK2F1NGNMK3Bt?= =?utf-8?B?MUhZSEhRV2grYnVyQ0w0M2toeHptN1YwQzN3aEFEa3dqVEFwR3pua3QzRTU0?= =?utf-8?Q?fPihJ9uhayVbbIcuHGoQ2qa5X?= Content-ID: <612FED6CE343C4459257AD08330C740D@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 184b3398-0ac6-467c-755c-08dc1704f65b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2024 02:35:26.0019 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jPfruVpzExoJkfIAKhb3tRO5nWwLuahEY2lpH25SkhvhKGLvzQOsHIjeThzvm7TnyBkP0Rj65VrliAdpVnX6lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6702 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240116_183608_033023_7EC4EA8A X-CRM114-Status: GOOD ( 21.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-pwm@vger.kernel.org, Linux4Microchip@microchip.com, dri-devel@lists.freedesktop.org, Conor.Dooley@microchip.com, thierry.reding@gmail.com, krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@tuxon.dev, airlied@gmail.com, sam@ravnborg.org, lee@kernel.org, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, conor+dt@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, mripard@kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/01/24 11:25 pm, Conor Dooley wrote: > Yo, > > On Tue, Jan 16, 2024 at 05:07:58PM +0530, Dharma Balasubiramani wrote: >> Convert the existing DT binding to DT schema of the Atmel's HLCDC display >> controller. >> >> Signed-off-by: Dharma Balasubiramani >> --- >> changelog >> v1 -> v2 >> - Remove the explicit copyrights. >> - Modify filename like compatible. >> - Modify title (drop words like binding/driver). >> - Modify description actually describing the hardware and not the driver. >> - Remove pinctrl properties which aren't required. >> - Ref endpoint and not endpoint-base. >> - Drop redundant info about bus-width description and add ref to video-interfaces. >> - Move 'additionalProperties' after 'Required'. >> - Drop parent node and it's other sub-device node which are not related here. >> - Add compatible to example 2 and add comments that bus-width is the diff between two examples. >> --- >> .../atmel/atmel,hlcdc-display-controller.yaml | 110 ++++++++++++++++++ >> .../bindings/display/atmel/hlcdc-dc.txt | 75 ------------ >> 2 files changed, 110 insertions(+), 75 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml >> delete mode 100644 Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt >> >> diff --git a/Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml b/Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml >> new file mode 100644 >> index 000000000000..f022c294cfbc >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml >> @@ -0,0 +1,110 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id:http://devicetree.org/schemas/display/atmel/atmel,hlcdc-display-controller.yaml# >> +$schema:http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Atmel's High LCD Controller (HLCDC) >> + >> +maintainers: >> + - Nicolas Ferre >> + - Alexandre Belloni >> + - Claudiu Beznea >> + >> +description: | > This | is not needed as you have no formatting to preserve. Sure, I will drop this '|'. > >> + The LCD Controller (LCDC) consists of logic for transferring LCD image >> + data from an external display buffer to a TFT LCD panel. The LCDC has one >> + display input buffer per layer that fetches pixels through the single bus >> + host interface and a look-up table to allow palletized display >> + configurations. >> + >> +properties: >> + compatible: >> + const: atmel,hlcdc-display-controller >> + >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 >> + >> + port@0: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: >> + Output endpoint of the controller, connecting the LCD panel signals. >> + >> + properties: >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 >> + >> + reg: >> + maxItems: 1 >> + >> + endpoint: >> + $ref: /schemas/graph.yaml#/$defs/endpoint > $ref: /schemas/media/video-interfaces.yaml# I will replace this. > > to match approximately all other endpoints? I'm not sure; some of the referenced devices, like this one, were pointing to 'endpoint.' I will go with 'video-interfaces.' > >> + unevaluatedProperties: false >> + description: >> + Endpoint connecting the LCD panel signals. >> + >> + properties: >> + bus-width: >> + description: Endpoint bus width. >> + $ref: /schemas/media/video-interfaces.yaml# > and then bus-width's type is already defined for you, no? I will remove this $ref here. > >> + enum: [ 12, 16, 18, 24 ] >> + >> +required: >> + - '#address-cells' >> + - '#size-cells' >> + - compatible >> + - port@0 >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + //Example 1 >> + >> + display-controller { >> + compatible = "atmel,hlcdc-display-controller"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0>; >> + >> + hlcdc_panel_output: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&panel_input>; >> + }; >> + }; >> + }; >> + >> + - | >> + //Example 2 With a video interface override to force rgb565, bus-width=16 >> + >> + display-controller { >> + compatible = "atmel,hlcdc-display-controller"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb565>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0>; > Should be a newline here before the child node. Sure, I will take care of this in v3. -- With Best Regards, Dharma B. > > Cheers, > Conor. > >> + hlcdc_panel_output2: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&panel_input>; >> + bus-width = <16>; >> + }; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt >> deleted file mode 100644 >> index 923aea25344c..000000000000 >> --- a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt >> +++ /dev/null >> @@ -1,75 +0,0 @@ >> -Device-Tree bindings for Atmel's HLCDC (High LCD Controller) DRM driver >> - >> -The Atmel HLCDC Display Controller is subdevice of the HLCDC MFD device. >> -See ../../mfd/atmel-hlcdc.txt for more details. >> - >> -Required properties: >> - - compatible: value should be "atmel,hlcdc-display-controller" >> - - pinctrl-names: the pin control state names. Should contain "default". >> - - pinctrl-0: should contain the default pinctrl states. >> - - #address-cells: should be set to 1. >> - - #size-cells: should be set to 0. >> - >> -Required children nodes: >> - Children nodes are encoding available output ports and their connections >> - to external devices using the OF graph representation (see ../graph.txt). >> - At least one port node is required. >> - >> -Optional properties in grandchild nodes: >> - Any endpoint grandchild node may specify a desired video interface >> - according to ../../media/video-interfaces.txt, specifically >> - - bus-width: recognized values are <12>, <16>, <18> and <24>, and >> - override any output mode selection heuristic, forcing "rgb444", >> - "rgb565", "rgb666" and "rgb888" respectively. >> - >> -Example: >> - >> - hlcdc: hlcdc@f0030000 { >> - compatible = "atmel,sama5d3-hlcdc"; >> - reg = <0xf0030000 0x2000>; >> - interrupts = <36 IRQ_TYPE_LEVEL_HIGH 0>; >> - clocks = <&lcdc_clk>, <&lcdck>, <&clk32k>; >> - clock-names = "periph_clk","sys_clk", "slow_clk"; >> - >> - hlcdc-display-controller { >> - compatible = "atmel,hlcdc-display-controller"; >> - pinctrl-names = "default"; >> - pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>; >> - #address-cells = <1>; >> - #size-cells = <0>; >> - >> - port@0 { >> - #address-cells = <1>; >> - #size-cells = <0>; >> - reg = <0>; >> - >> - hlcdc_panel_output: endpoint@0 { >> - reg = <0>; >> - remote-endpoint = <&panel_input>; >> - }; >> - }; >> - }; >> - >> - hlcdc_pwm: hlcdc-pwm { >> - compatible = "atmel,hlcdc-pwm"; >> - pinctrl-names = "default"; >> - pinctrl-0 = <&pinctrl_lcd_pwm>; >> - #pwm-cells = <3>; >> - }; >> - }; >> - >> -Example 2: With a video interface override to force rgb565; as above >> -but with these changes/additions: >> - >> - &hlcdc { >> - hlcdc-display-controller { >> - pinctrl-names = "default"; >> - pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb565>; >> - >> - port@0 { >> - hlcdc_panel_output: endpoint@0 { >> - bus-width = <16>; >> - }; >> - }; >> - }; >> - }; >> -- >> 2.25.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel